Support root cert validation on CURL #4821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RickWinter
requested review from
ahsonkhan,
antkmsft,
vhvb1989,
gearama and
LarryOsterman
as code owners
LarryOsterman
approved these changes
Jul 27, 2023
ahsonkhan
reviewed
Jul 27, 2023
ahsonkhan
reviewed
Jul 27, 2023
ahsonkhan
reviewed
Jul 28, 2023
| @@ -62,6 +62,8 @@ namespace Azure { namespace Core { namespace Http { | |||
| * @remark More about this option: | |||
| * https://curl.se/libcurl/c/CURLOPT_CAINFO_BLOB.html | |||
| * | |||
| * @warning Requires libcurl >= 7.44.0 | |||
| * | |||
| */ | |||
| std::string PemEncodedExpectedRootCertificates; | |||
There was a problem hiding this comment.
Because we are not if-defing this out for older versions, any customer who sets this with older version of curl will be surprised to see it ignored.
Throwing is a good signal that the customer has to fix something, rather than silently ignoring the setting.
There was a problem hiding this comment.
I'm 50/50 on throwing here. If the customer notices it's ignored, there is a rather clear indication in the code describing the reason for the option being ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for validating root certificates when CURL version is >= 7.77.0 .
Fixes #4792