-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Identity: Improve diagnosability #4744
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antkmsft
requested review from
schaabs,
ahsonkhan,
RickWinter,
vhvb1989,
gearama and
LarryOsterman
as code owners
June 29, 2023 17:51
LarryOsterman
approved these changes
Jun 29, 2023
Co-authored-by: Larry Osterman <[email protected]>
RickWinter
requested changes
Jun 29, 2023
RickWinter
reviewed
Jun 29, 2023
RickWinter
reviewed
Jun 29, 2023
RickWinter
approved these changes
Jul 5, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Look at the bug #4723: the customer did a great job debugging the problem with SDK, finding the actual server response, and including it in the bug.
This change is to make diagnosability simpler: turn on the verbose level of logging and if there is token JSON parse error, see more details. It is easier to log a bug, or if a customer contacts us with just the exception, we can tell them how to easily get more details for the bug.
It is good to have this, because access token JSON is basically the only external input for Identity, and also it could be that we can't reproduce the same response in our environment, but when we have these details, we could much better see what kind of response is there, construct the similar input and make a fix.
If this functionality was in place when the customer has logged that bug, here's what they'd seen:
Azure::Core::Credentials::AuthenticationException
with the descriptionwould've been thrown.
The log would say: