Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create AMQP Management APIs; significant cleanup of Impl types to remove reference values. #4560

Merged

Conversation

LarryOsterman
Copy link
Member

Added initial support for AMQP Management APIs.

Initial support for AMQP management APIs.

Bonus changes:

  1. Impl types no longer reference non-Impl types
  2. Impl types now use RAII wrappers around uAMQP types.
  3. Removed connectionToPoll parameter from most APIs.
  4. Renamed Message to AmqpMessage to reduce possible type confusion.
  5. Added the ability to detect empty messages.
  6. Removed interop methods from MessageHeader, MessageProperties, and AmqpMessage in favor of factory methods which do the same.
  7. Significant cleanup of MockAmqpServer test server to enable more flexibility.
  8. Yield during polling loops to reduce CPU overhead.
  9. Removed CreateChar and GetChar in favor of char32_t type.

Fixes #4549

Pull Request Checklist

Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:

See the detailed list in the contributing guide.

  • C++ Guidelines
  • Doxygen docs
  • Unit tests
  • No unwanted commits/changes
  • Descriptive title/description
    • PR is single purpose
    • Related issue listed
  • Comments in source
  • No typos
  • Update changelog
  • Not work-in-progress
  • External references or docs updated
  • Self review of PR done
  • Any breaking changes?

@LarryOsterman LarryOsterman linked an issue Apr 19, 2023 that may be closed by this pull request
@LarryOsterman LarryOsterman merged commit 409b19e into Azure:feature/amqp Apr 20, 2023
@LarryOsterman LarryOsterman deleted the larryo/createmanagementapi branch April 20, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add AMQP Management APIs
2 participants