Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creadscan skips #3671

Merged
merged 10 commits into from
May 31, 2022
Merged

Creadscan skips #3671

Changes from 7 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
99db07b
one commit to rule them all
gearama Apr 7, 2022
da41922
Merge branch 'main' of https://github.com/gearama/azure-sdk-for-cpp
gearama Apr 7, 2022
3a87b5a
Merge branch 'main' of https://github.com/gearama/azure-sdk-for-cpp
gearama Apr 19, 2022
dce08e2
main merge
gearama Apr 7, 2022
a3bf3bc
Merge branch 'main' of https://github.com/gearama/azure-sdk-for-cpp
gearama May 24, 2022
1df702a
error
gearama May 24, 2022
7d93d20
add recordings for cred scan skipping
gearama May 24, 2022
baf0ee6
certificates added
gearama May 25, 2022
676b45a
remove dupe
gearama May 25, 2022
23783d1
cspell
gearama May 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions eng/CredScanSuppression.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,11 @@
"tool": "Credential Scanner",
"suppressions": [
{
"file":[
"eng/common/testproxy/dotnet-devcert.pfx"
gearama marked this conversation as resolved.
Show resolved Hide resolved
gearama marked this conversation as resolved.
Show resolved Hide resolved
],
"_justification": "File contains private key used by test code."
"file": [
"sdk/keyvault/azure-security-keyvault-certificates/test/ut/recordings/KeyVaultCertificateClientTest.DownloadImportPem.json",
gearama marked this conversation as resolved.
Show resolved Hide resolved
"sdk/keyvault/azure-security-keyvault-certificates/test/ut/recordings/KeyVaultCertificateClientTest.DownloadImportPkcs.json.",
],
"_justification": "File contains recording for playback, not valid certificate."
}
]
}