RequestFailedException: decouple Message and what(). #3201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antkmsft
requested review from
ahsonkhan,
gearama,
Jinming-Hu,
katmsft,
RickWinter,
vhvb1989 and
vinjiang
as code owners
antkmsft
added
Azure.Core
MQ
|
/azp run cpp - core |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run cpp - storage |
|
/azp run cpp - keyvault |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run cpp - identity |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
Jinming-Hu
approved these changes
Dec 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2542.
whatArgtowhatper Jeffrey's feedback: Rename exceptions message parameter towhatArg#2782 (comment)RequestFailedException(what, response)is the unit test.whatis what we set programmatically,Messageis what gets returned from the service.