Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure::Core::Operation<T>::GetRawResponseInternal() is never used #4662

Closed
Jinming-Hu opened this issue May 30, 2023 · 1 comment · Fixed by #4667
Closed

Azure::Core::Operation<T>::GetRawResponseInternal() is never used #4662

Jinming-Hu opened this issue May 30, 2023 · 1 comment · Fixed by #4667
Assignees
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.

Comments

@Jinming-Hu
Copy link
Member

This is a pure virtual method. Every derived class needs to implement it, from what I can see, all derived classes have the same implementation with only 1-line code return *m_rawResponse;. But this method is not used anywhere, can we just delete it?

I found this problem when working on improving storage test coverage, this line of code can never be reached.

image

@Jinming-Hu Jinming-Hu added Azure.Core Client This issue points to a problem in the data-plane of the library. labels May 30, 2023
@antkmsft
Copy link
Member

antkmsft commented Jul 5, 2023

See also #4749

azure-sdk added a commit to azure-sdk/vcpkg that referenced this issue Jul 6, 2023
## 1.10.1 (2023-07-06)

### Breaking Changes

- [[microsoft#4662]](Azure/azure-sdk-for-cpp#4662) `Azure::Core::Operation<T>::GetRawResponseInternal()` is now deprecated and no longer requires an overload.

### Other Changes

- Empty diagnostic messages will no longer be generated.
JavierMatosD pushed a commit to microsoft/vcpkg that referenced this issue Jul 7, 2023
…32425)

* [azure-identity-cpp] Update to 1.5.1
## 1.5.1 (2023-07-06)

### Bugs Fixed

- [#4723]](Azure/azure-sdk-for-cpp#4723) Accept a wider variety of token responses.

* [azure-core-cpp] Update to 1.10.1
## 1.10.1 (2023-07-06)

### Breaking Changes

- [[#4662]](Azure/azure-sdk-for-cpp#4662) `Azure::Core::Operation<T>::GetRawResponseInternal()` is now deprecated and no longer requires an overload.

### Other Changes

- Empty diagnostic messages will no longer be generated.

* [azure-core-amqp-cpp] Update to 1.0.0-beta.1
## 1.0.0-beta.1 (2023-07-06)

### Features Added

- Initial release

* Dependency search fix

* Dependency link fix

* x-add-version

---------

Co-authored-by: Anton Kolesnyk <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants