The user-agent string when using KeyVault::Keys::Cryptography::CryptographyClient is not setup correctly.

[ahsonkhan]

The telemetryPackageName parameter within the pipeline ctor (and therefore the user-agent string) for the KeyVault Keys package, when using the CryptographyClient is not setup correctly.

See:

azure-sdk-for-cpp/sdk/keyvault/azure-security-keyvault-keys/src/cryptography/cryptography_client.cpp

Lines 112 to 117 in c457e91

	m_pipeline = std::make_shared<Azure::Core::Http::_internal::HttpPipeline>(
	options,
	"KeyVault",
	PackageVersion::ToString(),
	std::move(perRetrypolicies),
	std::move(perCallpolicies));

In other clients within this package (along with other packages), use a different string. In this case, that would be keyvault-keys:

azure-sdk-for-cpp/sdk/keyvault/azure-security-keyvault-keys/src/key_client.cpp

Lines 83 to 88 in c457e91

	m_pipeline = std::make_shared<Azure::Core::Http::_internal::HttpPipeline>(
	options,
	KeyVaultServicePackageName,
	PackageVersion::ToString(),
	std::move(perRetrypolicies),
	std::move(perCallpolicies));

azure-sdk-for-cpp/sdk/keyvault/azure-security-keyvault-keys/src/key_client.cpp

Line 32 in c457e91

constexpr static const char KeyVaultServicePackageName[] = "keyvault-keys";

cc @gearama

[LarryOsterman]

A minor nit: The package name is keyvault-keys-cpp, not keyvault-keys. THe Azure Core SDK guidelines say that the package name in the user-agent should be the user visible package name, and the user visible package name is azure-security-keyvault-keys-cpp