Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up EngSys branches #3116

Closed
antkmsft opened this issue Nov 18, 2021 · 11 comments
Closed

Clean up EngSys branches #3116

antkmsft opened this issue Nov 18, 2021 · 11 comments
Assignees
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system. MQ This issue is part of a "milestone of quality" initiative.
Milestone

Comments

@antkmsft
Copy link
Member

https://github.com/Azure/azure-sdk-for-cpp/branches/all

Some branches look like they are personal branches, some are stale. Almost all belong to EngSys, so I suggest to assign this work item to them.

I think there should not be personal or engsys branches at this point, that are only made for the purposes of making a PR. Instead, you fork the repo, create the branch there, and create a PR to this repo - just as we do with our dev branches.

If it is a feature, or another branch of this sort, intended for long life, it is ok.

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 18, 2021
@antkmsft antkmsft changed the title Clean up branches Clean up EngSys branches Nov 18, 2021
@RickWinter RickWinter added bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system. labels Nov 18, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 18, 2021
@RickWinter RickWinter added the MQ This issue is part of a "milestone of quality" initiative. label Nov 18, 2021
@RickWinter RickWinter added this to the [2022] January milestone Nov 18, 2021
@RickWinter
Copy link
Member

@danieljurek Can this be prioritized so we can close out this issue

@RickWinter RickWinter added Central-EngSys This issue is owned by the Engineering System team. and removed Client This issue points to a problem in the data-plane of the library. labels Apr 22, 2022
@danieljurek
Copy link
Member

A lot of EngSys work needs to happen in branches off the main repo instead of in a fork. In almost every case where I create a branch from a fork I end up moving it into the main repo to test some scenario or another.

djurek/* branches deleted, following up on the others...

@danieljurek
Copy link
Member

Following up on remaining branches:
@chidozieononiwu -- Can you have a look at these branches and delete them if they're no longer needed:

  • UpdateUbuntuVMImage (compare) -- We're specific about the VM images we're using here so I think updating this is not the right move... this branch can also be deleted because the work of setting image versions is happening here
  • MarkTemplateAsTestPkg (compare)
  • PrepForToolsChanges (compare)

@danieljurek
Copy link
Member

@sima-zhu -- Can you look at this branch and delete if it's no longer needed:

@sima-zhu
Copy link
Contributor

@sima-zhu -- Can you look at this branch and delete if it's no longer needed:

No. It is still in use in docindex. link

gh-pages is a one commit branch. So we need to start from an empty repo every time we push the changes. That's the reason we have to retain the gh-pages-root.

@danieljurek
Copy link
Member

@sima-zhu -- Looks like we should put a branch protection rule in place.

@sima-zhu
Copy link
Contributor

@sima-zhu -- Looks like we should put a branch protection rule in place.

That's great idea. I don't have permission to do so. @danieljurek Could you help setup the protection rule?

@danieljurek
Copy link
Member

We already have one in place for gh-pages*... Great :)

image

@danieljurek
Copy link
Member

@chidozieononiwu -- Would you have a look at the branches and let us know if we need to keep those around? #3116 (comment)

@chidozieononiwu
Copy link
Member

@chidozieononiwu -- Would you have a look at the branches and let us know if we need to keep those around? #3116 (comment)

I have removed them all.

@danieljurek
Copy link
Member

Thanks everyone. There are a few remaining eng/common branches for ongoing work and those will be cleaned up as that work merges.

We can close this one now :)

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system. MQ This issue is part of a "milestone of quality" initiative.
Projects
None yet
Development

No branches or pull requests

5 participants