-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added enableAzureRBAC property in ManagedClusterAADProfile #9771
Merged
PhoenixHe-NV
merged 3 commits into
Azure:dev-containerservice-Microsoft.ContainerService-2020-06-01
from
Anumita:dev-containerservice-Microsoft.ContainerService-2020-06-01
Jun 12, 2020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Staging] Swagger Validation Report️ ~[Staging] BreakingChange [Detail]Posted by Swagger Pipeline |
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-js
|
Trenton Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Azure CLI Extension Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net
|
azure-sdk-for-go
|
azure-sdk-for-python
|
Can one of the admins verify this patch? |
weinong
reviewed
Jun 8, 2020
...erservice/resource-manager/Microsoft.ContainerService/stable/2020-06-01/managedClusters.json
Outdated
Show resolved
Hide resolved
openapi-assignment-bot
bot
added
the
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
label
Jun 9, 2020
PhoenixHe-NV
reviewed
Jun 9, 2020
...erservice/resource-manager/Microsoft.ContainerService/stable/2020-06-01/managedClusters.json
Show resolved
Hide resolved
majastrz
added
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
and removed
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
labels
Jun 9, 2020
majastrz
approved these changes
Jun 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed off from ARM side.
/openapi sdkautomation |
Azure Pipelines successfully started running 1 pipeline(s). |
3 similar comments
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jun 10, 2020
Anumita
force-pushed
the
dev-containerservice-Microsoft.ContainerService-2020-06-01
branch
from
June 10, 2020 09:56
a49f685
to
2513f34
Compare
Pull request contains merge conflicts. |
…-01' into dev-containerservice-Microsoft.ContainerService-2020-06-01
Azure Pipelines successfully started running 1 pipeline(s). |
hi @NullMDR is this PR ok to merge? thanks. |
PhoenixHe-NV
merged commit Jun 12, 2020
b633249
into
Azure:dev-containerservice-Microsoft.ContainerService-2020-06-01
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.