Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new API for private endpoint connections on AKS #9706

Conversation

gossion
Copy link
Member

@gossion gossion commented Jun 4, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
    • adding/removing APIs.
    • adding/removing properties.
    • adding/removing API-version.
    • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 4, 2020

[Staging] Swagger Validation Report

  • ️✔️~[Staging] BreakingChange [Detail]

  • Posted by Swagger Pipeline

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azuresdkci
    Copy link
    Contributor

    Can one of the admins verify this patch?

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jun 4, 2020

    azure-sdk-for-java

    ⚠️ warning [Logs] [Expand Details]

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jun 4, 2020

    Azure CLI Extension Generation

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jun 4, 2020

    azure-sdk-for-go

    ️✔️ succeeded [Logs] [Expand Details]

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jun 4, 2020

    azure-sdk-for-net

    ️✔️ succeeded [Logs] [Expand Details]

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jun 4, 2020

    Trenton Generation

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jun 4, 2020

    azure-sdk-for-python

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from 0fd8e5b with merge commit 4b9933fb25081e6d4d9d8936c18ce9aea1a40cba. SDK Automation 13.0.17.20200526.1
    • ️✔️azure-mgmt-containerservice [View full logs]  [Preview SDK Changes]
      [build_conf] INFO:packaging_tools:Building template azure-mgmt-containerservice
      [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
      [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
      [build_conf] INFO:packaging_tools:Template done azure-mgmt-containerservice
      [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-07-01', '2019-04-01'} in label v2017_07_01
      [after_scripts|python] WARNING:__main__:Guessing you want 2017-07-01 based on label v2017_07_01
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
      [ChangeLog] Size of delta 6.590% size of original (original: 60439 chars, delta: 3983 chars)
      [ChangeLog] **Features**
      [ChangeLog] 
      [ChangeLog]   - Model AgentPool has a new parameter proximity_placement_group_id
      [ChangeLog]   - Model ManagedClusterAgentPoolProfile has a new parameter proximity_placement_group_id
      [ChangeLog]   - Model ManagedClusterAgentPoolProfileProperties has a new parameter proximity_placement_group_id
      [ChangeLog]   - Added operation group PrivateEndpointConnectionsOperations

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jun 4, 2020

    azure-sdk-for-js

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from 0fd8e5b with merge commit 4b9933fb25081e6d4d9d8936c18ce9aea1a40cba. SDK Automation 13.0.17.20200526.1
    • ️✔️@azure/arm-containerservice [View full logs]  [Preview SDK Changes]
      Only show 100 items here, please refer to log for details.
      No run LangAfterScript
      [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
      [npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
      [npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
      [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
      [npmPack] loaded rollup.config.js with warnings
      [npmPack] (!) Unused external imports
      [npmPack] default imported from external module 'rollup' but never used
      [npmPack] 
      [npmPack] ./esm/containerServiceClient.js → ./dist/arm-containerservice.js...
      [npmPack] created ./dist/arm-containerservice.js in 360ms
      [npmPack] npm notice 
      [npmPack] npm notice package: @azure/[email protected]
      [npmPack] npm notice === Tarball Contents === 
      [npmPack] npm notice 10.9kB  esm/operations/agentPools.js                         
      [npmPack] npm notice 2.2kB   esm/models/agentPoolsMappers.js                      
      [npmPack] npm notice 204.1kB dist/arm-containerservice.js                         
      [npmPack] npm notice 73.9kB  dist/arm-containerservice.min.js                     
      [npmPack] npm notice 2.0kB   esm/containerServiceClient.js                        
      [npmPack] npm notice 2.6kB   esm/containerServiceClientContext.js                 
      [npmPack] npm notice 11.8kB  esm/operations/containerServices.js                  
      [npmPack] npm notice 2.1kB   esm/models/containerServicesMappers.js               
      [npmPack] npm notice 345B    esm/models/index.js                                  
      [npmPack] npm notice 573B    esm/operations/index.js                              
      [npmPack] npm notice 24.5kB  esm/operations/managedClusters.js                    
      [npmPack] npm notice 2.2kB   esm/models/managedClustersMappers.js                 
      [npmPack] npm notice 81.8kB  esm/models/mappers.js                                
      [npmPack] npm notice 12.6kB  esm/operations/openShiftManagedClusters.js           
      [npmPack] npm notice 2.1kB   esm/models/openShiftManagedClustersMappers.js        
      [npmPack] npm notice 1.6kB   esm/operations/operations.js                         
      [npmPack] npm notice 458B    esm/models/operationsMappers.js                      
      [npmPack] npm notice 4.4kB   esm/models/parameters.js                             
      [npmPack] npm notice 7.2kB   esm/operations/privateEndpointConnections.js         
      [npmPack] npm notice 2.1kB   esm/models/privateEndpointConnectionsMappers.js      
      [npmPack] npm notice 1.0kB   rollup.config.js                                     
      [npmPack] npm notice 1.7kB   package.json                                         
      [npmPack] npm notice 457B    tsconfig.json                                        
      [npmPack] npm notice 3.4kB   esm/operations/agentPools.d.ts.map                   
      [npmPack] npm notice 5.4kB   esm/operations/agentPools.js.map                     
      [npmPack] npm notice 906B    esm/models/agentPoolsMappers.d.ts.map                
      [npmPack] npm notice 919B    esm/models/agentPoolsMappers.js.map                  
      [npmPack] npm notice 395.3kB dist/arm-containerservice.js.map                     
      [npmPack] npm notice 53.5kB  dist/arm-containerservice.min.js.map                 
      [npmPack] npm notice 811B    esm/containerServiceClient.d.ts.map                  
      [npmPack] npm notice 1.0kB   esm/containerServiceClient.js.map                    
      [npmPack] npm notice 480B    esm/containerServiceClientContext.d.ts.map           
      [npmPack] npm notice 1.3kB   esm/containerServiceClientContext.js.map             
      [npmPack] npm notice 3.4kB   esm/operations/containerServices.d.ts.map            
      [npmPack] npm notice 5.6kB   esm/operations/containerServices.js.map              
      [npmPack] npm notice 907B    esm/models/containerServicesMappers.d.ts.map         
      [npmPack] npm notice 920B    esm/models/containerServicesMappers.js.map           
      [npmPack] npm notice 28.1kB  esm/models/index.d.ts.map                            
      [npmPack] npm notice 250B    esm/operations/index.d.ts.map                        
      [npmPack] npm notice 126B    esm/models/index.js.map                              
      [npmPack] npm notice 265B    esm/operations/index.js.map                          
      [npmPack] npm notice 6.6kB   esm/operations/managedClusters.d.ts.map              
      [npmPack] npm notice 11.6kB  esm/operations/managedClusters.js.map                
      [npmPack] npm notice 939B    esm/models/managedClustersMappers.d.ts.map           
      [npmPack] npm notice 952B    esm/models/managedClustersMappers.js.map             
      [npmPack] npm notice 3.7kB   esm/models/mappers.d.ts.map                          
      [npmPack] npm notice 43.6kB  esm/models/mappers.js.map                            
      [npmPack] npm notice 3.3kB   esm/operations/openShiftManagedClusters.d.ts.map     
      [npmPack] npm notice 5.9kB   esm/operations/openShiftManagedClusters.js.map       
      [npmPack] npm notice 892B    esm/models/openShiftManagedClustersMappers.d.ts.map  
      [npmPack] npm notice 905B    esm/models/openShiftManagedClustersMappers.js.map    
      [npmPack] npm notice 663B    esm/operations/operations.d.ts.map                   
      [npmPack] npm notice 908B    esm/operations/operations.js.map                     
      [npmPack] npm notice 212B    esm/models/operationsMappers.d.ts.map                
      [npmPack] npm notice 225B    esm/models/operationsMappers.js.map                  
      [npmPack] npm notice 968B    esm/models/parameters.d.ts.map                       
      [npmPack] npm notice 3.3kB   esm/models/parameters.js.map                         
      [npmPack] npm notice 2.3kB   esm/operations/privateEndpointConnections.d.ts.map   
      [npmPack] npm notice 3.4kB   esm/operations/privateEndpointConnections.js.map     
      [npmPack] npm notice 886B    esm/models/privateEndpointConnectionsMappers.d.ts.map
      [npmPack] npm notice 899B    esm/models/privateEndpointConnectionsMappers.js.map  
      [npmPack] npm notice 3.3kB   README.md                                            
      [npmPack] npm notice 9.9kB   esm/operations/agentPools.d.ts                       
      [npmPack] npm notice 18.0kB  src/operations/agentPools.ts                         
      [npmPack] npm notice 1.9kB   esm/models/agentPoolsMappers.d.ts                    
      [npmPack] npm notice 2.3kB   src/models/agentPoolsMappers.ts                      
      [npmPack] npm notice 1.4kB   esm/containerServiceClient.d.ts                      
      [npmPack] npm notice 2.2kB   src/containerServiceClient.ts                        
      [npmPack] npm notice 898B    esm/containerServiceClientContext.d.ts               
      [npmPack] npm notice 2.4kB   src/containerServiceClientContext.ts                 
      [npmPack] npm notice 12.9kB  esm/operations/containerServices.d.ts                
      [npmPack] npm notice 21.3kB  src/operations/containerServices.ts                  
      [npmPack] npm notice 1.8kB   esm/models/containerServicesMappers.d.ts             
      [npmPack] npm notice 2.2kB   src/models/containerServicesMappers.ts               
      [npmPack] npm notice 98.0kB  esm/models/index.d.ts                                
      [npmPack] npm notice 257B    esm/operations/index.d.ts                            
      [npmPack] npm notice 94.1kB  src/models/index.ts                                  
      [npmPack] npm notice 541B    src/operations/index.ts                              
      [npmPack] npm notice 21.4kB  esm/operations/managedClusters.d.ts                  
      [npmPack] npm notice 38.6kB  src/operations/managedClusters.ts                    
      [npmPack] npm notice 1.9kB   esm/models/managedClustersMappers.d.ts               
      [npmPack] npm notice 2.3kB   src/models/managedClustersMappers.ts                 
      [npmPack] npm notice 5.8kB   esm/models/mappers.d.ts                              
      [npmPack] npm notice 65.5kB  src/models/mappers.ts                                
      [npmPack] npm notice 10.5kB  esm/operations/openShiftManagedClusters.d.ts         
      [npmPack] npm notice 19.1kB  src/operations/openShiftManagedClusters.ts           

    @zhenglaizhang
    Copy link
    Contributor

    /openapi pipeline

    @openapi-sdkautomation
    Copy link

    /openapi pipeline

    Unrecognized OpenAPI bot command (pipeline).
    Try sdkautomation instead.

    2 similar comments
    @openapi-assignment-bot
    Copy link

    /openapi pipeline

    Unrecognized OpenAPI bot command (pipeline).
    Try sdkautomation instead.

    @openapi-email-bot
    Copy link

    /openapi pipeline

    Unrecognized OpenAPI bot command (pipeline).
    Try sdkautomation instead.

    @zhenglaizhang
    Copy link
    Contributor

    /openapi pipeline

    @openapi-sdkautomation
    Copy link

    /openapi pipeline

    Unrecognized OpenAPI bot command (pipeline).
    Try sdkautomation instead.

    2 similar comments
    @openapi-email-bot
    Copy link

    /openapi pipeline

    Unrecognized OpenAPI bot command (pipeline).
    Try sdkautomation instead.

    @openapi-assignment-bot
    Copy link

    /openapi pipeline

    Unrecognized OpenAPI bot command (pipeline).
    Try sdkautomation instead.

    @gossion
    Copy link
    Member Author

    gossion commented Jun 5, 2020

    /openapi pipeline

    @openapi-assignment-bot
    Copy link

    /openapi pipeline

    Unrecognized OpenAPI bot command (pipeline).
    Try sdkautomation instead.

    2 similar comments
    @openapi-email-bot
    Copy link

    /openapi pipeline

    Unrecognized OpenAPI bot command (pipeline).
    Try sdkautomation instead.

    @openapi-sdkautomation
    Copy link

    /openapi pipeline

    Unrecognized OpenAPI bot command (pipeline).
    Try sdkautomation instead.

    @openapi-assignment-bot openapi-assignment-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 5, 2020
    @gossion gossion force-pushed the guwe/private-endpoint-connections branch from 9810c52 to dedbdde Compare June 5, 2020 08:33
    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @gossion gossion force-pushed the guwe/private-endpoint-connections branch from dedbdde to a3ccb99 Compare June 8, 2020 02:28
    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @fengzhou-msft
    Copy link
    Member

    /azp run automation - sdk

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @majastrz majastrz added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jun 9, 2020
    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    Copy link
    Member

    @majastrz majastrz left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Signed off from ARM side. Please consider taking the enum comment but it's not blocking.

    @majastrz majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 9, 2020
    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @majastrz
    Copy link
    Member

    Still signed off from ARM side :)

    @fengzhou-msft fengzhou-msft merged commit a174aca into Azure:dev-containerservice-Microsoft.ContainerService-2020-06-01 Jun 10, 2020
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    6 participants