Removed the publishingcredentials API and re-added the publishingUsers API #925

naveedaz · 2017-02-10T18:29:28Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
[] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- Validation errors from the Linter extension for VS Code have all been fixed for this spec. (Note: for large, previously checked in specs, there will likely be many errors shown. Please contact our team so we can set a timeframe for fixing these errors if your PR is not going to address them).
- The spec follows the patterns described in the Swagger good patterns document unless the service API makes this impossible.

…. Make SCM type read/write. Add Linux App Fx version.

…Node CLI SDK. Add config snapshots API. Add valid values for SCMType.

olydis · 2017-02-10T20:52:02Z

Please adjust all arm-web folders to adhere to our new convention regarding folder structure: Swagger files should go into a swagger folder, examples go into an examples folder. See https://github.com/Azure/azure-rest-api-specs/tree/master/arm-redis/2016-04-01 for reference. Our CI tools will enforce this structure soon.

naveedaz · 2017-02-10T20:58:09Z

Fixed the folder structure.

amarzavery · 2017-02-10T21:31:27Z

arm-web/2016-03-01/ResourceProvider.json

@@ -207,76 +271,6 @@
        }
      }
    },
-    "/subscriptions/{subscriptionId}/providers/Microsoft.Web/publishingCredentials": {


this would be a breaking change. You are removing the API from the same api-version. When the new SDKs will be published, you would leave the customers high and dry.

/cc @johanste @lmazuel

Intentional. This API is not per ARM spec and ARM does not let it through. So its not breaking anyone.

@salameer @ravbhatnagar - what is the ARM guideline for removing an API from an existing api-version ?

FYI: The resourceType 'publishingcredentials' is not in the ARM manifest for Microsoft.Web. So this is not an API that anyone can actually call into.
Here is the url.

Ah I see. I remember seeing an issue posted by a node sdk customer. Azure/azure-sdk-for-node#1909 (comment) . Ruslan recommended using this GET /providers/Microsoft.Web/publishingUsers/web?api-version=2015-08-01 instead.
Btw, is the above api present for the new api-version (Just confirming)?

Not yet. These APIs need to be redesigned properly.

amarzavery · 2017-02-10T21:32:46Z

arm-web/2016-03-01/ResourceProvider.json

+        ],
+        "parameters": [
+          {
+            "name": "requestMessage",


If the parameter is named "userDetails" then this would be better. It gives better developer experience.

AutorestCI · 2017-02-11T00:08:43Z

Azure/azure-sdk-for-ruby#685

AutorestCI · 2017-02-11T00:08:48Z

Azure/azure-sdk-for-python#990

AutorestCI · 2017-02-11T00:09:01Z

No modification for NodeJS

Naveed Aziz added 13 commits November 23, 2016 17:57

Fixes for code review comments

c8391a5

Make resourcegroup the first parameter if applicable.

c26c550

Address CR comments from #761

66457e2

Merge remote-tracking branch 'upstream/master'

8f3244d

Merge remote-tracking branch 'upstream/master'

794b910

Address more comments on PR

8012acb

Merge remote-tracking branch 'upstream/master'

7b662e5

Fix HTTP status codes for start/stop/restart app and deployment slots…

68306ef

…. Make SCM type read/write. Add Linux App Fx version.

Merge remote-tracking branch 'upstream/master'

523aa92

Rename operation parameters with name options to avoid conflict with …

158c648

…Node CLI SDK. Add config snapshots API. Add valid values for SCMType.

Fix CR recommendations. Remove obsolete siteAuthSettings properties

7b95e9d

Merge remote-tracking branch 'upstream/master'

0051279

Surface the correct publishing user API

aca1353

azurecla added the cla-not-required label Feb 10, 2017

azuresdkci assigned olydis Feb 10, 2017

Naveed Aziz added 2 commits February 10, 2017 11:47

Expose hosttype for hostnames

7d48cf7

Merge remote-tracking branch 'upstream/master'

bde0c02

Fix folder structure according to convention

c8416dd

Fix paths in composite swagger json

7486885

amarzavery closed this Feb 10, 2017

amarzavery reopened this Feb 10, 2017

azurecla added the cla-not-required label Feb 10, 2017

amarzavery reviewed Feb 10, 2017

View reviewed changes

CR comment fix: Changed parameter name to userDetails.

3583b3e

yugangw-msft approved these changes Feb 11, 2017

View reviewed changes

yugangw-msft merged commit 2843040 into Azure:master Feb 11, 2017

AutorestCI mentioned this pull request Feb 11, 2017

Automatic PR from RestAPI-PR925 Azure/azure-sdk-for-ruby#685

Merged

AutorestCI mentioned this pull request Feb 11, 2017

[WebApp] Removed the publishingcredentials API and re-added the publishingUsers API Azure/azure-sdk-for-python#990

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removed the publishingcredentials API and re-added the publishingUsers API #925

Removed the publishingcredentials API and re-added the publishingUsers API #925

naveedaz commented Feb 10, 2017 •

edited by azuresdkci

Loading

olydis commented Feb 10, 2017 •

edited

Loading

naveedaz commented Feb 10, 2017

amarzavery Feb 10, 2017

naveedaz Feb 10, 2017

amarzavery Feb 10, 2017

naveedaz Feb 10, 2017 •

edited by amarzavery

Loading

amarzavery Feb 10, 2017

naveedaz Feb 10, 2017

amarzavery Feb 10, 2017

naveedaz Feb 10, 2017

AutorestCI commented Feb 11, 2017

AutorestCI commented Feb 11, 2017

AutorestCI commented Feb 11, 2017

Removed the publishingcredentials API and re-added the publishingUsers API #925

Removed the publishingcredentials API and re-added the publishingUsers API #925

Conversation

naveedaz commented Feb 10, 2017 • edited by azuresdkci Loading

PR information

Quality of Swagger

olydis commented Feb 10, 2017 • edited Loading

naveedaz commented Feb 10, 2017

amarzavery Feb 10, 2017

Choose a reason for hiding this comment

naveedaz Feb 10, 2017

Choose a reason for hiding this comment

amarzavery Feb 10, 2017

Choose a reason for hiding this comment

naveedaz Feb 10, 2017 • edited by amarzavery Loading

Choose a reason for hiding this comment

amarzavery Feb 10, 2017

Choose a reason for hiding this comment

naveedaz Feb 10, 2017

Choose a reason for hiding this comment

amarzavery Feb 10, 2017

Choose a reason for hiding this comment

naveedaz Feb 10, 2017

Choose a reason for hiding this comment

AutorestCI commented Feb 11, 2017

AutorestCI commented Feb 11, 2017

AutorestCI commented Feb 11, 2017

naveedaz commented Feb 10, 2017 •

edited by azuresdkci

Loading

olydis commented Feb 10, 2017 •

edited

Loading

naveedaz Feb 10, 2017 •

edited by amarzavery

Loading