Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the descriptions for various parameters, paths and definitions #8831

Merged
merged 7 commits into from
Mar 31, 2020
Merged

Updating the descriptions for various parameters, paths and definitions #8831

merged 7 commits into from
Mar 31, 2020

Conversation

asarkar84
Copy link
Contributor

@asarkar84 asarkar84 commented Mar 25, 2020

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 25, 2020

azure-cli-extensions - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 25, 2020

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from b5f29b3 with merge commit d8c4e5f. SDK Automation 13.0.17.20200326.3
  • ⚠️preview/billing/mgmt/2017-02-27-preview [Logs
      No file is changed.
    • ⚠️preview/billing/mgmt/2017-04-24-preview [Logs
        No file is changed.
      • ⚠️preview/billing/mgmt/2018-03-01-preview [Logs
          No file is changed.
        • ⚠️preview/billing/mgmt/2018-11-01-preview [Logs
            No file is changed.

          @openapi-sdkautomation
          Copy link

          openapi-sdkautomation bot commented Mar 25, 2020

          azure-sdk-for-java - Release

          ⚠️ warning [Logs] [Expand Details]
          • ⚠️ Generate from b5f29b3 with merge commit d8c4e5f. SDK Automation 13.0.17.20200326.3
          • ️✔️sdk/billing/mgmt-v2017_02_27_preview [Logs]  [Release SDK Changes]
          • ️✔️sdk/billing/mgmt-v2017_04_24_preview [Logs]  [Release SDK Changes]
          • ️✔️sdk/billing/mgmt-v2018_03_01_preview [Logs]  [Release SDK Changes]
          • ⚠️sdk/billing/mgmt-v2018_11_01_preview [Logs]  [Release SDK Changes]
              [mvn] [ERROR] COMPILATION ERROR : 
              [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2018_11_01_preview/src/main/java/com/microsoft/azure/management/billing/v2018_11_01_preview/implementation/PriceSheetsInner.java:[130,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
              [mvn]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
              [mvn]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
              [mvn]   reason: cannot infer type-variable(s) T,THeader
              [mvn]     (actual and formal argument lists differ in length)
              [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-billing: Compilation failure
              [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2018_11_01_preview/src/main/java/com/microsoft/azure/management/billing/v2018_11_01_preview/implementation/PriceSheetsInner.java:[130,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
              [mvn] [ERROR]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
              [mvn] [ERROR]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
              [mvn] [ERROR]   reason: cannot infer type-variable(s) T,THeader
              [mvn] [ERROR]     (actual and formal argument lists differ in length)
              [mvn] [ERROR] -> [Help 1]
              [mvn] [ERROR] 
              [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
              [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
              [mvn] [ERROR] 
              [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
              [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
            • ⚠️sdk/billing/mgmt-v2019_10_01_preview [Logs]  [Release SDK Changes]
                [mvn] [ERROR] COMPILATION ERROR : 
                [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2019_10_01_preview/src/main/java/com/microsoft/azure/management/billing/v2019_10_01_preview/implementation/PriceSheetsInner.java:[146,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
                [mvn]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
                [mvn]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
                [mvn]   reason: cannot infer type-variable(s) T,THeader
                [mvn]     (actual and formal argument lists differ in length)
                [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2019_10_01_preview/src/main/java/com/microsoft/azure/management/billing/v2019_10_01_preview/implementation/PriceSheetsInner.java:[303,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
                [mvn]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
                [mvn]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
                [mvn]   reason: cannot infer type-variable(s) T,THeader
                [mvn]     (actual and formal argument lists differ in length)
                [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-billing: Compilation failure: Compilation failure: 
                [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2019_10_01_preview/src/main/java/com/microsoft/azure/management/billing/v2019_10_01_preview/implementation/PriceSheetsInner.java:[146,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
                [mvn] [ERROR]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
                [mvn] [ERROR]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
                [mvn] [ERROR]   reason: cannot infer type-variable(s) T,THeader
                [mvn] [ERROR]     (actual and formal argument lists differ in length)
                [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2019_10_01_preview/src/main/java/com/microsoft/azure/management/billing/v2019_10_01_preview/implementation/PriceSheetsInner.java:[303,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
                [mvn] [ERROR]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
                [mvn] [ERROR]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
                [mvn] [ERROR]   reason: cannot infer type-variable(s) T,THeader
                [mvn] [ERROR]     (actual and formal argument lists differ in length)
                [mvn] [ERROR] -> [Help 1]
                [mvn] [ERROR] 
                [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
                [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
                [mvn] [ERROR] 
                [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
                [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

              @openapi-sdkautomation
              Copy link

              openapi-sdkautomation bot commented Mar 25, 2020

              azure-sdk-for-js - Release

              ️✔️ succeeded [Logs] [Expand Details]

              @openapi-sdkautomation
              Copy link

              openapi-sdkautomation bot commented Mar 25, 2020

              azure-sdk-for-net - Release

              ️✔️ succeeded [Logs] [Expand Details]

              @openapi-sdkautomation
              Copy link

              openapi-sdkautomation bot commented Mar 25, 2020

              azure-sdk-for-python - Release

              ️✔️ succeeded [Logs] [Expand Details]
              • ️✔️ Generate from b5f29b3 with merge commit d8c4e5f. SDK Automation 13.0.17.20200326.3
              • ️✔️azure-mgmt-billing [Logs]  [Release SDK Changes]
                [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
                [build_package]   warnings.warn(msg)
                [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
                [build_package]   warnings.warn(msg)
                [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
                [breaking_change_setup] Cannot uninstall requirement azure-nspkg, not installed
                [breaking_change_setup] Command '['/usr/local/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
                [ChangeLog] Traceback (most recent call last):
                [ChangeLog]   File "/usr/lib/python3.6/runpy.py", line 193, in _run_module_as_main
                [ChangeLog]     "__main__", mod_spec)
                [ChangeLog]   File "/usr/lib/python3.6/runpy.py", line 85, in _run_code
                [ChangeLog]     exec(code, run_globals)
                [ChangeLog]   File "/z/work/azure-sdk-for-python/tools/azure-sdk-tools/packaging_tools/change_log.py", line 200, in 
                [ChangeLog]     change_log = build_change_log(old_report, new_report)
                [ChangeLog]   File "/z/work/azure-sdk-for-python/tools/azure-sdk-tools/packaging_tools/change_log.py", line 147, in build_change_log
                [ChangeLog]     change_log.operation(diff_line)
                [ChangeLog]   File "/z/work/azure-sdk-for-python/tools/azure-sdk-tools/packaging_tools/change_log.py", line 38, in operation
                [ChangeLog]     _, operation_name, *remaining_path = path
                [ChangeLog] ValueError: not enough values to unpack (expected at least 2, got 1)
                [ChangeLog] Size of delta 99.369% size of original (original: 86402 chars, delta: 85857 chars)

              @azuresdkci
              Copy link
              Contributor

              Can one of the admins verify this patch?

              @njuCZ
              Copy link
              Contributor

              njuCZ commented Mar 25, 2020

              @asarkar84 please fix the CI error.

              • Unknown word : agreeement, eligiblity, desscription, maketplace
              • Description must not match the name of the node it is supposed to describe. Node name:'city' Description:'City.'
                at specification/billing/resource-manager/Microsoft.Billing/preview/2019-10-01-preview/billing.json:5938
                R3011 - DescriptionMustNotBeNodeName
                Description must not match the name of the node it is supposed to describe. Node name:'region'
                Description:'Region.'
                at specification/billing/resource-manager/Microsoft.Billing/preview/2019-10-01-
                preview/billing.json:5942

              @azure-pipelines
              Copy link

              Azure Pipelines successfully started running 1 pipeline(s).

              @azure-pipelines
              Copy link

              Azure Pipelines successfully started running 1 pipeline(s).

              @azure-pipelines
              Copy link

              Azure Pipelines successfully started running 1 pipeline(s).

              @asarkar84
              Copy link
              Contributor Author

              @asarkar84 please fix the CI error.

              • Unknown word : agreeement, eligiblity, desscription, maketplace
              • Description must not match the name of the node it is supposed to describe. Node name:'city' Description:'City.'
                at specification/billing/resource-manager/Microsoft.Billing/preview/2019-10-01-preview/billing.json:5938
                R3011 - DescriptionMustNotBeNodeName
                Description must not match the name of the node it is supposed to describe. Node name:'region'
                Description:'Region.'
                at specification/billing/resource-manager/Microsoft.Billing/preview/2019-10-01-
                preview/billing.json:5942

              @njuCZ I have fixed the errors. Please take a look now.

              @azure-pipelines
              Copy link

              Azure Pipelines successfully started running 1 pipeline(s).

              @azure-pipelines
              Copy link

              Azure Pipelines successfully started running 1 pipeline(s).

              @asarkar84
              Copy link
              Contributor Author

              @njuCZ Please review this PR and merge if it this looks good to you.

              @njuCZ njuCZ merged commit d8c4e5f into Azure:master Mar 31, 2020
              00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
              …ns (Azure#8831)
              
              * Updated descriptions
              
              * Updated the field description
              
              Updated the field description
              
              * Updated descriptons
              
              * Fixed errors
              
              * Fixed the build errors
              
              * Updated description for instructions apis
              
              * Updated description for instructions api path
              Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
              Labels
              None yet
              Projects
              None yet
              Development

              Successfully merging this pull request may close these issues.

              3 participants