Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EventHub.json #7917

Merged
merged 1 commit into from
Jan 8, 2020
Merged

Update EventHub.json #7917

merged 1 commit into from
Jan 8, 2020

Conversation

basilhariri
Copy link
Contributor

This is a single string update (adding a note in the description of an API), so I am not following the full API update workflow because it doesn't require a new version. Please let me know if I need to do this differently

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • [] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • [] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@basilhariri basilhariri requested a review from v-Ajnava as a code owner December 6, 2019 22:13
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 6, 2019

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from e6fe898 with merge commit e610609. SDK Automation 13.0.17.20191226.1
    Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-java/pull/194: HttpError: Reference does not exist, {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 08 Jan 2020 03:25:19 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.machine-man-preview; format=json","x-github-request-id":"0645:3627:26D34:4FFA3:5E154B9D","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4910","x-ratelimit-reset":"1578457306","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-java/git/refs/heads/sdkAutomation/sdk_eventhubs_mgmt-v2017_04_01@7917","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.35.0 Node.js/12.14.0 (Linux 5.0; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://developer.github.com/v3/git/refs/#delete-a-reference"}
    Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-java/pull/195: HttpError: Reference does not exist, {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 08 Jan 2020 03:25:19 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.machine-man-preview; format=json","x-github-request-id":"0643:7CCB:378CD:9E217:5E154B9D","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4909","x-ratelimit-reset":"1578457306","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-java/git/refs/heads/sdkAutomation/sdk_eventhubs_mgmt-v2018_01_01_preview@7917","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.35.0 Node.js/12.14.0 (Linux 5.0; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://developer.github.com/v3/git/refs/#delete-a-reference"}
    Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-java/pull/469: HttpError: Reference does not exist, {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 08 Jan 2020 03:25:19 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.machine-man-preview; format=json","x-github-request-id":"0640:3BCF:64141:F71CD:5E154B9D","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4908","x-ratelimit-reset":"1578457306","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-java/git/refs/heads/sdkAutomation/sdk_eventhubs_mgmt-v2015_08_01@7917","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.35.0 Node.js/12.14.0 (Linux 5.0; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://developer.github.com/v3/git/refs/#delete-a-reference"}
  • ️✔️sdk/eventhubs/mgmt-v2015_08_01 [Logs]  [Release SDK Changes]
  • ️✔️sdk/eventhubs/mgmt-v2017_04_01 [Logs]  [Release SDK Changes]
  • ️✔️sdk/eventhubs/mgmt-v2018_01_01_preview [Logs]  [Release SDK Changes]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 6, 2019

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from e6fe898 with merge commit e610609. SDK Automation 13.0.17.20191226.1
    Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-python/pull/130: HttpError: Reference does not exist, {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 08 Jan 2020 03:25:12 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.machine-man-preview; format=json","x-github-request-id":"0503:0A06:16377F:2B3776:5E154B97","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4936","x-ratelimit-reset":"1578457306","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-python/git/refs/heads/sdkAutomation/azure-mgmt-eventhub@7917","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.35.0 Node.js/12.14.0 (Linux 5.0; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://developer.github.com/v3/git/refs/#delete-a-reference"}
  • ️✔️azure-mgmt-eventhub [Logs]  [Release SDK Changes]
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 6, 2019

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from e6fe898 with merge commit e610609. SDK Automation 13.0.17.20191226.1
    Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-js/pull/81: HttpError: Reference does not exist, {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 08 Jan 2020 03:25:14 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.machine-man-preview; format=json","x-github-request-id":"0504:6DDD:64295:E1439:5E154B9A","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4927","x-ratelimit-reset":"1578457306","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-js/git/refs/heads/sdkAutomation/@azure_arm-eventhub@7917","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.35.0 Node.js/12.14.0 (Linux 5.0; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://developer.github.com/v3/git/refs/#delete-a-reference"}
  • ️✔️@azure/arm-eventhub [Logs]  [Release SDK Changes]
    [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
    [npmPack] loaded rollup.config.js with warnings
    [npmPack] (!) Unused external imports
    [npmPack] default imported from external module 'rollup' but never used
    [npmPack] 
    [npmPack] ./esm/eventHubManagementClient.js → ./dist/arm-eventhub.js...
    [npmPack] created ./dist/arm-eventhub.js in 419ms

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 6, 2019

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 6, 2019

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

@AutorestCI
Copy link

AutorestCI commented Dec 6, 2019

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#9043

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@xseeseesee
Copy link
Contributor

@basilhariri Can you please fix the CI errors? Thanks.

@basilhariri
Copy link
Contributor Author

@xccc-msft my change is just an addition to a description string. The failing CIs are caused by file format errors that are unrelated to this change. It seems to be an issue with the CI environment. Could you fix the CI environment or bypass the CIs since this PR isn't causing these issues?

Here is a sample of the errors that cause the Avocado run to fail:

error:
code: NOT_AUTOREST_MARKDOWN
message: The readme.md is not an AutoRest markdown file.
readMeUrl: >-
/home/vsts/work/1/s/specification/frontdoor/resource-manager/Microsoft.Network/stable/2019-04-01/README.md
level: Error
helpUrl: >-
http://azure.github.io/autorest/user/literate-file-formats/configuration.html#the-file-format

@xseeseesee
Copy link
Contributor

@NullMDR Can you help on this?

@PhoenixHe-NV
Copy link
Contributor

It's another known issue... It's OK to merge. I'll ask Arthur to do it later.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@basilhariri
Copy link
Contributor Author

@xccc-msft could you merge the PR when you get the chance? I am not authorized to merge it :(

@xseeseesee
Copy link
Contributor

@basilhariri Even I don't have access to merge by this situation as the merge button keeps disabled when pipelines failed.

@PhoenixHe-NV
Copy link
Contributor

/azp run automation - sdk

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@xseeseesee
Copy link
Contributor

@v-Ajnava Can you please review?

@basilhariri
Copy link
Contributor Author

@v-Ajnava if you are not available or the right person to merge, can you please assign to someone else?

@v-Ajnava
Copy link
Member

v-Ajnava commented Jan 7, 2020

@basilhariri, I don't have the rights to merge the PR, @xccc-msft should be able to merge the PR. I have approved the changes.

@xseeseesee xseeseesee merged commit e610609 into master Jan 8, 2020
@JackTn JackTn deleted the patch-1 branch August 9, 2021 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants