-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jit api add justification #7298
Merged
tjprescott
merged 5 commits into
Azure:master
from
Nomigori96MS:jit-api-add-justification
Sep 26, 2019
Merged
Jit api add justification #7298
tjprescott
merged 5 commits into
Azure:master
from
Nomigori96MS:jit-api-add-justification
Sep 26, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Testing, Please Ignore[Logs] (Generated from 1622131, Iteration 1).NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
|
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
Can one of the admins verify this patch? |
tjprescott
added
the
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
label
Sep 24, 2019
KrisBash
approved these changes
Sep 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
KrisBash
added
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
and removed
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
labels
Sep 26, 2019
tjprescott
approved these changes
Sep 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.