Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Review request for InkRecognizer to add version preview/v1.0 - Changing format of points from string to object as requested by Azure board and fleshing out properties. #6776

Merged
merged 14 commits into from
Aug 5, 2019
Merged

[Hub Generated] Review request for InkRecognizer to add version preview/v1.0 - Changing format of points from string to object as requested by Azure board and fleshing out properties. #6776

merged 14 commits into from
Aug 5, 2019

Conversation

olduroja
Copy link
Contributor

@olduroja olduroja commented Jul 29, 2019 •
edited
Loading

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 29, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from ae13f3b, Iteration 10)

Warning Python: Azure/azure-sdk-for-python [Logs] [Diff]
  • No packages generated.
In-Progress Java: Azure/azure-sdk-for-java [Logs]
  • Package generation in progress.
In-Progress Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
  • In-Progress preview/cognitiveservices/v1.0 [Logs]
In-Progress JavaScript: Azure/azure-sdk-for-js [Logs]
  • Package generation in progress.
Warning Ruby: Azure/azure-sdk-for-ruby [Logs] [Diff]
  • No packages generated.

@azuresdkci azuresdkci requested a review from erich-wang July 29, 2019 20:31
@AutorestCI AutorestCI mentioned this pull request Jul 29, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jul 29, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#6657

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Jul 29, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jul 29, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5429

@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Jul 29, 2019
Merged
@erich-wang erich-wang added the APIStewardshipBoard-ReviewRequested This should be reviewed by the Azure API Stewardship team in partnership with the service team. label Jul 30, 2019
@olduroja olduroja changed the title [Hub Generated] Review request for InkRecognizer to add version preview/v1.0 [Hub Generated] Review request for InkRecognizer to add version preview/v1.0 - Changing format of points from string to object as requested by Azure board and fleshing out properties. Jul 30, 2019
olduroja and others added 3 commits July 30, 2019 13:02
@olduroja @nschonni
Update specification/cognitiveservices/data-plane/InkRecognizer/previ…
6174df0 
…ew/v1.0/InkRecognizer.json

Co-Authored-By: Nick Schonning <[email protected]>
@olduroja @nschonni
Update specification/cognitiveservices/data-plane/InkRecognizer/previ…
fab06a8 
…ew/v1.0/InkRecognizer.json

Co-Authored-By: Nick Schonning <[email protected]>
@olduroja @nschonni
Update specification/cognitiveservices/data-plane/InkRecognizer/previ…
ae13f3b 
…ew/v1.0/InkRecognizer.json

Co-Authored-By: Nick Schonning <[email protected]>
@johanste johanste removed the APIStewardshipBoard-ReviewRequested This should be reviewed by the Azure API Stewardship team in partnership with the service team. label Jul 31, 2019
@johanste
Copy link
Member

Changes were requested by the Azure API Review Board. @olduroja, was the 1.0 version of the APIs/SDKs deployed publicly?

@olduroja
Copy link
Contributor Author

Changes were requested by the Azure API Review Board. @olduroja, was the 1.0 version of the APIs/SDKs deployed publicly?

We're still in preview and the preview has been deployed publicly.

@johanste
Copy link
Member

can existing users be broken by the changes? If so, how will you deal with existing users being broken?

Generally, changes to the API are accompanied with a new API version.

@olduroja
Copy link
Contributor Author

can existing users be broken by the changes? If so, how will you deal with existing users being broken?
Generally, changes to the API are accompanied with a new API version.
This won't break anyone. We will continue to support the old format while we're in preview.

@erich-wang
Copy link
Member

can existing users be broken by the changes? If so, how will you deal with existing users being broken?
Generally, changes to the API are accompanied with a new API version.

This won't break anyone. We will continue to support the old format while we're in preview.

@johanste, do you have any other concern? If no, I'll approve and merge this PR.

@johanste
Copy link
Member

johanste commented Aug 2, 2019

I'm good.

@erich-wang erich-wang merged commit 3969f77 into Azure:master Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanste johanste johanste left review comments

@nschonni nschonni nschonni left review comments

@erich-wang erich-wang erich-wang approved these changes

@DavidLiCIG DavidLiCIG Awaiting requested review from DavidLiCIG

@yangyuan yangyuan Awaiting requested review from yangyuan yangyuan is a code owner

Assignees

@erich-wang erich-wang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@olduroja @AutorestCI @azuresdkci @johanste @erich-wang @nschonni