Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding more documentation to ASC Pricing API #6691

Merged
merged 3 commits into from
Aug 5, 2019
Merged

Conversation

nirwinter
Copy link
Contributor

@nirwinter nirwinter commented Jul 22, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 22, 2019

@AutorestCI
Copy link

AutorestCI commented Jul 22, 2019

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#6656

@AutorestCI
Copy link

AutorestCI commented Jul 22, 2019

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Jul 22, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5434

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@nirwinter
Copy link
Contributor Author

@chlahav appreciate your approval

@yaohaizh
Copy link
Contributor

@nirwinter please help resolve the conflicting files, thanks.

@yaohaizh yaohaizh requested a review from chlahav July 23, 2019 04:48
@yaohaizh
Copy link
Contributor

@nirwinter, @chlahav, any update on this PR? Thanks.

@mmyyrroonn
Copy link
Contributor

@nirwinter, @chlahav Any update on this PR?

@nirwinter
Copy link
Contributor Author

@myronfanqiu @yaohaizh @chlahav Iv'e merged with the latest code. Appreciate if you can approve the latest changes and complete the PR.

@yaohaizh yaohaizh merged commit 3a5c49a into Azure:master Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants