Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new APIs (two List APIs) and update examples #6640

Merged
merged 2 commits into from
Sep 24, 2019
Merged

Add new APIs (two List APIs) and update examples #6640

merged 2 commits into from
Sep 24, 2019

Conversation

bashahee
Copy link
Contributor

@bashahee bashahee commented Jul 16, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@bashahee bashahee requested a review from jaredmoo as a code owner July 16, 2019 10:28
@azuresdkci azuresdkci requested a review from amarzavery July 16, 2019 10:29
@AutorestCI
Copy link

AutorestCI commented Jul 16, 2019 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#7330

This was referenced Jul 16, 2019
Closed
Closed
@AutorestCI
Copy link

AutorestCI commented Jul 16, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5861

@AutorestCI AutorestCI mentioned this pull request Jul 16, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Jul 16, 2019 •
edited
Loading

Automation for azure-sdk-for-java

A PR has been created for you:
Azure/azure-sdk-for-java#4442

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@bashahee
Copy link
Contributor Author

@jaredmoo can you please review?

jaredmoo
jaredmoo approved these changes Jul 22, 2019
View reviewed changes
Copy link
Contributor

@jaredmoo jaredmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved assuming that this is available in at least 1 production region.

@bashahee
Copy link
Contributor Author

@amarzavery Can you please approve and merge?

@bashahee
Copy link
Contributor Author

@jaredmoo can this PR be merged?

@amarzavery amarzavery added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 29, 2019
@bashahee
Copy link
Contributor Author

bashahee commented Aug 1, 2019

@amarzavery can this PR be merged?

@PhoenixHe-NV
Copy link
Contributor

@OpenAPIBot sdkautomation rebuild

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 5, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from b5c48e4, Iteration 2)

In-Progress .NET: test-repo-billy/azure-sdk-for-net [Logs]
  • Package generation in progress.
In-Progress Python: test-repo-billy/azure-sdk-for-python [Logs]
  • Package generation in progress.
In-Progress Java: test-repo-billy/azure-sdk-for-java [Logs]
  • Package generation in progress.
In-Progress Go: test-repo-billy/azure-sdk-for-go [Logs]
  • Package generation in progress.
In-Progress JavaScript: test-repo-billy/azure-sdk-for-js [Logs]
  • Package generation in progress.
In-Progress Ruby: test-repo-billy/azure-sdk-for-ruby [Logs]
  • Package generation in progress.

@bashahee
Copy link
Contributor Author

@amarzavery ping

@zikalino zikalino self-assigned this Aug 21, 2019
@bashahee
Copy link
Contributor Author

@zikalino Can this PR be merged?

@yungezz yungezz assigned yungezz and unassigned amarzavery Aug 28, 2019
KrisBash
KrisBash suggested changes Sep 4, 2019
View reviewed changes
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments

specification/sql/resource-manager/Microsoft.Sql/preview/2015-05-01-preview/blobAuditing.json Show resolved Hide resolved
...-manager/Microsoft.Sql/preview/2015-05-01-preview/examples/DatabaseAuditingSettingsList.json Outdated Show resolved Hide resolved
specification/sql/resource-manager/Microsoft.Sql/preview/2015-05-01-preview/blobAuditing.json Show resolved Hide resolved
@KrisBash KrisBash added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Sep 4, 2019
@AutorestCI AutorestCI mentioned this pull request Sep 9, 2019
Closed
@AutorestCI AutorestCI mentioned this pull request Sep 9, 2019
Merged
@bashahee
Copy link
Contributor Author

@KrisBash Can you please take a look?

@yungezz
Copy link
Member

yungezz commented Sep 16, 2019

Hi @KrisBash could you pls look at the PR again after comments address? thanks.

@bashahee
Copy link
Contributor Author

@KrisBash @yungezz Can please merge this PR?
It was opened long time ago, and comments were addressed. Moreover, these APIs are in production, and they need to be properly documented.

@ravbhatnagar
Copy link
Contributor

Signing off from ARM side.

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 24, 2019
@yungezz
Copy link
Member

yungezz commented Sep 24, 2019

Hi @KrisBash could you pls change changes requested review? Otherwise I cannot merge this one. thanks.

@yungezz yungezz merged commit 48df97b into Azure:master Sep 24, 2019
@AutorestCI AutorestCI mentioned this pull request Sep 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrisBash KrisBash KrisBash requested changes

@yungezz yungezz yungezz approved these changes

@amarzavery amarzavery amarzavery approved these changes

@jaredmoo jaredmoo jaredmoo approved these changes

Assignees

@zikalino zikalino

@yungezz yungezz

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.