Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add resource group based LTR API #6571

Merged
merged 6 commits into from
Jul 15, 2019
Merged

Add resource group based LTR API #6571

merged 6 commits into from
Jul 15, 2019

Conversation

pixia
Copy link
Contributor

@pixia pixia commented Jul 9, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@pixia pixia requested a review from jaredmoo as a code owner July 9, 2019 18:08
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 9, 2019 •
edited
Loading

SDK Automation [Logs] (Generated from b882b52, Iteration 3)

Succeeded Python: Azure/azure-sdk-for-python [Logs] [Diff]
Failed Java: Azure/azure-sdk-for-java [Logs] [Diff]
Succeeded Go: Azure/azure-sdk-for-go [Logs] [Diff]
Succeeded JavaScript: Azure/azure-sdk-for-js [Logs] [Diff]
Failed Ruby: Azure/azure-sdk-for-ruby [Logs] [Diff]

@azuresdkci azuresdkci requested a review from sarangan12 July 9, 2019 18:09
@AutorestCI AutorestCI mentioned this pull request Jul 9, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jul 9, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5771

@AutorestCI
Copy link

AutorestCI commented Jul 9, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@AutorestCI AutorestCI mentioned this pull request Jul 9, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jul 9, 2019 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3004

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@sarangan12
Copy link
Member

Since new APIs are added adding ARM Review label

@sarangan12 sarangan12 added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required ARM-overdue ARM review has not occurred within the expected timeframe labels Jul 9, 2019
@sarangan12 sarangan12 merged commit c1cc802 into Azure:master Jul 15, 2019
celikcigdem pushed a commit to celikcigdem/azure-rest-api-specs that referenced this pull request Jul 17, 2019
@pixia @celikcigdem
Add resource group based LTR API (Azure#6571)
26134e3 
* Fix set LTR policy example

* Add resource group based LTR APIs

* fix examples
leni-msft pushed a commit to leni-msft/azure-rest-api-specs that referenced this pull request May 13, 2022
@sugatt
Fix field names in test API version (Azure#6571)
05aa541
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredmoo jaredmoo jaredmoo approved these changes

@sarangan12 sarangan12 sarangan12 approved these changes

Assignees

@sarangan12 sarangan12

Labels
ARM-overdue ARM review has not occurred within the expected timeframe WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pixia @AutorestCI @azuresdkci @sarangan12 @jaredmoo