Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding new property to Peering: connection identifier. #6566

Merged
5 commits merged into from
Jul 11, 2019
Merged

Adding new property to Peering: connection identifier. #6566

5 commits merged into from
Jul 11, 2019

Conversation

rileymckenna
Copy link
Contributor

@rileymckenna rileymckenna commented Jul 8, 2019 •
edited
Loading

This is a unique hash for each connection so we can determine when a connection is deleted or if it is updated.
This is a property update and an API update.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@rileymckenna
Adding ew Api which adds a connection identifier.
189c267 
This is a unique hash for each connection so we can determine when a connection is deleted or if it is updated.
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 8, 2019 •
edited
Loading

SDK Automation [Logs] (Generated from ec8aae7, Iteration 12)

Warning Python: Azure/azure-sdk-for-python [Logs] [Diff]
  • No packages generated.
Warning Java: Azure/azure-sdk-for-java [Logs] [Diff]
  • No packages generated.
Succeeded Go: Azure/azure-sdk-for-go [Logs] [Diff]
Warning .NET: Azure/azure-sdk-for-net [Logs] [Diff]
  • No packages generated.
Failed JavaScript: Azure/azure-sdk-for-js [Logs] [Diff]
  • No packages generated.
Failed Ruby: Azure/azure-sdk-for-ruby [Logs] [Diff]

@AutorestCI
Copy link

AutorestCI commented Jul 8, 2019 •
edited
Loading

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@azuresdkci azuresdkci requested a review from mmyyrroonn July 8, 2019 19:26
@AutorestCI
Copy link

AutorestCI commented Jul 8, 2019 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Jul 8, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@rileymckenna rileymckenna changed the title Adding new Api which adds a connection identifier. Adding new property to Peering: connection identifier. Jul 8, 2019
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@mmyyrroonn mmyyrroonn added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 9, 2019
@rileymckenna
Copy link
Contributor Author

@myronfanqiu can i get an update on this PR?

ryansbenson
ryansbenson approved these changes Jul 10, 2019
View reviewed changes
Copy link
Contributor

@ryansbenson ryansbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only 2 small changes here.

  1. The connectionIdentifier property was added to DirectConnection and ExchangeConnection.
  2. OpenRevieved was added to sessionStateV4 and ...V6 enums.

Approved from ARM's side

@ryansbenson ryansbenson added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 10, 2019
@mmyyrroonn
Copy link
Contributor

@openapi sdkautomation rebuild

@mmyyrroonn
Copy link
Contributor

mmyyrroonn commented Jul 11, 2019 •
edited
Loading

LGTM. Just two small things.

  • Commonly the securityDefinitions will appear at the begin of the file.
  • I'm not familiar with the service behavior. Three or four parameters use the query in the in filed and other field use path. I just want to confirm it is by design, right?

I try to re-trigger the SDK generation process, but seems like it doesn't work. Could you take a look?@daschult

@ghost
Copy link

ghost commented Jul 11, 2019

@openapi sdkautomation rebuild

@ghost
Copy link

ghost commented Jul 11, 2019

@openapi sdkautomation rebuild

@ghost
Copy link

ghost commented Jul 11, 2019

@rileymckenna There have been some pretty significant folder changes in the SDK repositories lately, and that's why there didn't seem to be any changes generated by our tooling. I've fixed the TypeScript output folder path, but you may want to check with the other SDK owners to get their folder paths updated as well.

@ghost ghost merged commit a65ac7b into Azure:master Jul 11, 2019
@rileymckenna rileymckenna mentioned this pull request Jul 11, 2019
Merged
celikcigdem pushed a commit to celikcigdem/azure-rest-api-specs that referenced this pull request Jul 17, 2019
@rileymckenna @celikcigdem
Adding new property to Peering: connection identifier. (Azure#6566)
3cf29ff 
* Adding ew Api which adds a connection identifier.
This is a unique hash for each connection so we can determine when a connection is deleted or if it is updated.

* added 06-01 to readme

* added location to list Legacy example

* Updated Models

* Update readme.typescript.md
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmyyrroonn mmyyrroonn mmyyrroonn approved these changes

@ryansbenson ryansbenson ryansbenson approved these changes

Assignees

@mmyyrroonn mmyyrroonn

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rileymckenna @AutorestCI @azuresdkci @mmyyrroonn @ryansbenson