Add managed instances swagger to 2018-06-01-preview

[johnpaulkee]

Add managed instances swagger to 2018-06-01-preview.
Main changes include moving ManagedInstances_ListByInstancePool over from 2015-05-01-preview over to 2018-06-01-preview, updating sql README.md to reference 2018-06-01-preview/managedInstances swagger.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

• I have reviewed the documentation for the workflow.
• Validation tools were run on swagger spec(s) and have all been fixed in this PR.
• The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

• Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
• adding/removing APIs.
• adding/removing properties.
• adding/removing API-version.
• adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

• If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
  Please follow the link to find more details on API review process.

[openapi-sdkautomation]

SDK Automation [Logs] (Generated from 1b3affb)

Python: Azure/azure-sdk-for-python

• Package generation pending.

Java: Azure/azure-sdk-for-java

• Package generation pending.

Go: Azure/azure-sdk-for-go

• Package generation pending.

JavaScript: Azure/azure-sdk-for-js

• Package generation pending.

Ruby: Azure/azure-sdk-for-ruby

• Package generation pending.

[AutorestCI]

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5771

[AutorestCI]

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2635

[azuresdkci]

Can one of the admins verify this patch?

[AutorestCI]

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5096

[AutorestCI]

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3004

[anuchandy]

@jaredmoo SQL swagger please review.

Added "ARM review request" since the PR removes an API and introduces new property?

[jaredmoo]

Please address comments. Otherwise approved.

[johnpaulkee]

Will remove maintenance window changes from this PR.

[johnpaulkee]

Please address comments. Otherwise approved.

Thanks @jaredmoo - I've addressed comments.

[johnpaulkee]

@jaredmoo SQL swagger please review.

Added "ARM review request" since the PR removes an API and introduces new property?

I removed the new property section.
The API ManagedInstanceListByInstancePool is moved from 2015-05-01-preview to 2018-06-01-preview, this API is new and not yet published.

[ravbhatnagar]

@johnpaulkee - are you dropping support for this one API from 2015 preview? Whats the usage of this API in 2015 preview. For SQL, even though this API is marked as -preview, since it has been in this state for ever, its considered as perpetual preview. So, we don't want to break customers using this API -version.
Are there other managedInstances APIs that will be moved to 2018 preview?

[johnpaulkee]

@ravbhatnagar currently there is no usage for this ManagedInstance_ListByInstancePool API in 2015-05-01-preview and we plan to support it in 2018-06-01-preview. Customer's won't be broken using the newer API version as there are no clients/customers using it yet.

Currently this API doesn't work in 2015-05-01-preview as its request url starts with .../instancePool/{ipName}/managedInstances and currently in ARM manifest, instance pools only allows the 2018-06-01-preview api version. The migration of this API from 2015-05-01-preview over to 2018-06-01-preview will fix this and allow actual support of this API from SDKs.

There are no other managed instance APIs that we are moving from 2015-05-01-preview, and support for 2018-06-01-preview already exists in production for all other managed instance APIs.

[ravbhatnagar]

Thanks for confirming @johnpaulkee . Signing off from ARM side since it was confirmed that there is no usage of this API and it wouldnt have worked since in ARM the supported API version is the new one.

[johnpaulkee]

Thanks for confirming @johnpaulkee . Signing off from ARM side since it was confirmed that there is no usage of this API and it wouldnt have worked since in ARM the supported API version is the new one.

Thank you @ravbhatnagar.

[anuchandy]

Adding "breaking-change" tag since 2015-05-01-preview removes an API.