Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update attestation provider swagger #6401

Merged

Conversation

shleiAmy
Copy link
Contributor

@shleiAmy shleiAmy commented Jun 20, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 20, 2019

SDK Automation [Logs] (Generated from 0a4f31f)

@AutorestCI
Copy link

AutorestCI commented Jun 20, 2019

Automation for azure-sdk-for-python

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Jun 20, 2019

Automation for azure-sdk-for-ruby

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Jun 20, 2019

Automation for azure-sdk-for-go

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Jun 20, 2019

Automation for azure-sdk-for-java

Unable to detect any generation context from this PR.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@shleiAmy
Copy link
Contributor Author

@michaeljqzq all the checks pass, and the conflicts have been fixed. Could you please review this PR in as soon as possible to expedite our SDK release?Thank you.

@michaeljqzq michaeljqzq merged commit 4df94e4 into Azure:master Jun 21, 2019
leni-msft pushed a commit to leni-msft/azure-rest-api-specs that referenced this pull request May 13, 2022
* First Commit with previous version

* changes to support Polymorphism

* changes to swagger to update version and fix avarcardo error

* updating version in examples

* refactoring swagger model

* correcting statistics swagger value

* correcting typo in Statistic Filter

* prettier fix

* changes as per feedback in review to remove filterName in child model

* prettier fix

* changes to enable enum check in FilterName
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants