Update public swagger #6381

Yiliu-microsoft · 2019-06-19T09:43:05Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

update version

update

openapi-sdkautomation · 2019-06-19T09:43:08Z

SDK Automation [Logs] (Generated from 15aa824)

Python: Azure/azure-sdk-for-python [Logs]

No packages generated.

Java: Azure/azure-sdk-for-java [Logs]

No packages generated.

Go: Azure/azure-sdk-for-go [Logs]

No packages generated.

JavaScript: Azure/azure-sdk-for-js [Logs]

No packages generated.

AutorestCI · 2019-06-19T09:43:59Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2019-06-19T09:44:02Z

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout a97d98c86fde7577fc4bbe1b21f18aa88905fcbc
  stderr: 'fatal: reference is not a tree: a97d98c86fde7577fc4bbe1b21f18aa88905fcbc'

AutorestCI · 2019-06-19T09:45:20Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout a97d98c86fde7577fc4bbe1b21f18aa88905fcbc
  stderr: 'fatal: reference is not a tree: a97d98c86fde7577fc4bbe1b21f18aa88905fcbc'

AutorestCI · 2019-06-19T09:47:12Z

Automation for azure-sdk-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-java#3084

azuresdkci · 2019-06-19T10:02:00Z

Can one of the admins verify this patch?

amarzavery · 2019-07-01T17:08:27Z

@Yiliu-microsoft - Please resolve merge conflicts.

amarzavery · 2019-07-01T17:10:06Z

...tafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/Pipeline.json

+        },
+        "disableMetricsCollection": {
+          "type": "object",
+          "description": "Specifies whether to disable collecting data source metrics. Type: boolean (or Expression with resultType boolean)."


Can you update x-ms-examples for the operation that uses this model in the request body or response body and populate the example with this new property that has been added in this PR.

ravbhatnagar

a couple of comments. please ping me in case of any questions.

ravbhatnagar · 2019-07-01T18:44:52Z

...tafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/Pipeline.json

@@ -117,7 +117,8 @@
      "properties": {
        "activity": {
          "description": "Activity name.",
-          "type": "string"
+          "type": "string",
+          "minLength": 1


this is a breaking change. Looks like this restriction is added in the existing api-version.

ravbhatnagar · 2019-07-01T18:46:30Z

...tafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/Pipeline.json

@@ -824,6 +825,10 @@
        "maxConcurrentConnections": {
          "type": "object",
          "description": "The maximum concurrent connection count for the source data store. Type: integer (or Expression with resultType integer)."
+        },
+        "disableMetricsCollection": {


writable properties are typically added in new api-version as they can result in unintentional update of goal state when done in same api-version.

yungezz · 2019-08-12T07:06:30Z

@Yiliu-microsoft could you pls resolve comments and fixing CI? otherwise is it ok to close the PR for now, and pls create new PR when you're ready.

yungezz · 2019-08-28T07:33:32Z

close the PR since no update for a while. I cannot find corresponding email address from internal site either.

Yiliu added 9 commits March 14, 2019 15:56

Modify the public swagger by reference to private swagger

f756788

Merge remote-tracking branch 'upstream/master'

3015288

update version

Merge remote-tracking branch 'upstream/master'

2727b7c

update

Merge remote-tracking branch 'upstream/master'

047db66

Merge remote-tracking branch 'upstream/master'

1a04dc6

Merge remote-tracking branch 'upstream/master'

7e6a62e

Merge remote-tracking branch 'upstream/master'

39e11c9

July2th

aedfef3

July2th

a8c996b

azuresdkci assigned amarzavery Jun 19, 2019

azuresdkci requested a review from amarzavery June 19, 2019 09:44

back Binary

15aa824

amarzavery added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 1, 2019

amarzavery suggested changes Jul 1, 2019

View reviewed changes

ravbhatnagar reviewed Jul 1, 2019

View reviewed changes

ravbhatnagar added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jul 1, 2019

yungezz closed this Aug 28, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update public swagger #6381

Update public swagger #6381

Yiliu-microsoft commented Jun 19, 2019

openapi-sdkautomation bot commented Jun 19, 2019 •

edited

Loading

AutorestCI commented Jun 19, 2019 •

edited

Loading

AutorestCI commented Jun 19, 2019 •

edited

Loading

AutorestCI commented Jun 19, 2019 •

edited

Loading

AutorestCI commented Jun 19, 2019 •

edited

Loading

azuresdkci commented Jun 19, 2019

amarzavery commented Jul 1, 2019

amarzavery Jul 1, 2019

ravbhatnagar left a comment

ravbhatnagar Jul 1, 2019

ravbhatnagar Jul 1, 2019

yungezz commented Aug 12, 2019

yungezz commented Aug 28, 2019

Update public swagger #6381

Update public swagger #6381

Conversation

Yiliu-microsoft commented Jun 19, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

openapi-sdkautomation bot commented Jun 19, 2019 • edited Loading

SDK Automation [Logs] (Generated from 15aa824)

AutorestCI commented Jun 19, 2019 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Jun 19, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Jun 19, 2019 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Jun 19, 2019 • edited Loading

Automation for azure-sdk-for-java

azuresdkci commented Jun 19, 2019

amarzavery commented Jul 1, 2019

amarzavery Jul 1, 2019

Choose a reason for hiding this comment

ravbhatnagar left a comment

Choose a reason for hiding this comment

ravbhatnagar Jul 1, 2019

Choose a reason for hiding this comment

ravbhatnagar Jul 1, 2019

Choose a reason for hiding this comment

yungezz commented Aug 12, 2019

yungezz commented Aug 28, 2019

openapi-sdkautomation bot commented Jun 19, 2019 •

edited

Loading

AutorestCI commented Jun 19, 2019 •

edited

Loading

AutorestCI commented Jun 19, 2019 •

edited

Loading

AutorestCI commented Jun 19, 2019 •

edited

Loading

AutorestCI commented Jun 19, 2019 •

edited

Loading