[DO NOT MERGE] Add managed instance swaggers 2018-06-01-preview #6369

johnpaulkee · 2019-06-17T23:20:57Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

…d instances get by instance pool

…Pool to 2018-06-01-preview

openapi-sdkautomation · 2019-06-17T23:20:59Z

SDK Automation [Logs] (Generated from f9c8641)

Python: Azure/azure-sdk-for-python

Package generation pending.

Java: Azure/azure-sdk-for-java

Package generation pending.

Go: Azure/azure-sdk-for-go

Package generation pending.

JavaScript: Azure/azure-sdk-for-js

Package generation pending.

Ruby: Azure/azure-sdk-for-ruby

Package generation pending.

AutorestCI · 2019-06-17T23:21:47Z

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 82fb696c592324a45d6861136dc4e62fec7116e4
  stderr: 'fatal: reference is not a tree: 82fb696c592324a45d6861136dc4e62fec7116e4'

AutorestCI · 2019-06-17T23:21:51Z

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#3877

AutorestCI · 2019-06-17T23:23:07Z

Automation for azure-sdk-for-ruby

Encountered an unknown error: (azure-sdk-for-ruby)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 82fb696c592324a45d6861136dc4e62fec7116e4
  stderr: 'fatal: reference is not a tree: 82fb696c592324a45d6861136dc4e62fec7116e4'

...8-06-01-preview/examples/ManagedInstanceVulnerabilityAssessmentCreateContainerSasKeyMin.json

AutorestCI · 2019-06-17T23:28:08Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 82fb696c592324a45d6861136dc4e62fec7116e4
  stderr: 'fatal: reference is not a tree: 82fb696c592324a45d6861136dc4e62fec7116e4'

azuresdkci · 2019-06-17T23:57:53Z

Can one of the admins verify this patch?

AutorestCI · 2019-06-18T01:45:36Z

Automation for azure-sdk-for-java

Encountered an unknown error: (azure-sdk-for-java)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 82fb696c592324a45d6861136dc4e62fec7116e4
  stderr: 'fatal: reference is not a tree: 82fb696c592324a45d6861136dc4e62fec7116e4'

johnpaulkee · 2019-06-18T15:29:51Z

I did some manual editing of the 2018 managedInstances.json swagger so I'll do a check with @jaredmoo before allowing merge.

…into updateManagedInstanceSwaggers

John Paul Kee added 7 commits February 19, 2019 10:17

Initializing instance pools swagger and examples - no usages / manage…

5251cc1

…d instances get by instance pool

Sync latest

df56164

Merge branch 'master' of https://github.com/azure/azure-rest-api-specs

224291b

Merge branch 'master' of https://github.com/azure/azure-rest-api-specs

c1facdf

Merge branch 'master' of https://github.com/azure/azure-rest-api-specs

bda388a

Merge branch 'master' of https://github.com/azure/azure-rest-api-specs

24058a7

Update managed instance swaggers - move ManagedInstanceListByInstance…

4d1949b

…Pool to 2018-06-01-preview

johnpaulkee requested a review from jaredmoo as a code owner June 17, 2019 23:20

AutorestCI mentioned this pull request Jun 17, 2019

[AutoPR sql/resource-manager] Update managed instance swaggers - move ManagedInstanceListByInstancePool to 2018-06-01-preview Azure/azure-sdk-for-ruby#2637

Closed

johnpaulkee commented Jun 17, 2019

View reviewed changes

...8-06-01-preview/examples/ManagedInstanceVulnerabilityAssessmentCreateContainerSasKeyMin.json Outdated Show resolved Hide resolved

Putting these back in 2018-06-01-preview

d5e20a1

AutorestCI mentioned this pull request Jun 17, 2019

[AutoPR sql/resource-manager] Update managed instance swaggers - move ManagedInstanceListByInstancePool to 2018-06-01-preview Azure/azure-sdk-for-go#5034

Closed

azuresdkci assigned sergey-shandar Jun 17, 2019

azuresdkci requested a review from sergey-shandar June 17, 2019 23:44

Update readme.md to have 2018-06-01-preview managedInstances json file

3d1adff

John Paul Kee added 2 commits June 17, 2019 17:51

Update example api versions to 2018-06-01-preview

0f3fc6d

Filter to managed instance list by instance pool

96d5add

AutorestCI mentioned this pull request Jun 18, 2019

[AutoPR sql/resource-manager] Update managed instance swaggers - move ManagedInstanceListByInstancePool to 2018-06-01-preview Azure/azure-sdk-for-java#3978

Closed

johnpaulkee changed the title ~~Update managed instance swaggers - move ManagedInstanceListByInstancePool to 2018-06-01-preview~~ [DO NOT MERGE] Update managed instance swaggers - move ManagedInstanceListByInstancePool to 2018-06-01-preview Jun 18, 2019

Update 2018 managed instance swagger to include prior APIs

5c378f6

johnpaulkee changed the title ~~[DO NOT MERGE] Update managed instance swaggers - move ManagedInstanceListByInstancePool to 2018-06-01-preview~~ [DO NOT MERGE] Add managed instance swaggers 2018-06-01-preview Jun 19, 2019

John Paul Kee added 5 commits June 19, 2019 16:51

Merge branch 'master' of https://github.com/azure/azure-rest-api-specs …

d2cdfc2

…into updateManagedInstanceSwaggers

Updating managed instances swagger, removing examples not used

e744411

update to common typed definitions

0683328

Fix readme.md, no duplicate apis for managedInstances

163211e

remove managed instance metrics from swagger

f9c8641

johnpaulkee closed this Jun 25, 2019

johnpaulkee deleted the updateManagedInstanceSwaggers branch June 25, 2019 00:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DO NOT MERGE] Add managed instance swaggers 2018-06-01-preview #6369

[DO NOT MERGE] Add managed instance swaggers 2018-06-01-preview #6369

johnpaulkee commented Jun 17, 2019

openapi-sdkautomation bot commented Jun 17, 2019 •

edited

Loading

AutorestCI commented Jun 17, 2019 •

edited

Loading

AutorestCI commented Jun 17, 2019 •

edited

Loading

AutorestCI commented Jun 17, 2019 •

edited

Loading

AutorestCI commented Jun 17, 2019 •

edited

Loading

azuresdkci commented Jun 17, 2019

AutorestCI commented Jun 18, 2019 •

edited

Loading

johnpaulkee commented Jun 18, 2019

[DO NOT MERGE] Add managed instance swaggers 2018-06-01-preview #6369

[DO NOT MERGE] Add managed instance swaggers 2018-06-01-preview #6369

Conversation

johnpaulkee commented Jun 17, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

openapi-sdkautomation bot commented Jun 17, 2019 • edited Loading

SDK Automation [Logs] (Generated from f9c8641)

AutorestCI commented Jun 17, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Jun 17, 2019 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Jun 17, 2019 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Jun 17, 2019 • edited Loading

Automation for azure-sdk-for-go

azuresdkci commented Jun 17, 2019

AutorestCI commented Jun 18, 2019 • edited Loading

Automation for azure-sdk-for-java

johnpaulkee commented Jun 18, 2019

openapi-sdkautomation bot commented Jun 17, 2019 •

edited

Loading

AutorestCI commented Jun 17, 2019 •

edited

Loading

AutorestCI commented Jun 17, 2019 •

edited

Loading

AutorestCI commented Jun 17, 2019 •

edited

Loading

AutorestCI commented Jun 17, 2019 •

edited

Loading

AutorestCI commented Jun 18, 2019 •

edited

Loading