(Public swagger update) Add TeradataSource,TeradataPartitionSettings,TeradataTableDataset,TeradataTableDatasetTypeProperties #6346

Yiliu-microsoft · 2019-06-14T08:37:12Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

update version

update

openapi-sdkautomation · 2019-06-14T08:37:15Z

SDK Automation [Logs] (Generated from 0fb95a0)

Python: Azure/azure-sdk-for-python

Package generation pending.

Java: Azure/azure-sdk-for-java

Package generation pending.

Go: Azure/azure-sdk-for-go

Package generation pending.

JavaScript: Azure/azure-sdk-for-js

Package generation pending.

azuresdkci · 2019-06-14T08:37:43Z

Can one of the admins verify this patch?

AutorestCI · 2019-06-14T08:38:06Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2019-06-14T08:38:37Z

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3084

AutorestCI · 2019-06-14T08:39:22Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5747

AutorestCI · 2019-06-14T08:43:43Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4990

AutorestCI · 2019-06-14T09:11:32Z

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#3778

nschonni

specificed -> specified

...tafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/Pipeline.json

xiaoyingQQ · 2019-06-17T08:44:03Z

@nschonni , could you help approve this PR? The comment is resolved.

nschonni · 2019-06-17T12:44:14Z

@xiaoyingLJ sorry, i'm not an MS employee, it'll need to be one of the actual repo admins

xiaoyingQQ · 2019-06-19T00:52:18Z

@jhendrixMSFT , could you help merge this PR?

jhendrixMSFT · 2019-06-19T15:32:18Z

@xiaoyingQQ ARM needs to approve the change before I can merge.

xiaoyingLJ-zz · 2019-06-19T15:50:45Z

How long does it need for ARM approve? This PR is waiting for some days. We want this change is merged in this week to catch our ETA of this feature. Could you help me to expedite this PR? Great thanks Xiaoying From: Joel Hendrix <[email protected]> Sent: Wednesday, June 19, 2019 11:33 PM To: Azure/azure-rest-api-specs <[email protected]> Cc: Xiaoying Zhang <[email protected]>; Mention <[email protected]> Subject: Re: [Azure/azure-rest-api-specs] (Public swagger update) Add TeradataSource,TeradataPartitionSettings,TeradataTableDataset,TeradataTableDatasetTypeProperties (#6346) @xiaoyingQQ<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FxiaoyingQQ&data=02%7C01%7Cxiaoyz%40microsoft.com%7Cff457b7894314e85f2f908d6f4cb63a8%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636965551741621285&sdata=y%2FB%2F4aDiy4iQdBMHJyyoHEbboJXxYF0GmuoM1HMmLDw%3D&reserved=0> ARM needs to approve the change before I can merge. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F6346%3Femail_source%3Dnotifications%26email_token%3DAF2AXXSIGXLSGMSEMWHK6T3P3JGSFA5CNFSM4HYFW25KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYCIC5A%23issuecomment-503611764&data=02%7C01%7Cxiaoyz%40microsoft.com%7Cff457b7894314e85f2f908d6f4cb63a8%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636965551741621285&sdata=2jIpNr8x9yvTYgpSOFZNr6TDXAJg2%2B5YV2yMyiFp%2Bg8%3D&reserved=0>, or mute the thread<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAF2AXXW7SZRK7ZKUWND2BQ3P3JGSFANCNFSM4HYFW25A&data=02%7C01%7Cxiaoyz%40microsoft.com%7Cff457b7894314e85f2f908d6f4cb63a8%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636965551741631280&sdata=9qwE38aHR0Tc26znEEV465L%2B41IirXLf4272gEeUj8Q%3D&reserved=0>.

jhendrixMSFT · 2019-06-19T15:52:33Z

@xiaoyingLJ please read the initial comment in the PR, it contains instructions for how to expedite the ARM review process.

jhendrixMSFT

Waiting for ARM review, will merge once we have that.

majastrz · 2019-06-19T19:47:01Z

...atafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/Dataset.json

@@ -1182,6 +1182,36 @@
        }
      }
    },
+    "TeradataTableDatasetTypeProperties": {


Teradata [](start = 5, length = 8)

I am really confused about these changes. The new definitions aren't really referenced in any paths, so this will result in no change to the API contract. Autorest might generate types for all the new definitions, but the clients won't get any new methods to utilize them.

What is the intent here? If you are planning to add paths later, will you be introducing a new API version? #Closed

I missed that we're using discriminator value.

In reply to: 295493306 [](ancestors = 295493306)

The users know that they're expected to update to latest SDK to use newest types of data sets.

In reply to: 295580149 [](ancestors = 295580149,295493306)

majastrz · 2019-06-19T19:49:24Z

...atafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/Dataset.json

+    "TeradataTableDataset": {
+      "x-ms-discriminator-value": "TeradataTable",
+      "description": "The Teradata database dataset.",
+      "type": "object",


object [](start = 15, length = 6)

I see that you're modeling a lot of properties as object without referencing a definition. In the c# generated SDK, the property type will be object. Is that intended? How do you pass an expression via the C# SDK? What kind of expression are these also? #Closed

Discussed on a call. C# SDK has a class that users can new up and pass in for the property value. Also backend supports multiple types.

In reply to: 295494222 [](ancestors = 295494222)

majastrz

I took a look at the changes and added a couple of questions. Can you take a look? We can discuss at the meeting you scheduled for today as well.

majastrz

Looks good to me.

Yiliu added 7 commits March 14, 2019 15:56

Modify the public swagger by reference to private swagger

f756788

Merge remote-tracking branch 'upstream/master'

3015288

update version

Merge remote-tracking branch 'upstream/master'

2727b7c

update

Merge remote-tracking branch 'upstream/master'

047db66

Merge remote-tracking branch 'upstream/master'

1a04dc6

Merge remote-tracking branch 'upstream/master'

7e6a62e

add TerdateTableDataset,TeradataSource

d2b6a0a

azuresdkci assigned jhendrixMSFT Jun 14, 2019

azuresdkci requested a review from jhendrixMSFT June 14, 2019 08:38

AutorestCI mentioned this pull request Jun 14, 2019

[AutoPR datafactory/resource-manager] (Public swagger update) Add TeradataSource,TeradataPartitionSettings,TeradataTableDataset,TeradataTableDatasetTypeProperties Azure/azure-sdk-for-python#5865

Merged

AutorestCI mentioned this pull request Jun 14, 2019

[AutoPR datafactory/resource-manager] (Public swagger update) Add TeradataSource,TeradataPartitionSettings,TeradataTableDataset,TeradataTableDatasetTypeProperties Azure/azure-sdk-for-go#5015

Merged

AutorestCI mentioned this pull request Jun 14, 2019

[AutoPR datafactory/resource-manager] (Public swagger update) Add TeradataSource,TeradataPartitionSettings,TeradataTableDataset,TeradataTableDatasetTypeProperties Azure/azure-sdk-for-js#3804

Closed

nschonni reviewed Jun 14, 2019

View reviewed changes

...tafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/Pipeline.json Outdated Show resolved Hide resolved

...tafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/Pipeline.json Outdated Show resolved Hide resolved

modify specified

0fb95a0

AutorestCI mentioned this pull request Jun 17, 2019

[AutoPR datafactory/resource-manager] (Public swagger update) Add TeradataSource,TeradataPartitionSettings,TeradataTableDataset,TeradataTableDatasetTypeProperties Azure/azure-sdk-for-java#3935

Merged

jhendrixMSFT added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 17, 2019

jhendrixMSFT approved these changes Jun 19, 2019

View reviewed changes

majastrz reviewed Jun 19, 2019

View reviewed changes

majastrz approved these changes Jun 20, 2019

View reviewed changes

majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 20, 2019

jhendrixMSFT merged commit 7a5e168 into Azure:master Jun 20, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(Public swagger update) Add TeradataSource,TeradataPartitionSettings,TeradataTableDataset,TeradataTableDatasetTypeProperties #6346

(Public swagger update) Add TeradataSource,TeradataPartitionSettings,TeradataTableDataset,TeradataTableDatasetTypeProperties #6346

Yiliu-microsoft commented Jun 14, 2019

openapi-sdkautomation bot commented Jun 14, 2019 •

edited

Loading

azuresdkci commented Jun 14, 2019

AutorestCI commented Jun 14, 2019 •

edited

Loading

AutorestCI commented Jun 14, 2019 •

edited

Loading

AutorestCI commented Jun 14, 2019 •

edited

Loading

AutorestCI commented Jun 14, 2019 •

edited

Loading

AutorestCI commented Jun 14, 2019 •

edited

Loading

nschonni left a comment

xiaoyingQQ commented Jun 17, 2019

nschonni commented Jun 17, 2019

xiaoyingQQ commented Jun 19, 2019

jhendrixMSFT commented Jun 19, 2019

xiaoyingLJ-zz commented Jun 19, 2019 via email

jhendrixMSFT commented Jun 19, 2019

jhendrixMSFT left a comment

majastrz Jun 19, 2019 •

edited

Loading

majastrz Jun 20, 2019

majastrz Jun 20, 2019

majastrz Jun 19, 2019 •

edited

Loading

majastrz Jun 20, 2019

majastrz left a comment

majastrz left a comment

(Public swagger update) Add TeradataSource,TeradataPartitionSettings,TeradataTableDataset,TeradataTableDatasetTypeProperties #6346

(Public swagger update) Add TeradataSource,TeradataPartitionSettings,TeradataTableDataset,TeradataTableDatasetTypeProperties #6346

Conversation

Yiliu-microsoft commented Jun 14, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

openapi-sdkautomation bot commented Jun 14, 2019 • edited Loading

SDK Automation [Logs] (Generated from 0fb95a0)

azuresdkci commented Jun 14, 2019

AutorestCI commented Jun 14, 2019 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Jun 14, 2019 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Jun 14, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Jun 14, 2019 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Jun 14, 2019 • edited Loading

Automation for azure-sdk-for-js

nschonni left a comment

Choose a reason for hiding this comment

xiaoyingQQ commented Jun 17, 2019

nschonni commented Jun 17, 2019

xiaoyingQQ commented Jun 19, 2019

jhendrixMSFT commented Jun 19, 2019

xiaoyingLJ-zz commented Jun 19, 2019 via email

jhendrixMSFT commented Jun 19, 2019

jhendrixMSFT left a comment

Choose a reason for hiding this comment

majastrz Jun 19, 2019 • edited Loading

Choose a reason for hiding this comment

majastrz Jun 20, 2019

Choose a reason for hiding this comment

majastrz Jun 20, 2019

Choose a reason for hiding this comment

majastrz Jun 19, 2019 • edited Loading

Choose a reason for hiding this comment

majastrz Jun 20, 2019

Choose a reason for hiding this comment

majastrz left a comment

Choose a reason for hiding this comment

majastrz left a comment

Choose a reason for hiding this comment

openapi-sdkautomation bot commented Jun 14, 2019 •

edited

Loading

AutorestCI commented Jun 14, 2019 •

edited

Loading

AutorestCI commented Jun 14, 2019 •

edited

Loading

AutorestCI commented Jun 14, 2019 •

edited

Loading

AutorestCI commented Jun 14, 2019 •

edited

Loading

AutorestCI commented Jun 14, 2019 •

edited

Loading

majastrz Jun 19, 2019 •

edited

Loading

majastrz Jun 19, 2019 •

edited

Loading