Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ContainerService 2019-06-01 API #6284

Merged
merged 11 commits into from
Jun 19, 2019
Merged

ContainerService 2019-06-01 API #6284

merged 11 commits into from
Jun 19, 2019

Conversation

xizha162
Copy link
Contributor

@xizha162 xizha162 commented Jun 10, 2019 •
edited
Loading

Included in this PR:

  1. Agent pool get versions API to get a list of available versions to use when creating agent pool
  2. Agent pool get upgrade profile API to get a list of available versions to upgrade for an agent pool
  3. Added node taints property to agent pool.
  4. Added ScaleSetPriority and ScaleSetEvicitionPolicy to agent pool
  5. Added EnableNodePublicIP property to agent pool

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@xizha162 xizha162 requested a review from mboersma as a code owner June 10, 2019 19:31
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 10, 2019 •
edited
Loading

SDK Automation [Logs] (Generated from 3f24bf7)

Pending Python: Azure/azure-sdk-for-python
  • Package generation pending.
Pending Java: Azure/azure-sdk-for-java
  • Package generation pending.
Pending Go: Azure/azure-sdk-for-go
  • Package generation pending.
Pending JavaScript: Azure/azure-sdk-for-js
  • Package generation pending.
Pending C#: Azure/azure-sdk-for-net
  • Package generation pending.
Pending Ruby: Azure/azure-sdk-for-ruby
  • Package generation pending.

This was referenced Jun 10, 2019
Closed
Closed
@AutorestCI
Copy link

AutorestCI commented Jun 10, 2019 •
edited
Loading

Automation for azure-sdk-for-js

A PR has been created for you:
Azure/azure-sdk-for-js#3708

@AutorestCI
Copy link

AutorestCI commented Jun 10, 2019 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#5964

@AutorestCI
Copy link

AutorestCI commented Jun 10, 2019 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI AutorestCI mentioned this pull request Jun 10, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Jun 10, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2654

@AutorestCI
Copy link

AutorestCI commented Jun 10, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5053

@xizha162 xizha162 requested a review from yangl900 June 10, 2019 19:41
@AutorestCI AutorestCI mentioned this pull request Jun 10, 2019
Merged
@azuresdkci azuresdkci requested a review from jhendrixMSFT June 10, 2019 19:44
@jhendrixMSFT jhendrixMSFT added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 10, 2019
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Jun 10, 2019
Merged
yangl900
yangl900 approved these changes Jun 11, 2019
View reviewed changes
Copy link
Contributor

@yangl900 yangl900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AutorestCI AutorestCI mentioned this pull request Jun 12, 2019
Closed
@anthony-c-martin anthony-c-martin added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 14, 2019
jhendrixMSFT
jhendrixMSFT requested changes Jun 17, 2019
View reviewed changes
...containerservice/resource-manager/Microsoft.ContainerService/stable/2019-06-01/location.json
"tags": [
"ContainerServices"
],
"operationId": "ContainerServices_ListOrchestrators",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orchestrators_List

...containerservice/resource-manager/Microsoft.ContainerService/stable/2019-06-01/location.json
],
"description": "The properties of an orchestrator version profile."
},
"OrchestratorVersionProfileListResult": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type name is a bit long, how about OrchestratorListResult? Matches with the (new) operationId as well.

jhendrixMSFT
jhendrixMSFT approved these changes Jun 18, 2019
View reviewed changes
Copy link
Member

@jhendrixMSFT jhendrixMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per discussion these names are copied from the previous API version so we will leave them as-is.

@jhendrixMSFT
Copy link
Member

@antmarti-microsoft if your issues have been addresses can you please approve? Your request for changes is preventing merging of this PR.

@jhendrixMSFT jhendrixMSFT merged commit 916cc80 into Azure:master Jun 19, 2019
@AutorestCI AutorestCI mentioned this pull request Jun 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthony-c-martin anthony-c-martin anthony-c-martin approved these changes

@jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

@yangl900 yangl900 yangl900 approved these changes

@mboersma mboersma Awaiting requested review from mboersma

Assignees

@jhendrixMSFT jhendrixMSFT

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@xizha162 @AutorestCI @azuresdkci @jhendrixMSFT @yangl900 @anthony-c-martin