chore: jsonfmt relay #6226
chore: jsonfmt relay #6226
Conversation
SDK Automation [Logs] (Generated from aec3ef5)
|
Automation for azure-sdk-for-pythonNothing to generate for azure-sdk-for-python |
Automation for azure-sdk-for-javaEncountered a Subprocess error: (azure-sdk-for-java)
Command: ['/usr/local/bin/autorest', '/tmp/tmpgfmigu84/rest/specification/relay/resource-manager/readme.md', '--perform-load=false', '--swagger-to-sdk', '--output-artifact=configuration.json', '--input-file=foo', '--output-folder=/tmp/tmp0ddw5ny9'] AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Failure:
Error: Unable to start AutoRest Core from /root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core
Error: Unable to start AutoRest Core from /root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core
at main (/opt/node_modules/autorest/dist/app.js:232:19)
at <anonymous>
/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/app.js:33
autorest_core_1.Shutdown();
^
ReferenceError: autorest_core_1 is not defined
at process.on (/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/app.js:33:5)
at emitOne (events.js:121:20)
at process.emit (events.js:211:7)
at process.emit (/node_modules/source-map-support/source-map-support.js:439:21)
fs.js:612
return binding.close(fd);
^
Error: EBADF: bad file descriptor, close
at Object.fs.closeSync (fs.js:612:18)
at StaticVolumeFile.shutdown (/opt/node_modules/autorest/dist/static-loader.js:352:10)
at StaticFilesystem.shutdown (/opt/node_modules/autorest/dist/static-loader.js:406:17)
at process.exit.n [as exit] (/opt/node_modules/autorest/dist/static-loader.js:169:11)
at printErrorAndExit (/node_modules/source-map-support/source-map-support.js:423:11)
at process.emit (/node_modules/source-map-support/source-map-support.js:435:16)
at process._fatalException (bootstrap_node.js:391:26) |
Automation for azure-sdk-for-rubyThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
|
Can one of the admins verify this patch? |
Automation for azure-sdk-for-jsA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Ran `jsonfmt -w "specification/relay/**/*.json"`
The property isn't in Operation/display
nschonni
force-pushed
the
chore--jsonfmt-relay
branch
from
9dcdfb6 to
aec3ef5
Compare
|
@v-Ajnava I fixed the model validation issue by removing the "description" from the example file. I can remove this if you prefer |
| } | ||
| }, | ||
| { | ||
| "name": "Microsoft.Relay/namespaces/WcfRelays/read", | ||
| "display": { | ||
| "provider": "Microsoft Azure Relay", | ||
| "resource": "WcfRelay", | ||
| "operation": "Get WcfRelay", | ||
| "description": "Get list of WcfRelay Resource Descriptions" | ||
| "operation": "Get WcfRelay" |
There was a problem hiding this comment.
why have the descriptions been pulled out here?
There was a problem hiding this comment.
Description isn't part of the Swagger spec, and was likely added because of a VS Code JSON schema bug that suggest "description" be added to example files. Without this the model validation will fail (see first commit). I can submit it separately, but the build won't pass. Let me know how you want to handle it
There was a problem hiding this comment.
@praries880 I've opened an issue with some background over here #6277, since it has come up on a few PR 😄
I'm still good if you want it removed from this PR
| } | ||
| }, | ||
| { | ||
| "name": "Microsoft.Relay/namespaces/WcfRelays/authorizationRules/write", | ||
| "display": { | ||
| "provider": "Microsoft Azure Relay", | ||
| "resource": "WcfRelay AuthorizationRules", | ||
| "operation": "Create or Update WcfRelay Authorization Rule", | ||
| "description": "Create WcfRelay Authorization Rules and Update its properties. The Authorization Rules Access Rights, the Primary and Secondary Keys can be updated." | ||
| "operation": "Create or Update WcfRelay Authorization Rule" |
There was a problem hiding this comment.
same for all operaitons in this file?
| } | ||
| }, | ||
| { | ||
| "name": "Microsoft.Relay/namespaces/write", | ||
| "display": { | ||
| "provider": "Microsoft Azure Relay", | ||
| "resource": "Namespace", | ||
| "operation": "Create Or Update Namespace ", | ||
| "description": "Create a Namespace Resource and Update its properties. Tags and status of the Namespace are the properties which can be updated." | ||
| "operation": "Create Or Update Namespace " |
Ran
jsonfmt -w "specification/relay/**/*.json"