Add missing values to enum #6212

EvgenyAgafonchikov · 2019-06-04T08:16:43Z

Fixes this issue: Azure/azure-sdk-for-go#4934.

Values are taken from server responses to keep correct values for each API version.

Networking PR is intentionally opened against master to provide fix ASAP.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

openapi-sdkautomation · 2019-06-04T08:16:46Z

SDK Automation [Logs] (Generated from 18989d6)

Python: Azure/azure-sdk-for-python

Package generation pending.

Java: Azure/azure-sdk-for-java

Package generation pending.

Go: Azure/azure-sdk-for-go

Package generation pending.

JavaScript: Azure/azure-sdk-for-js

Package generation pending.

Ruby: Azure/azure-sdk-for-ruby

Package generation pending.

AutorestCI · 2019-06-04T08:18:11Z

Automation for azure-sdk-for-java

Encountered a Subprocess error: (azure-sdk-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmp4jrddoev/rest/specification/network/resource-manager/readme.md', '--perform-load=false', '--swagger-to-sdk', '--output-artifact=configuration.json', '--input-file=foo', '--output-folder=/tmp/tmpo9l74aiz']
Finished with return code 7
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Failure:
Error: Unable to start AutoRest Core from /root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core
Error: Unable to start AutoRest Core from /root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core
    at main (/opt/node_modules/autorest/dist/app.js:232:19)
    at <anonymous>

/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/app.js:33
    autorest_core_1.Shutdown();
    ^
ReferenceError: autorest_core_1 is not defined
    at process.on (/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/app.js:33:5)
    at emitOne (events.js:121:20)
    at process.emit (events.js:211:7)
    at process.emit (/node_modules/source-map-support/source-map-support.js:439:21)
fs.js:612
  return binding.close(fd);
                 ^

Error: EBADF: bad file descriptor, close
    at Object.fs.closeSync (fs.js:612:18)
    at StaticVolumeFile.shutdown (/opt/node_modules/autorest/dist/static-loader.js:352:10)
    at StaticFilesystem.shutdown (/opt/node_modules/autorest/dist/static-loader.js:406:17)
    at process.exit.n [as exit] (/opt/node_modules/autorest/dist/static-loader.js:169:11)
    at printErrorAndExit (/node_modules/source-map-support/source-map-support.js:423:11)
    at process.emit (/node_modules/source-map-support/source-map-support.js:435:16)
    at process._fatalException (bootstrap_node.js:391:26)

AutorestCI · 2019-06-04T08:18:27Z

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmpqjjjjcq_/rest/specification/network/resource-manager/readme.md', '--keep-version-file', '--multiapi', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmpqjjjjcq_/sdk/sdk', '[email protected]/[email protected]', '--version=preview']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4383)
   Loading AutoRest extension '@microsoft.azure/autorest.python' (4.0.70->4.0.70)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Processing batch task - {"tag":"package-2019-04"} .

<--- Last few GCs --->

[30274:0x4263c70]    61811 ms: Mark-sweep 1339.7 (1425.4) -> 1339.3 (1425.4) MB, 1232.8 / 0.0 ms  (average mu = 0.114, current mu = 0.003) allocation failure scavenge might not succeed
[30274:0x4263c70]    63437 ms: Mark-sweep 1340.1 (1425.4) -> 1339.8 (1425.9) MB, 1622.3 / 0.0 ms  (average mu = 0.053, current mu = 0.002) allocation failure scavenge might not succeed


<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x204f37c1e6e9 <JSObject>
    0: builtin exit frame: concat(this=0x39774b7d1579 <JSArray[13]>,0x39774b7d6ac1 <JSArray[1]>,0x39774b7d1579 <JSArray[13]>)

    1: Descendants [0x1dbcc616d119] [/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/lib/ref/yaml.js:~29] [pc=0x141c20fa18d5](this=0x1dbcc6162029 <Object map = 0xad03d7bba91>,/* anonymous */=0x350031282801 <the_hol...

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
 1: 0x8dc510 node::Abort() [node]
 2: 0x8dc55c  [node]
 3: 0xad9b5e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [node]
 4: 0xad9d94 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [node]
 5: 0xec7bf2  [node]
 6: 0xec7cf8 v8::internal::Heap::CheckIneffectiveMarkCompact(unsigned long, double) [node]
 7: 0xed3dd2 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [node]
 8: 0xed4704 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [node]
 9: 0xed7371 v8::internal::Heap::AllocateRawWithRetryOrFail(int, v8::internal::AllocationSpace, v8::internal::AllocationAlignment) [node]
10: 0xea0466 v8::internal::Factory::AllocateRawArray(int, v8::internal::PretenureFlag) [node]
11: 0xea0cea v8::internal::Factory::NewFixedArrayWithFiller(v8::internal::Heap::RootListIndex, int, v8::internal::Object*, v8::internal::PretenureFlag) [node]
12: 0xead6d1 v8::internal::Factory::NewJSArrayStorage(v8::internal::Handle<v8::internal::JSArray>, int, int, v8::internal::ArrayStorageAllocationMode) [node]
13: 0xead9cc v8::internal::Factory::NewJSArray(v8::internal::ElementsKind, int, int, v8::internal::ArrayStorageAllocationMode, v8::internal::PretenureFlag) [node]
14: 0xe66e01 v8::internal::ElementsAccessor::Concat(v8::internal::Isolate*, v8::internal::Arguments*, unsigned int, unsigned int) [node]
15: 0xb63d99  [node]
16: 0xb6d498 v8::internal::Builtin_ArrayConcat(int, v8::internal::Object**, v8::internal::Isolate*) [node]
17: 0x141c20adbf7d

AutorestCI · 2019-06-04T08:18:50Z

Automation for azure-sdk-for-go

Encountered a Subprocess error: (azure-sdk-for-go)

Command: ['/usr/local/bin/autorest', '/tmp/tmpln_bnkcn/rest/specification/network/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmpln_bnkcn/src/github.com/Azure/azure-sdk-for-go', '--multiapi', '--preview-chk', '[email protected]/autorest.go@~2.1.133', '--use-onever', '--verbose']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4302)
   Including configuration file 'file:///tmp/tmpln_bnkcn/rest/specification/network/resource-manager/readme.go.md'
   Loading AutoRest extension '@microsoft.azure/autorest.go' (~2.1.133->2.1.133)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2019-02"} .
   Including configuration file 'file:///tmp/tmpln_bnkcn/rest/specification/network/resource-manager/readme.go.md'

<--- Last few GCs --->

[8157:0x2f2d8c0]    99694 ms: Mark-sweep 1386.7 (1470.9) -> 1386.6 (1472.4) MB, 1565.8 / 0.0 ms  allocation failure GC in old space requested
[8157:0x2f2d8c0]   101291 ms: Mark-sweep 1386.6 (1472.4) -> 1386.6 (1436.9) MB, 1595.9 / 0.0 ms  last resort GC in old space requested
[8157:0x2f2d8c0]   102879 ms: Mark-sweep 1386.6 (1436.9) -> 1386.6 (1434.9) MB, 1587.7 / 0.0 ms  last resort GC in old space requested


<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x1d28546a5879 <JSObject>
    1: set [native weak-collection.js:~27] [pc=0x68fe4af38c9](this=0x1efae5602499 <JSWeakMap>,key=0x1ff7dfe88439 <Object map = 0x1072ac2ff771>,value=0xce3c9202371 <true>)
    2: /* anonymous */(aka /* anonymous */) [/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/lib/ref/yaml.js:~101] [pc=0x68fe4a6c439](this=0xce3c92022d1 <undefined>,cache...

FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
 1: node::Abort() [node]
 2: 0x8cbf4c [node]
 3: v8::Utils::ReportOOMFailure(char const*, bool) [node]
 4: v8::internal::V8::FatalProcessOutOfMemory(char const*, bool) [node]
 5: v8::internal::Factory::NewFixedArray(int, v8::internal::PretenureFlag) [node]
 6: v8::internal::HashTable<v8::internal::ObjectHashTable, v8::internal::ObjectHashTableShape>::NewInternal(v8::internal::Isolate*, int, v8::internal::PretenureFlag) [node]
 7: v8::internal::HashTable<v8::internal::ObjectHashTable, v8::internal::ObjectHashTableShape>::New(v8::internal::Isolate*, int, v8::internal::PretenureFlag, v8::internal::MinimumCapacity) [node]
 8: v8::internal::HashTable<v8::internal::ObjectHashTable, v8::internal::ObjectHashTableShape>::EnsureCapacity(v8::internal::Handle<v8::internal::ObjectHashTable>, int, v8::internal::PretenureFlag) [node]
 9: v8::internal::ObjectHashTable::Put(v8::internal::Handle<v8::internal::ObjectHashTable>, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int) [node]
10: v8::internal::JSWeakCollection::Set(v8::internal::Handle<v8::internal::JSWeakCollection>, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int) [node]
11: v8::internal::Runtime_WeakCollectionSet(int, v8::internal::Object**, v8::internal::Isolate*) [node]
12: 0x68fe49042fd

azuresdkci · 2019-06-04T08:19:35Z

Can one of the admins verify this patch?

AutorestCI · 2019-06-04T08:19:48Z

Automation for azure-sdk-for-js

Encountered a Subprocess error: (azure-sdk-for-js)

Command: ['/usr/local/bin/autorest', '/tmp/tmppj83ilma/rest/specification/network/resource-manager/readme.md', '--license-header=MICROSOFT_MIT_NO_VERSION', '--typescript', '--typescript-sdks-folder=/tmp/tmppj83ilma/azure-sdk-for-js', '[email protected]/[email protected]']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4299)
   Loading AutoRest extension '@microsoft.azure/autorest.typescript' (4.0.0->4.0.0)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.51->2.3.51)

<--- Last few GCs --->

[27686:0x3002860]   131974 ms: Mark-sweep 1396.4 (1476.6) -> 1396.4 (1476.6) MB, 1304.6 / 0.0 ms  allocation failure GC in old space requested
[27686:0x3002860]   133873 ms: Mark-sweep 1396.4 (1476.6) -> 1396.4 (1440.6) MB, 1899.4 / 0.0 ms  last resort GC in old space requested
[27686:0x3002860]   135457 ms: Mark-sweep 1396.4 (1440.6) -> 1396.4 (1440.6) MB, 1583.0 / 0.0 ms  last resort GC in old space requested


<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x30037f825879 <JSObject>
    1: readLineBreak(aka readLineBreak) [/node_modules/yaml-ast-parser/dist/src/loader.js:~300] [pc=0x140be928d122](this=0x5a086022d1 <undefined>,state=0x133a8ed022a9 <State map = 0x3969ca8eeaf9>)
    2: readFlowCollection(aka readFlowCollection) [/node_modules/yaml-ast-parser/dist/src/loader.js:~596] [pc=0x140be92b0e80](this=0x5a086022d1 <undefined>,state=0x133a8ed022a9 <State map = 0x3969ca8ee...

FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
 1: node::Abort() [node]
 2: 0x8cbf4c [node]
 3: v8::Utils::ReportOOMFailure(char const*, bool) [node]
 4: v8::internal::V8::FatalProcessOutOfMemory(char const*, bool) [node]
 5: v8::internal::Factory::NewUninitializedFixedArray(int) [node]
 6: 0xd7fc13 [node]
 7: v8::internal::Runtime_GrowArrayElements(int, v8::internal::Object**, v8::internal::Isolate*) [node]
 8: 0x140be8c842fd

AutorestCI · 2019-06-04T08:24:14Z

Automation for azure-sdk-for-ruby

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-ruby#2599

MikhailTryakhov · 2019-06-05T02:07:50Z

@sergey-shandar can you please merge this change to the master due to IGNORE spec is failing

...ication/network/resource-manager/Microsoft.Network/stable/2017-06-01/applicationGateway.json

anton-evseev · 2019-06-07T11:23:27Z

@sergey-shandar addressed your comments, please take a look

EvgenyAgafonchikov requested a review from MikhailTryakhov as a code owner June 4, 2019 08:16

azuresdkci assigned sergey-shandar Jun 4, 2019

azuresdkci requested a review from sergey-shandar June 4, 2019 08:17

AutorestCI mentioned this pull request Jun 4, 2019

[AutoPR network/resource-manager] Add missing values to enum Azure/azure-sdk-for-ruby#2532

Closed

EvgenyAgafonchikov mentioned this pull request Jun 4, 2019

Update cipher suites #6213

Merged

5 tasks

MikhailTryakhov approved these changes Jun 5, 2019

View reviewed changes

sergey-shandar suggested changes Jun 6, 2019

View reviewed changes

...ication/network/resource-manager/Microsoft.Network/stable/2017-06-01/applicationGateway.json Outdated Show resolved Hide resolved

Add missing values to enum

18989d6

anton-evseev force-pushed the cipher-suites branch from 3b181af to 18989d6 Compare June 7, 2019 11:03

sergey-shandar approved these changes Jun 12, 2019

View reviewed changes

sergey-shandar merged commit e19543a into Azure:master Jun 12, 2019

AutorestCI mentioned this pull request Jun 12, 2019

[AutoPR network/resource-manager] Add missing values to enum Azure/azure-sdk-for-ruby#2603

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add missing values to enum #6212

Add missing values to enum #6212

EvgenyAgafonchikov commented Jun 4, 2019 •

edited

Loading

openapi-sdkautomation bot commented Jun 4, 2019 •

edited

Loading

AutorestCI commented Jun 4, 2019 •

edited

Loading

AutorestCI commented Jun 4, 2019 •

edited

Loading

AutorestCI commented Jun 4, 2019 •

edited

Loading

azuresdkci commented Jun 4, 2019

AutorestCI commented Jun 4, 2019 •

edited

Loading

AutorestCI commented Jun 4, 2019 •

edited

Loading

MikhailTryakhov commented Jun 5, 2019

anton-evseev commented Jun 7, 2019

Add missing values to enum #6212

Add missing values to enum #6212

Conversation

EvgenyAgafonchikov commented Jun 4, 2019 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

openapi-sdkautomation bot commented Jun 4, 2019 • edited Loading

SDK Automation [Logs] (Generated from 18989d6)

AutorestCI commented Jun 4, 2019 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Jun 4, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Jun 4, 2019 • edited Loading

Automation for azure-sdk-for-go

azuresdkci commented Jun 4, 2019

AutorestCI commented Jun 4, 2019 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Jun 4, 2019 • edited Loading

Automation for azure-sdk-for-ruby

MikhailTryakhov commented Jun 5, 2019

anton-evseev commented Jun 7, 2019

EvgenyAgafonchikov commented Jun 4, 2019 •

edited

Loading

openapi-sdkautomation bot commented Jun 4, 2019 •

edited

Loading

AutorestCI commented Jun 4, 2019 •

edited

Loading

AutorestCI commented Jun 4, 2019 •

edited

Loading

AutorestCI commented Jun 4, 2019 •

edited

Loading

AutorestCI commented Jun 4, 2019 •

edited

Loading

AutorestCI commented Jun 4, 2019 •

edited

Loading