Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Review request for Microsoft.VMwareCloudSimple to add version stable/2019-04-01 #6196

Merged
merged 24 commits into from
Jun 20, 2019
Merged

[Hub Generated] Review request for Microsoft.VMwareCloudSimple to add version stable/2019-04-01 #6196

merged 24 commits into from
Jun 20, 2019

Conversation

tenmozes
Copy link
Contributor

@tenmozes tenmozes commented Jun 3, 2019 •
edited
Loading

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

@msftclas
Copy link

msftclas commented Jun 3, 2019 •
edited
Loading

CLA assistant check
All CLA requirements met.

@AutorestCI AutorestCI mentioned this pull request Jun 3, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Jun 3, 2019 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#6003

@azuresdkci azuresdkci requested a review from amarzavery June 3, 2019 08:02
@AutorestCI
Copy link

AutorestCI commented Jun 3, 2019 •
edited
Loading

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@AutorestCI
Copy link

AutorestCI commented Jun 3, 2019 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#4029

@AutorestCI AutorestCI mentioned this pull request Jun 3, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Jun 3, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2661

@AutorestCI
Copy link

AutorestCI commented Jun 3, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5066

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 5, 2019 •
edited
Loading

SDK Automation [Logs] (Generated from 1117352)

Pending Python: Azure/azure-sdk-for-python
  • Package generation pending.
Pending Java: Azure/azure-sdk-for-java
  • Package generation pending.
Pending Go: Azure/azure-sdk-for-go
  • Package generation pending.
Pending JavaScript: Azure/azure-sdk-for-js
  • Package generation pending.
Pending Ruby: Azure/azure-sdk-for-ruby
  • Package generation pending.
Pending .NET: Azure/azure-sdk-for-net
  • Package generation pending.

@ravbhatnagar ravbhatnagar added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 11, 2019
@AutorestCI AutorestCI mentioned this pull request Jun 12, 2019
Merged
ravbhatnagar
ravbhatnagar reviewed Jun 14, 2019
View reviewed changes
Copy link
Contributor

@ravbhatnagar ravbhatnagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tenmozes - few comments. please take a look.

...simple/resource-manager/Microsoft.VMwareCloudSimple/stable/2019-04-01/vmwarecloudsimple.json Outdated Show resolved Hide resolved
...simple/resource-manager/Microsoft.VMwareCloudSimple/stable/2019-04-01/vmwarecloudsimple.json Outdated Show resolved Hide resolved
...simple/resource-manager/Microsoft.VMwareCloudSimple/stable/2019-04-01/vmwarecloudsimple.json Show resolved Hide resolved
...simple/resource-manager/Microsoft.VMwareCloudSimple/stable/2019-04-01/vmwarecloudsimple.json Show resolved Hide resolved
...simple/resource-manager/Microsoft.VMwareCloudSimple/stable/2019-04-01/vmwarecloudsimple.json Show resolved Hide resolved
...simple/resource-manager/Microsoft.VMwareCloudSimple/stable/2019-04-01/vmwarecloudsimple.json Show resolved Hide resolved
...simple/resource-manager/Microsoft.VMwareCloudSimple/stable/2019-04-01/vmwarecloudsimple.json Outdated Show resolved Hide resolved
...simple/resource-manager/Microsoft.VMwareCloudSimple/stable/2019-04-01/vmwarecloudsimple.json Show resolved Hide resolved
...simple/resource-manager/Microsoft.VMwareCloudSimple/stable/2019-04-01/vmwarecloudsimple.json Outdated Show resolved Hide resolved
ravbhatnagar
ravbhatnagar reviewed Jun 19, 2019
View reviewed changes
Copy link
Contributor

@ravbhatnagar ravbhatnagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

signing off from ARM side

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 19, 2019
@amarzavery
Copy link
Contributor

@sarangan12 , @shahabhijeet @jhendrixMSFT , @lmazuel, @anuchandy - Please take a look at the readme.md and readme.lang.md files and make sure the settings are correct.

jhendrixMSFT
jhendrixMSFT requested changes Jun 19, 2019
View reviewed changes
Copy link
Member

@jhendrixMSFT jhendrixMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readme.go.md needs fixing

specification/vmwarecloudsimple/resource-manager/readme.go.md Show resolved Hide resolved
@AutorestCI AutorestCI mentioned this pull request Jun 19, 2019
Merged
jhendrixMSFT
jhendrixMSFT approved these changes Jun 19, 2019
View reviewed changes
Copy link
Member

@jhendrixMSFT jhendrixMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readme.go.md looks good

@AutorestCI AutorestCI mentioned this pull request Jun 20, 2019
Closed
tenmozes and others added 17 commits June 20, 2019 22:44
@tenmozes
New Python Language Readme Config File
6fa9eb3
@tenmozes
New C# Language Readme Config File
28fda9b
@tenmozes
New Ruby Language Readme Config File
8b06d54
@tenmozes
New Swagger Spec File
7db9f4b
@tenmozes
New Swagger Example Spec File
898ec21
@tenmozes
[VMwareCloudSimple] initial spec
41f5051
@tenmozes
[VMwareCloudSimple] clean-up examples, spellcheck
753532b
@tenmozes
[VMwareCloudSimple] return 202 for long-running vm stop/start
0f4a3c5
@tenmozes
[VMwareCloudSimple] address PR comments
1fc5d54 
 - change case of paths
 - add readOnly to created property
 - remove 404
 - remove MoveBody model
@tenmozes
update readme.me and readme.typescript.md. Fix output path, add azure…
ec9003e 
…-sdk-for-net
@tenmozes
update readme.go.md
d1d3b09
@tenmozes
update readme.python.md
fba2581
@tenmozes
update readme.ruby.md
e9d8efb
@tenmozes
update readme.csharp.md
b0a61de
@tenmozes
readme.ruby.md wrap namespace with quotes
2cfeb57
@tenmozes
remove x-ms-log-running-operation from get
59efa32
@tenmozes
happy spellchecker
ae6d263
nschonni
nschonni reviewed Jun 20, 2019
View reviewed changes
custom-words.txt Outdated Show resolved Hide resolved
@AutorestCI AutorestCI mentioned this pull request Jun 20, 2019
Merged
@amarzavery amarzavery merged commit bd1689e into Azure:master Jun 20, 2019
@AutorestCI AutorestCI mentioned this pull request Jun 20, 2019
Merged
@tenmozes tenmozes deleted the dev-vmwarecloudsimple-Microsoft.VMwareCloudSimple-2019-04-01 branch June 24, 2019 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravbhatnagar ravbhatnagar ravbhatnagar left review comments

@spigene spigene spigene left review comments

@nschonni nschonni nschonni left review comments

@jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

@amarzavery amarzavery amarzavery approved these changes

@anuchandy anuchandy anuchandy approved these changes

@anthony-c-martin anthony-c-martin Awaiting requested review from anthony-c-martin

Assignees

@amarzavery amarzavery

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.