Add PrivateIPAddressVersion in LoadBalancerFrontendIpConfiguration pr… #6162

jaepark08 · 2019-05-30T18:48:31Z

…operties.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

…operties.

AutorestCI · 2019-05-30T18:49:50Z

Automation for azure-sdk-for-java

Encountered a Subprocess error: (azure-sdk-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmphucz4l3v/rest/specification/network/resource-manager/readme.md', '--perform-load=false', '--swagger-to-sdk', '--output-artifact=configuration.json', '--input-file=foo', '--output-folder=/tmp/tmptgcnhwil']
Finished with return code 7
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Failure:
Error: Unable to start AutoRest Core from /root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core
Error: Unable to start AutoRest Core from /root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core
    at main (/opt/node_modules/autorest/dist/app.js:232:19)
    at <anonymous>

/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/app.js:33
    autorest_core_1.Shutdown();
    ^
ReferenceError: autorest_core_1 is not defined
    at process.on (/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/app.js:33:5)
    at emitOne (events.js:121:20)
    at process.emit (events.js:211:7)
    at process.emit (/node_modules/source-map-support/source-map-support.js:439:21)
fs.js:612
  return binding.close(fd);
                 ^

Error: EBADF: bad file descriptor, close
    at Object.fs.closeSync (fs.js:612:18)
    at StaticVolumeFile.shutdown (/opt/node_modules/autorest/dist/static-loader.js:352:10)
    at StaticFilesystem.shutdown (/opt/node_modules/autorest/dist/static-loader.js:406:17)
    at process.exit.n [as exit] (/opt/node_modules/autorest/dist/static-loader.js:169:11)
    at printErrorAndExit (/node_modules/source-map-support/source-map-support.js:423:11)
    at process.emit (/node_modules/source-map-support/source-map-support.js:435:16)
    at process._fatalException (bootstrap_node.js:391:26)

AutorestCI · 2019-05-30T18:50:18Z

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmpbvfm1yny/rest/specification/network/resource-manager/readme.md', '--keep-version-file', '--multiapi', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmpbvfm1yny/sdk/sdk', '[email protected]/[email protected]', '--version=preview']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4377)
   Loading AutoRest extension '@microsoft.azure/autorest.python' (4.0.70->4.0.70)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Processing batch task - {"tag":"package-2019-04"} .

<--- Last few GCs --->

[29807:0x2b6fc70]    64954 ms: Mark-sweep 1380.4 (1425.0) -> 1380.0 (1425.0) MB, 1047.1 / 0.0 ms  (average mu = 0.090, current mu = 0.003) allocation failure scavenge might not succeed
[29807:0x2b6fc70]    66192 ms: Mark-sweep 1380.9 (1425.0) -> 1380.5 (1425.5) MB, 1235.0 / 0.0 ms  (average mu = 0.048, current mu = 0.003) allocation failure scavenge might not succeed


<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x014cf5c1e6e9 <JSObject>
    0: builtin exit frame: stringify(this=0x014cf5c11a21 <Object map = 0x36c181e842a9>,0x24d3ae4826f1 <undefined>,0x24d3ae4826f1 <undefined>,0x1788a084b1c1 <JSArray[7]>,0x014cf5c11a21 <Object map = 0x36c181e842a9>)

    1: arguments adaptor frame: 1->3
    2: IdentitySourceMapping [0x1f90f5e76119] [/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-cor...

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
 1: 0x8dc510 node::Abort() [node]
 2: 0x8dc55c  [node]
 3: 0xad9b5e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [node]
 4: 0xad9d94 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [node]
 5: 0xec7bf2  [node]
 6: 0xec7cf8 v8::internal::Heap::CheckIneffectiveMarkCompact(unsigned long, double) [node]
 7: 0xed3dd2 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [node]
 8: 0xed4704 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [node]
 9: 0xed7371 v8::internal::Heap::AllocateRawWithRetryOrFail(int, v8::internal::AllocationSpace, v8::internal::AllocationAlignment) [node]
10: 0xe9f5a6  [node]
11: 0xea26d2 v8::internal::Factory::NewConsString(v8::internal::Handle<v8::internal::String>, v8::internal::Handle<v8::internal::String>, int, bool) [node]
12: 0xea93e8 v8::internal::Factory::NewConsString(v8::internal::Handle<v8::internal::String>, v8::internal::Handle<v8::internal::String>) [node]
13: 0x11d6bd0 v8::internal::IncrementalStringBuilder::Finish() [node]
14: 0xfa1779 v8::internal::JsonStringifier::Stringify(v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>) [node]
15: 0xba9121 v8::internal::Builtin_JsonStringify(int, v8::internal::Object**, v8::internal::Isolate*) [node]
16: 0xf0a2515bf7d

AutorestCI · 2019-05-30T18:50:44Z

Automation for azure-sdk-for-go

Encountered a Subprocess error: (azure-sdk-for-go)

Command: ['/usr/local/bin/autorest', '/tmp/tmp7fwakhga/rest/specification/network/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmp7fwakhga/src/github.com/Azure/azure-sdk-for-go', '--multiapi', '--preview-chk', '[email protected]/autorest.go@~2.1.133', '--use-onever', '--verbose']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4302)
   Including configuration file 'file:///tmp/tmp7fwakhga/rest/specification/network/resource-manager/readme.go.md'
   Loading AutoRest extension '@microsoft.azure/autorest.go' (~2.1.133->2.1.133)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2019-02"} .
   Including configuration file 'file:///tmp/tmp7fwakhga/rest/specification/network/resource-manager/readme.go.md'

<--- Last few GCs --->

[32748:0x30f58c0]    98980 ms: Mark-sweep 1387.0 (1472.9) -> 1386.9 (1474.4) MB, 1632.9 / 0.0 ms  allocation failure GC in old space requested
[32748:0x30f58c0]   100719 ms: Mark-sweep 1386.9 (1474.4) -> 1386.9 (1436.9) MB, 1738.4 / 0.0 ms  last resort GC in old space requested
[32748:0x30f58c0]   102352 ms: Mark-sweep 1386.9 (1436.9) -> 1386.9 (1434.4) MB, 1633.1 / 0.0 ms  last resort GC in old space requested


<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x187a6f9a5879 <JSObject>
    1: set [native weak-collection.js:~27] [pc=0xc7772f9a849](this=0x296dce002201 <JSWeakMap>,key=0x2f1ce98fa659 <Object map = 0x3469aa90a9c9>,value=0x6e399270979 <String[6]: String>)
    2: /* anonymous */(aka /* anonymous */) [/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/lib/ref/yaml.js:~101] [pc=0xc7773009e39](this=0x11b391c822d1 <un...

FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
 1: node::Abort() [node]
 2: 0x8cbf4c [node]
 3: v8::Utils::ReportOOMFailure(char const*, bool) [node]
 4: v8::internal::V8::FatalProcessOutOfMemory(char const*, bool) [node]
 5: v8::internal::Factory::NewFixedArray(int, v8::internal::PretenureFlag) [node]
 6: v8::internal::HashTable<v8::internal::ObjectHashTable, v8::internal::ObjectHashTableShape>::NewInternal(v8::internal::Isolate*, int, v8::internal::PretenureFlag) [node]
 7: v8::internal::HashTable<v8::internal::ObjectHashTable, v8::internal::ObjectHashTableShape>::New(v8::internal::Isolate*, int, v8::internal::PretenureFlag, v8::internal::MinimumCapacity) [node]
 8: v8::internal::HashTable<v8::internal::ObjectHashTable, v8::internal::ObjectHashTableShape>::EnsureCapacity(v8::internal::Handle<v8::internal::ObjectHashTable>, int, v8::internal::PretenureFlag) [node]
 9: v8::internal::ObjectHashTable::Put(v8::internal::Handle<v8::internal::ObjectHashTable>, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int) [node]
10: v8::internal::JSWeakCollection::Set(v8::internal::Handle<v8::internal::JSWeakCollection>, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int) [node]
11: v8::internal::Runtime_WeakCollectionSet(int, v8::internal::Object**, v8::internal::Isolate*) [node]
12: 0xc7772c842fd

AutorestCI · 2019-05-30T18:51:53Z

Automation for azure-sdk-for-js

Encountered a Subprocess error: (azure-sdk-for-js)

Command: ['/usr/local/bin/autorest', '/tmp/tmpn20aa_e6/rest/specification/network/resource-manager/readme.md', '--license-header=MICROSOFT_MIT_NO_VERSION', '--typescript', '--typescript-sdks-folder=/tmp/tmpn20aa_e6/azure-sdk-for-js', '[email protected]/[email protected]']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4299)
   Loading AutoRest extension '@microsoft.azure/autorest.typescript' (4.0.0->4.0.0)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.51->2.3.51)

<--- Last few GCs --->

[25488:0x39d3860]   140652 ms: Mark-sweep 1396.4 (1479.1) -> 1396.4 (1479.6) MB, 1894.7 / 0.1 ms  allocation failure GC in old space requested
[25488:0x39d3860]   142337 ms: Mark-sweep 1396.4 (1479.6) -> 1396.4 (1441.6) MB, 1684.5 / 0.0 ms  last resort GC in old space requested
[25488:0x39d3860]   143957 ms: Mark-sweep 1396.4 (1441.6) -> 1396.4 (1441.1) MB, 1618.9 / 0.0 ms  last resort GC in old space requested


<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x3f4c24fa5879 <JSObject>
    1: readLineBreak(aka readLineBreak) [/node_modules/yaml-ast-parser/dist/src/loader.js:~300] [pc=0x2ecef97acdc2](this=0xf19c3f822d1 <undefined>,state=0x3d785b1022a9 <State map = 0x3ee106b396d1>)
    2: readFlowCollection(aka readFlowCollection) [/node_modules/yaml-ast-parser/dist/src/loader.js:~596] [pc=0x2ecef97b31a0](this=0xf19c3f822d1 <undefined>,state=0x3d785b1022a9 <State map = 0x3ee106b...

FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
 1: node::Abort() [node]
 2: 0x8cbf4c [node]
 3: v8::Utils::ReportOOMFailure(char const*, bool) [node]
 4: v8::internal::V8::FatalProcessOutOfMemory(char const*, bool) [node]
 5: v8::internal::Factory::NewUninitializedFixedArray(int) [node]
 6: 0xd7fc13 [node]
 7: v8::internal::Runtime_GrowArrayElements(int, v8::internal::Object**, v8::internal::Isolate*) [node]
 8: 0x2ecef93842fd

AutorestCI · 2019-05-30T18:55:52Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

azuresdkci · 2019-05-30T19:05:39Z

Can one of the admins verify this patch?

specification/network/resource-manager/Microsoft.Network/stable/2019-04-01/loadBalancer.json

EvgenyAgafonchikov · 2019-06-03T10:22:09Z

Fixed examples. It looks like the only failed job is SpellCheck (suppressions are not in sync with master)

openapi-sdkautomation · 2019-06-06T17:35:17Z

SDK Automation [Logs] (Generated from 422574e)

Python: Azure/azure-sdk-for-python

Package generation pending.

Java: Azure/azure-sdk-for-java

Package generation pending.

Go: Azure/azure-sdk-for-go

Package generation pending.

JavaScript: Azure/azure-sdk-for-js

Package generation pending.

Ruby: Azure/azure-sdk-for-ruby

Package generation pending.

Add PrivateIPAddressVersion in LoadBalancerFrontendIpConfiguration pr…

3519560

…operties.

jaepark08 requested a review from MikhailTryakhov as a code owner May 30, 2019 18:48

azuresdkci assigned sergey-shandar May 30, 2019

azuresdkci requested a review from sergey-shandar May 30, 2019 18:49

anton-evseev suggested changes May 31, 2019

View reviewed changes

specification/network/resource-manager/Microsoft.Network/stable/2019-04-01/loadBalancer.json Outdated Show resolved Hide resolved

Fixed LB examples

718aafd

jaepark08 added 2 commits June 3, 2019 10:16

Remove API version number in privateIPAddressVersion description.

c9ab1d6

Add privateIPAddressVersion in LoadBalancer examples.

422574e

anton-evseev self-requested a review June 5, 2019 08:52

sergey-shandar approved these changes Jun 5, 2019

View reviewed changes

anton-evseev approved these changes Jun 6, 2019

View reviewed changes

sergey-shandar merged commit de46d03 into Azure:master Jun 6, 2019

anton-evseev mentioned this pull request Jun 18, 2019

Add PrivateIPAddressVersion in LoadBalancerFrontendIpConfiguration. Azure/azure-powershell#9394

Closed

8 tasks

jaepark08 mentioned this pull request Jul 23, 2019

Add PrivateIPAddressVersion in LoadBalancerFrontendIpConfiguration Azure/azure-cli#10018

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add PrivateIPAddressVersion in LoadBalancerFrontendIpConfiguration pr… #6162

Add PrivateIPAddressVersion in LoadBalancerFrontendIpConfiguration pr… #6162

jaepark08 commented May 30, 2019 •

edited

Loading

AutorestCI commented May 30, 2019 •

edited

Loading

AutorestCI commented May 30, 2019 •

edited

Loading

AutorestCI commented May 30, 2019 •

edited

Loading

AutorestCI commented May 30, 2019 •

edited

Loading

AutorestCI commented May 30, 2019 •

edited

Loading

azuresdkci commented May 30, 2019

EvgenyAgafonchikov commented Jun 3, 2019

openapi-sdkautomation bot commented Jun 6, 2019 •

edited

Loading

Add PrivateIPAddressVersion in LoadBalancerFrontendIpConfiguration pr… #6162

Add PrivateIPAddressVersion in LoadBalancerFrontendIpConfiguration pr… #6162

Conversation

jaepark08 commented May 30, 2019 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

AutorestCI commented May 30, 2019 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented May 30, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented May 30, 2019 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented May 30, 2019 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented May 30, 2019 • edited Loading

Automation for azure-sdk-for-ruby

azuresdkci commented May 30, 2019

EvgenyAgafonchikov commented Jun 3, 2019

openapi-sdkautomation bot commented Jun 6, 2019 • edited Loading

SDK Automation [Logs] (Generated from 422574e)

jaepark08 commented May 30, 2019 •

edited

Loading

AutorestCI commented May 30, 2019 •

edited

Loading

AutorestCI commented May 30, 2019 •

edited

Loading

AutorestCI commented May 30, 2019 •

edited

Loading

AutorestCI commented May 30, 2019 •

edited

Loading

AutorestCI commented May 30, 2019 •

edited

Loading

openapi-sdkautomation bot commented Jun 6, 2019 •

edited

Loading