Fix long-running operations for VnetGw, NetworkProfile; Fix examples #6159

EvgenyAgafonchikov · 2019-05-30T09:28:03Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

AutorestCI · 2019-05-30T09:28:07Z

Automation for azure-sdk-for-go

Encountered a Subprocess error: (azure-sdk-for-go)

Command: ['/usr/local/bin/autorest', '/tmp/tmpexw7bboq/rest/specification/network/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmpexw7bboq/src/github.com/Azure/azure-sdk-for-go', '--multiapi', '--preview-chk', '[email protected]/autorest.go@~2.1.133', '--use-onever', '--verbose']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4302)
   Including configuration file 'file:///tmp/tmpexw7bboq/rest/specification/network/resource-manager/readme.go.md'
   Loading AutoRest extension '@microsoft.azure/autorest.go' (~2.1.133->2.1.133)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2019-02"} .
   Including configuration file 'file:///tmp/tmpexw7bboq/rest/specification/network/resource-manager/readme.go.md'

<--- Last few GCs --->

[15288:0x2a5f8c0]    93909 ms: Mark-sweep 1386.1 (1472.4) -> 1386.0 (1474.9) MB, 1600.9 / 0.0 ms  allocation failure GC in old space requested
[15288:0x2a5f8c0]    95547 ms: Mark-sweep 1386.0 (1474.9) -> 1385.9 (1436.4) MB, 1637.7 / 0.0 ms  last resort GC in old space requested
[15288:0x2a5f8c0]    97126 ms: Mark-sweep 1385.9 (1436.4) -> 1385.9 (1433.9) MB, 1578.6 / 0.0 ms  last resort GC in old space requested


<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x19e56c625879 <JSObject>
    1: set [native weak-collection.js:~27] [pc=0x16e5f33fdc09](this=0x3f3c4ef06fe9 <JSWeakMap>,key=0x35cbb41a18a1 <Object map = 0x2b7ec754c659>,value=0xa2987a6539 <JSProxy>)
    2: /* anonymous */(aka /* anonymous */) [/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/lib/ref/yaml.js:~104] [pc=0x16e5f33fc24d](this=0x17db8d0022d1 <undefined>,...

FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
 1: node::Abort() [node]
 2: 0x8cbf4c [node]
 3: v8::Utils::ReportOOMFailure(char const*, bool) [node]
 4: v8::internal::V8::FatalProcessOutOfMemory(char const*, bool) [node]
 5: v8::internal::Factory::NewFixedArray(int, v8::internal::PretenureFlag) [node]
 6: v8::internal::HashTable<v8::internal::ObjectHashTable, v8::internal::ObjectHashTableShape>::NewInternal(v8::internal::Isolate*, int, v8::internal::PretenureFlag) [node]
 7: v8::internal::HashTable<v8::internal::ObjectHashTable, v8::internal::ObjectHashTableShape>::New(v8::internal::Isolate*, int, v8::internal::PretenureFlag, v8::internal::MinimumCapacity) [node]
 8: v8::internal::HashTable<v8::internal::ObjectHashTable, v8::internal::ObjectHashTableShape>::EnsureCapacity(v8::internal::Handle<v8::internal::ObjectHashTable>, int, v8::internal::PretenureFlag) [node]
 9: v8::internal::ObjectHashTable::Put(v8::internal::Handle<v8::internal::ObjectHashTable>, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int) [node]
10: v8::internal::JSWeakCollection::Set(v8::internal::Handle<v8::internal::JSWeakCollection>, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int) [node]
11: v8::internal::Runtime_WeakCollectionSet(int, v8::internal::Object**, v8::internal::Isolate*) [node]
12: 0x16e5f32042fd

AutorestCI · 2019-05-30T09:29:23Z

Automation for azure-sdk-for-java

Encountered a Subprocess error: (azure-sdk-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmpts2vy6v_/rest/specification/network/resource-manager/readme.md', '--perform-load=false', '--swagger-to-sdk', '--output-artifact=configuration.json', '--input-file=foo', '--output-folder=/tmp/tmpwvgfv6vs']
Finished with return code 7
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Failure:
Error: Unable to start AutoRest Core from /root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core
Error: Unable to start AutoRest Core from /root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core
    at main (/opt/node_modules/autorest/dist/app.js:232:19)
    at <anonymous>

/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/app.js:33
    autorest_core_1.Shutdown();
    ^
ReferenceError: autorest_core_1 is not defined
    at process.on (/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/app.js:33:5)
    at emitOne (events.js:121:20)
    at process.emit (events.js:211:7)
    at process.emit (/node_modules/source-map-support/source-map-support.js:439:21)
fs.js:612
  return binding.close(fd);
                 ^

Error: EBADF: bad file descriptor, close
    at Object.fs.closeSync (fs.js:612:18)
    at StaticVolumeFile.shutdown (/opt/node_modules/autorest/dist/static-loader.js:352:10)
    at StaticFilesystem.shutdown (/opt/node_modules/autorest/dist/static-loader.js:406:17)
    at process.exit.n [as exit] (/opt/node_modules/autorest/dist/static-loader.js:169:11)
    at printErrorAndExit (/node_modules/source-map-support/source-map-support.js:423:11)
    at process.emit (/node_modules/source-map-support/source-map-support.js:435:16)
    at process._fatalException (bootstrap_node.js:391:26)

AutorestCI · 2019-05-30T09:29:45Z

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmpzi4gqdtw/rest/specification/network/resource-manager/readme.md', '--keep-version-file', '--multiapi', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmpzi4gqdtw/sdk/sdk', '[email protected]/[email protected]', '--version=preview']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4383)
   Loading AutoRest extension '@microsoft.azure/autorest.python' (4.0.70->4.0.70)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Processing batch task - {"tag":"package-2019-04"} .

<--- Last few GCs --->

[29255:0x279ec70]    64505 ms: Mark-sweep 1336.1 (1424.6) -> 1335.7 (1425.1) MB, 1194.2 / 0.0 ms  (average mu = 0.135, current mu = 0.023) allocation failure scavenge might not succeed
[29255:0x279ec70]    65719 ms: Mark-sweep 1336.6 (1425.1) -> 1336.2 (1425.6) MB, 1211.2 / 0.0 ms  (average mu = 0.072, current mu = 0.002) allocation failure scavenge might not succeed


<--- JS stacktrace --->

==== JS stack trace =========================================

    0: ExitFrame [pc: 0x2cd6b98dbe1d]
Security context: 0x2b4e5671e6e9 <JSObject>
    1: Descendants [0x317b97b425b1] [/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/lib/ref/yaml.js:~29] [pc=0x2cd6b9e2ae4e](this=0x0466ca08a859 <Object map = 0x27d18f8b4df1>,/* anonymous */=0x0518aa782801 <the_hole>,/* anonymous */=0x0518aa782801 <the_hole>,/* anonymous */=0x0518aa782801 <the_hole>)
...

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
 1: 0x8dc510 node::Abort() [node]
 2: 0x8dc55c  [node]
 3: 0xad9b5e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [node]
 4: 0xad9d94 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [node]
 5: 0xec7bf2  [node]
 6: 0xec7cf8 v8::internal::Heap::CheckIneffectiveMarkCompact(unsigned long, double) [node]
 7: 0xed3dd2 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [node]
 8: 0xed4704 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [node]
 9: 0xed7371 v8::internal::Heap::AllocateRawWithRetryOrFail(int, v8::internal::AllocationSpace, v8::internal::AllocationAlignment) [node]
10: 0xea07f4 v8::internal::Factory::NewFillerObject(int, bool, v8::internal::AllocationSpace) [node]
11: 0x114018e v8::internal::Runtime_AllocateInNewSpace(int, v8::internal::Object**, v8::internal::Isolate*) [node]
12: 0x2cd6b98dbe1d

azuresdkci · 2019-05-30T09:30:47Z

Can one of the admins verify this patch?

AutorestCI · 2019-05-30T09:31:25Z

Automation for azure-sdk-for-js

Encountered a Subprocess error: (azure-sdk-for-js)

Command: ['/usr/local/bin/autorest', '/tmp/tmphc9j9twz/rest/specification/network/resource-manager/readme.md', '--license-header=MICROSOFT_MIT_NO_VERSION', '--typescript', '--typescript-sdks-folder=/tmp/tmphc9j9twz/azure-sdk-for-js', '[email protected]/[email protected]']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4299)
   Loading AutoRest extension '@microsoft.azure/autorest.typescript' (4.0.0->4.0.0)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.51->2.3.51)

<--- Last few GCs --->

[19224:0x2969860]   127449 ms: Mark-sweep 1396.3 (1477.6) -> 1396.2 (1478.1) MB, 1836.7 / 0.0 ms  allocation failure GC in old space requested
[19224:0x2969860]   129099 ms: Mark-sweep 1396.2 (1478.1) -> 1396.2 (1440.6) MB, 1648.9 / 0.0 ms  last resort GC in old space requested
[19224:0x2969860]   130686 ms: Mark-sweep 1396.2 (1440.6) -> 1396.2 (1440.6) MB, 1587.4 / 0.0 ms  last resort GC in old space requested


<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x2f9aff4a5879 <JSObject>
    1: readLineBreak(aka readLineBreak) [/node_modules/yaml-ast-parser/dist/src/loader.js:~300] [pc=0x116b982a0622](this=0x1192832022d1 <undefined>,state=0x2ff688e822a9 <State map = 0x1bda1bb56e1>)
    2: readFlowCollection(aka readFlowCollection) [/node_modules/yaml-ast-parser/dist/src/loader.js:~596] [pc=0x116b9830b760](this=0x1192832022d1 <undefined>,state=0x2ff688e822a9 <State map = 0x1bda1b...

FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
 1: node::Abort() [node]
 2: 0x8cbf4c [node]
 3: v8::Utils::ReportOOMFailure(char const*, bool) [node]
 4: v8::internal::V8::FatalProcessOutOfMemory(char const*, bool) [node]
 5: v8::internal::Factory::NewUninitializedFixedArray(int) [node]
 6: 0xd7fc13 [node]
 7: v8::internal::Runtime_GrowArrayElements(int, v8::internal::Object**, v8::internal::Isolate*) [node]
 8: 0x116b97e042fd

AutorestCI · 2019-05-30T09:35:43Z

Automation for azure-sdk-for-ruby

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-ruby#2599

EvgenyAgafonchikov · 2019-05-30T10:49:53Z

Spellchecker failures should be fixed after merging this PR: #6105

dsgouda · 2019-05-30T15:53:35Z

@shahabhijeet I believe you have a better understanding of the x-ms-long-running-options part, would you consider taking this over

sergey-shandar · 2019-06-06T18:37:02Z

...network/resource-manager/Microsoft.Network/stable/2016-12-01/examples/RouteFilterCreate.json

@@ -22,8 +21,7 @@
              ]
            }
          }
-        ],
-        "peerings": []


Potential API breaking change.

sergey-shandar · 2019-06-06T18:42:30Z

@number213 @MikhailTryakhov could you approve this?

KrisBash

LGTM

anton-evseev

LGTM
@EvgenyAgafonchikov please also copy these changes to 2019-06-01 in network-may-release

openapi-sdkautomation · 2019-06-12T23:17:09Z

SDK Automation [Logs] (Generated from 45c8bb7)

Python: Azure/azure-sdk-for-python

Package generation pending.

Java: Azure/azure-sdk-for-java

Package generation pending.

Go: Azure/azure-sdk-for-go

Package generation pending.

JavaScript: Azure/azure-sdk-for-js

Package generation pending.

Ruby: Azure/azure-sdk-for-ruby

Package generation pending.

EvgenyAgafonchikov requested a review from MikhailTryakhov as a code owner May 30, 2019 09:28

azuresdkci assigned dsgouda May 30, 2019

azuresdkci requested a review from dsgouda May 30, 2019 09:29

AutorestCI mentioned this pull request May 30, 2019

[AutoPR network/resource-manager] Fix long-running operations for VnetGw, NetworkProfile Azure/azure-sdk-for-ruby#2519

Closed

EvgenyAgafonchikov changed the title ~~Fix long-running operations for VnetGw, NetworkProfile~~ Fix long-running operations for VnetGw, NetworkProfile; Fix examples May 30, 2019

EvgenyAgafonchikov added 5 commits June 3, 2019 13:13

Added missing long-running values

f0dc518

Fix old examples

90f5b09

Update more long-running for older

1b32237

Updated long-running for networkProfile

cf38a8a

Fix more examples

b092dfb

EvgenyAgafonchikov force-pushed the fix-long branch from 0a8068a to b092dfb Compare June 3, 2019 10:13

EvgenyAgafonchikov added 2 commits June 3, 2019 16:32

Fixed LB examples

8992c0e

Fix examples to pass updated oav validations

45c8bb7

dsgouda added the Reassign label Jun 3, 2019

azuresdkci removed the Reassign label Jun 3, 2019

azuresdkci assigned sergey-shandar and unassigned dsgouda Jun 3, 2019

azuresdkci requested a review from sergey-shandar June 3, 2019 19:26

sergey-shandar reviewed Jun 6, 2019

View reviewed changes

sergey-shandar approved these changes Jun 6, 2019

View reviewed changes

sergey-shandar added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 6, 2019

sergey-shandar requested a review from anton-evseev June 6, 2019 18:43

KrisBash approved these changes Jun 7, 2019

View reviewed changes

KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 7, 2019

anton-evseev approved these changes Jun 7, 2019

View reviewed changes

sergey-shandar merged commit f0f79bf into Azure:master Jun 12, 2019

AutorestCI mentioned this pull request Jun 12, 2019

[AutoPR network/resource-manager] Fix long-running operations for VnetGw, NetworkProfile; Fix examples Azure/azure-sdk-for-ruby#2600

Merged

EvgenyAgafonchikov mentioned this pull request Jun 13, 2019

Extend long-running ops fixes to new API version; Suppression #6336

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix long-running operations for VnetGw, NetworkProfile; Fix examples #6159

Fix long-running operations for VnetGw, NetworkProfile; Fix examples #6159

EvgenyAgafonchikov commented May 30, 2019

AutorestCI commented May 30, 2019 •

edited

Loading

AutorestCI commented May 30, 2019 •

edited

Loading

AutorestCI commented May 30, 2019 •

edited

Loading

azuresdkci commented May 30, 2019

AutorestCI commented May 30, 2019 •

edited

Loading

AutorestCI commented May 30, 2019 •

edited

Loading

EvgenyAgafonchikov commented May 30, 2019

dsgouda commented May 30, 2019

sergey-shandar Jun 6, 2019

sergey-shandar commented Jun 6, 2019

KrisBash left a comment

anton-evseev left a comment

openapi-sdkautomation bot commented Jun 12, 2019 •

edited

Loading

Fix long-running operations for VnetGw, NetworkProfile; Fix examples #6159

Fix long-running operations for VnetGw, NetworkProfile; Fix examples #6159

Conversation

EvgenyAgafonchikov commented May 30, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

AutorestCI commented May 30, 2019 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented May 30, 2019 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented May 30, 2019 • edited Loading

Automation for azure-sdk-for-python

azuresdkci commented May 30, 2019

AutorestCI commented May 30, 2019 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented May 30, 2019 • edited Loading

Automation for azure-sdk-for-ruby

EvgenyAgafonchikov commented May 30, 2019

dsgouda commented May 30, 2019

sergey-shandar Jun 6, 2019

Choose a reason for hiding this comment

sergey-shandar commented Jun 6, 2019

KrisBash left a comment

Choose a reason for hiding this comment

anton-evseev left a comment

Choose a reason for hiding this comment

openapi-sdkautomation bot commented Jun 12, 2019 • edited Loading

SDK Automation [Logs] (Generated from 45c8bb7)

AutorestCI commented May 30, 2019 •

edited

Loading

AutorestCI commented May 30, 2019 •

edited

Loading

AutorestCI commented May 30, 2019 •

edited

Loading

AutorestCI commented May 30, 2019 •

edited

Loading

AutorestCI commented May 30, 2019 •

edited

Loading

openapi-sdkautomation bot commented Jun 12, 2019 •

edited

Loading