Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.Media to add version preview/2019-05-01-preview and stable/2018-07-01 #6147

Merged
merged 22 commits into from
Jun 14, 2019
Merged

[Hub Generated] Review request for Microsoft.Media to add version preview/2019-05-01-preview and stable/2018-07-01 #6147

merged 22 commits into from
Jun 14, 2019

Conversation

BrianBlum
Copy link

@BrianBlum BrianBlum commented May 29, 2019

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

@AutorestCI
Copy link

AutorestCI commented May 29, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5720

@AutorestCI
Copy link

AutorestCI commented May 29, 2019

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#3807

@AutorestCI
Copy link

AutorestCI commented May 29, 2019

Automation for azure-sdk-for-java

Encountered a Subprocess error: (azure-sdk-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmpajbnvp4t/rest/specification/mediaservices/resource-manager/readme.md', '--perform-load=false', '--swagger-to-sdk', '--output-artifact=configuration.json', '--input-file=foo', '--output-folder=/tmp/tmpofene7e6']
Finished with return code 7
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Failure:
Error: Unable to start AutoRest Core from /root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core
Error: Unable to start AutoRest Core from /root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core
    at main (/opt/node_modules/autorest/dist/app.js:232:19)
    at <anonymous>

/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/app.js:33
    autorest_core_1.Shutdown();
    ^
ReferenceError: autorest_core_1 is not defined
    at process.on (/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/app.js:33:5)
    at emitOne (events.js:121:20)
    at process.emit (events.js:211:7)
    at process.emit (/node_modules/source-map-support/source-map-support.js:439:21)
fs.js:612
  return binding.close(fd);
                 ^

Error: EBADF: bad file descriptor, close
    at Object.fs.closeSync (fs.js:612:18)
    at StaticVolumeFile.shutdown (/opt/node_modules/autorest/dist/static-loader.js:352:10)
    at StaticFilesystem.shutdown (/opt/node_modules/autorest/dist/static-loader.js:406:17)
    at process.exit.n [as exit] (/opt/node_modules/autorest/dist/static-loader.js:169:11)
    at printErrorAndExit (/node_modules/source-map-support/source-map-support.js:423:11)
    at process.emit (/node_modules/source-map-support/source-map-support.js:435:16)
    at process._fatalException (bootstrap_node.js:391:26)

@AutorestCI
Copy link

AutorestCI commented May 29, 2019

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2620

@AutorestCI
Copy link

AutorestCI commented May 29, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4894

@BrianBlum
Copy link
Author

Will review the issues with the examples in subsequent PRs

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

Copy link
Member

@tjprescott tjprescott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No model or semantic validation errors introduced by this change. The linter could not run.

@tjprescott
Copy link
Member

Can't merge this due to the failing checks.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 4, 2019

SDK Automation [Logs] (Generated from 8e92338)

In-Progress Python: Azure/azure-sdk-for-python [Logs]
  • Package generation in progress.
In-Progress Java: Azure/azure-sdk-for-java [Logs]
  • Package generation in progress.
Pending Go: Azure/azure-sdk-for-go
  • Package generation pending.
Pending JavaScript: Azure/azure-sdk-for-js
  • Package generation pending.
Pending Ruby: Azure/azure-sdk-for-ruby
  • Package generation pending.

@BrianBlum
Copy link
Author

@AutorestCI the failure in the first check is a exception thrown by the diff tool. Is there anything I can do to resolve that?
Thanks

@AutorestCI
Copy link

I didn't understand your command:

the failure in the first check is a exception thrown by the diff tool. Is there anything I can do to resolve that?

in this context, sorry :(
This is what I can do:

  • rebuild
  • regenerate
  • help : this help message

5 similar comments
@AutorestCI
Copy link

I didn't understand your command:

the failure in the first check is a exception thrown by the diff tool. Is there anything I can do to resolve that?

in this context, sorry :(
This is what I can do:

  • rebuild
  • regenerate
  • help : this help message

@AutorestCI
Copy link

I didn't understand your command:

the failure in the first check is a exception thrown by the diff tool. Is there anything I can do to resolve that?

in this context, sorry :(
This is what I can do:

  • rebuild
  • regenerate
  • help : this help message

@AutorestCI
Copy link

I didn't understand your command:

the failure in the first check is a exception thrown by the diff tool. Is there anything I can do to resolve that?

in this context, sorry :(
This is what I can do:

  • rebuild
  • regenerate
  • help : this help message

@AutorestCI
Copy link

I didn't understand your command:

the failure in the first check is a exception thrown by the diff tool. Is there anything I can do to resolve that?

in this context, sorry :(
This is what I can do:

  • rebuild
  • regenerate
  • help : this help message

@AutorestCI
Copy link

I didn't understand your command:

the failure in the first check is a exception thrown by the diff tool. Is there anything I can do to resolve that?

in this context, sorry :(
This is what I can do:

  • rebuild
  • regenerate
  • help : this help message

@BrianBlum
Copy link
Author

@tjprescott
Copy link
Member

@BrianBlum I'm not sure. I mentioned your PR in the Swagger reviewers channel to see if someone else has an idea.

@BrianBlum
Copy link
Author

Thanks @tjprescott

@BrianBlum
Copy link
Author

@AutorestCI generate azure-sdk-for-net

@AutorestCI
Copy link

I didn't understand your command:

generate azure-sdk-for-net

in this context, sorry :(
This is what I can do:

  • rebuild
  • regenerate
  • help : this help message

4 similar comments
@AutorestCI
Copy link

I didn't understand your command:

generate azure-sdk-for-net

in this context, sorry :(
This is what I can do:

  • rebuild
  • regenerate
  • help : this help message

@AutorestCI
Copy link

I didn't understand your command:

generate azure-sdk-for-net

in this context, sorry :(
This is what I can do:

  • rebuild
  • regenerate
  • help : this help message

@AutorestCI
Copy link

I didn't understand your command:

generate azure-sdk-for-net

in this context, sorry :(
This is what I can do:

  • rebuild
  • regenerate
  • help : this help message

@AutorestCI
Copy link

I didn't understand your command:

generate azure-sdk-for-net

in this context, sorry :(
This is what I can do:

  • rebuild
  • regenerate
  • help : this help message

@BrianBlum
Copy link
Author

@AutorestCI regenerate azure-sdk-for-net

@BrianBlum
Copy link
Author

@tjprescott I found the bad package tag in the readme.md. And there was a typo in a description that was causing a failure in csharp generation.

@tjprescott tjprescott merged commit 07dbabd into Azure:master Jun 14, 2019
@BrianBlum
Copy link
Author

@tjprescott Thanks Travis.

BrianBlum pushed a commit to BrianBlum/azure-sdk-for-net that referenced this pull request Jul 3, 2019
isra-fel added a commit to Azure/azure-sdk-for-net that referenced this pull request Dec 23, 2019
* Generated with --tag=package-2019-05-preview to get Live Transcript
Specs commit Azure/azure-rest-api-specs#6147.
Skip tests that use new version.

* Update the parameters in generate to use LiveTranscription version

* Add metadata files

* Rerecord tests that use 2019-05-01-preview.

Co-authored-by: Yeming Liu <[email protected]>
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
…6147)

* Adding swagger definitions and examples for 2022-05-01-preview API

* fixing avacado errors

* Change the name of the API to listManagedProxyDetails

* Fixing semantic and model validation

* Fixing lintDiff

* Fixing the description

* Adding integer format

* fixing the name to ListManagedProxyDetails

* Adding description for provisioningState parameter

* fixing go-sdk build errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants