Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Batch] Add new data plane verison 2019-06-01 #6113

Merged
merged 2 commits into from
Jun 3, 2019

Conversation

xingwu1
Copy link
Member

@xingwu1 xingwu1 commented May 25, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented May 25, 2019

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented May 25, 2019

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented May 25, 2019

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#3406

@xingwu1
Copy link
Member Author

xingwu1 commented May 25, 2019

@matthchr Please sign it off.

@AutorestCI
Copy link

AutorestCI commented May 25, 2019

Automation for azure-sdk-for-java

Encountered a Subprocess error: (azure-sdk-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmpf324ul03/rest/specification/batch/data-plane/readme.md', '--perform-load=false', '--swagger-to-sdk', '--output-artifact=configuration.json', '--input-file=foo', '--output-folder=/tmp/tmpf4t_ua5_']
Finished with return code 7
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Failure:
Error: Unable to start AutoRest Core from /root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core
Error: Unable to start AutoRest Core from /root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core
    at main (/opt/node_modules/autorest/dist/app.js:232:19)
    at <anonymous>

/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/app.js:33
    autorest_core_1.Shutdown();
    ^
ReferenceError: autorest_core_1 is not defined
    at process.on (/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/app.js:33:5)
    at emitOne (events.js:121:20)
    at process.emit (events.js:211:7)
    at process.emit (/node_modules/source-map-support/source-map-support.js:439:21)
fs.js:612
  return binding.close(fd);
                 ^

Error: EBADF: bad file descriptor, close
    at Object.fs.closeSync (fs.js:612:18)
    at StaticVolumeFile.shutdown (/opt/node_modules/autorest/dist/static-loader.js:352:10)
    at StaticFilesystem.shutdown (/opt/node_modules/autorest/dist/static-loader.js:406:17)
    at process.exit.n [as exit] (/opt/node_modules/autorest/dist/static-loader.js:169:11)
    at printErrorAndExit (/node_modules/source-map-support/source-map-support.js:423:11)
    at process.emit (/node_modules/source-map-support/source-map-support.js:435:16)
    at process._fatalException (bootstrap_node.js:391:26)

@AutorestCI
Copy link

AutorestCI commented May 25, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4940

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@xingwu1
Copy link
Member Author

xingwu1 commented May 25, 2019

@sarangan12 I would like to ask for exemption for following error:

lintdiff:

'Property named: \'nodeAgentSKUId\', for definition: \'ImageInformation\' must follow camelCase style. Example: \'nodeAgentSkuId\'.',

We would like to continue to use nodeAgentSKUId since we had old property has same name for same meaning.

cSpell

specification/batch/data-plane/Microsoft.Batch/stable/2019-06-01.9.0/BatchService.json:433:7 - Unknown word (supportedimages)

This word is for url path.

@matthchr
Copy link
Member

This looks good to me

@xingwu1
Copy link
Member Author

xingwu1 commented May 31, 2019

@sarangan12 Hi, Could you review the PR? It has been open for 1 week.

@sarangan12
Copy link
Member

@matthchr
Copy link
Member

matthchr commented Jun 1, 2019

@xingwu1 - can you make the same change with is made in this PR (and/or rebase to master if the PR gets merged): https://github.com/Azure/azure-rest-api-specs/pull/6179/files

@xingwu1
Copy link
Member Author

xingwu1 commented Jun 1, 2019

@xingwu1 Please fix the error reported in https://dev.azure.com/azure-sdk/public/_build/results?buildId=38574&view=logs&jobId=688669d0-441c-57c3-cf6d-f89a22ccfa5d

@sarangan12 if you read my previous comment for exemption for this error.

We had used the exactly same property for other important object

and want to compact with the this property, we don't want to change the case for this property.

@sarangan12 sarangan12 merged commit 47aa664 into Azure:master Jun 3, 2019
@xingwu1 xingwu1 deleted the master1 branch May 20, 2020 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants