Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PUT and PATCH operations for HubVirtualNetworkConnections #5229

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
{
"parameters": {
"connectionName": "connection1",
"virtualHubName": "virtualHub1",
"resourceGroupName": "rg1",
"api-version": "2018-12-01",
"subscriptionId": "subid",
"hubVirtualNetworkConnectionParameters": {
"tags": {
"key1": "value1",
"key2": "value2"
}
}
},
"responses": {
"200": {
"body": [
{
"name": "connection1",
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/virtualHubs/virtualHub1/virtualHubVnetConnections/connection1",
"etag": "w/\\00000000-0000-0000-0000-000000000000\\",
"tags": {
"key1": "value1",
"key2": "value2"
},
"properties": {
"provisioningState": "Succeeded",
"remoteVirtualNetwork": {
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/virtualNetworks/vnet1"
},
"allowHubToRemoteVnetTransit": true,
"allowRemoteVnetToUseHubVnetGateways": false
}
}
]
},
"201": {
"body": [
{
"name": "connection1",
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/virtualHubs/virtualHub1/virtualHubVnetConnections/connection1",
"etag": "w/\\00000000-0000-0000-0000-000000000000\\",
"tags": {
"key1": "value1",
"key2": "value2"
},
"properties": {
"provisioningState": "Succeeded",
"remoteVirtualNetwork": {
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/virtualNetworks/vnet1"
},
"allowHubToRemoteVnetTransit": true,
"allowRemoteVnetToUseHubVnetGateways": false
}
}
]
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@
}
}
},
"paths": {
},
"paths": {},
"definitions": {
"ErrorDetails": {
"properties": {
Expand Down Expand Up @@ -208,6 +207,27 @@
"required": true,
"type": "string",
"description": "Client API version."
},
"ResourceGroupNameParameter": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameter 'resourceGroupName' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension "x-ms-parameter-location": "client". Else, apply the extension "x-ms-parameter-location": "method".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for VirtualHubNameParameter and ConnectionNameParameter.

"name": "resourceGroupName",
"in": "path",
"required": true,
"type": "string",
"description": "The resource group name of the Microsoft Azure resource."
},
"VirtualHubNameParameter": {
"name": "virtualHubName",
"in": "path",
"required": true,
"type": "string",
"description": "The name of the Virtual Hub resource."
},
"ConnectionNameParameter": {
"name": "connectionName",
"in": "path",
"required": true,
"type": "string",
"description": "The name of the connection resource."
}
}
}
}
Loading