Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Review request for Microsoft.CostManagement to add version 2019-03-01-preview #5021

Merged
merged 17 commits into from
Jan 17, 2019
Merged

[Hub Generated] Review request for Microsoft.CostManagement to add version 2019-03-01-preview #5021

merged 17 commits into from
Jan 17, 2019

Conversation

ariehf
Copy link
Contributor

@ariehf ariehf commented Jan 11, 2019 •
edited
Loading

This PR contains the following new resourceTypes for CostManagement:
• cloudConnectors
• externalBillingAccounts
• externalSubscriptions
• getEntities

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@AutorestCI
Copy link

AutorestCI commented Jan 11, 2019 •
edited
Loading

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@AutorestCI
Copy link

AutorestCI commented Jan 11, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2924

@AutorestCI
Copy link

AutorestCI commented Jan 11, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2160

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@azuresdkci azuresdkci requested a review from praries880 January 11, 2019 06:47
@AutorestCI
Copy link

AutorestCI commented Jan 11, 2019 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Jan 11, 2019 •
edited
Loading

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@AutorestCI AutorestCI mentioned this pull request Jan 11, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jan 11, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3866

@mozehgir mozehgir assigned salameer and unassigned praries880 Jan 11, 2019
@mozehgir

This comment has been minimized.

Sign in to view
@mozehgir

This comment has been minimized.

Sign in to view
@praries880 praries880 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 14, 2019
@praries880
Copy link

@ariehf kindly refer to the email response WRT this PR. Kindly fix the build breaks in the PR before we can proceed with the review. I have requested an ARM review as well for the changes.

@ariehf

This comment has been minimized.

Sign in to view
@ariehf ariehf closed this Jan 16, 2019
@ariehf ariehf reopened this Jan 16, 2019
@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@ariehf

This comment has been minimized.

Sign in to view
@ariehf
Copy link
Contributor Author

ariehf commented Jan 16, 2019 •
edited
Loading

The cloudConnectors in this PR is a refactoring of the connectors resource type from 2018-08-01-preview.
The following refactoring was done from the old connectors:
• Rename connectors->cloudConnectors
• Move from subscription level to tenant Level
• Remove subscriptions & resourceGroup
• Remove "location"
• The following within Connector properties:
• Add "defaultManagementGroupId", "subscriptionId", "billingModel", "daysTrialRemaining"
• Rename collection->collectionInfo
• Added collectionInfo/errorInnerMessage
• Rename lastRun to lastChecked
• Add $expand=collectionInfo

KrisBash
KrisBash approved these changes Jan 17, 2019
View reviewed changes
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for the review meeting

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMReviewMeetingRequired WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 17, 2019
This was referenced Jan 17, 2019
Merged
Merged
@praries880 praries880 merged commit b37f7af into Azure:master Jan 17, 2019
nschonni
nschonni reviewed Jan 17, 2019
View reviewed changes
...ent/resource-manager/Microsoft.CostManagement/preview/2019-03-01-preview/costmanagement.json
"tags": [
"Query"
],
"operationId": "Query_UsageByManagmentGroup",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Managment -> Management

...ent/resource-manager/Microsoft.CostManagement/preview/2019-03-01-preview/costmanagement.json
"tags": [
"Forecast"
],
"operationId": "Forecast_UsageByManagmentGroup",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Managment -> Management

TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Feb 6, 2019
@ariehf @AnuTalluri
[Hub Generated] Review request for Microsoft.CostManagement to add ve…
e099b06 
…rsion 2019-03-01-preview (Azure#5021)

* Adds base for updating Microsoft.CostManagement from version preview/2018-12-01-preview to version 2019-03-01-preview

* Updates readme

* Updates API version in new specs and examples

* Add Microsoft.CostManagment/cloudConnectors

* Add Microsoft.CostManagement/AwsConsolidatedAccount and AwsLinkedAccount

* Fix readonly linter check errors

* Improve new parameter descriptions

* ExternalBillingAccounts,ExternalSubscriptions,getEntities

* Fix apiVersion case

* daysTrialRemaining integer

* Add EntityInfo/kind

* es/managementGroupId,cloudConnectors/defaultManagementGroupId

* managementGroupId description

* Remove tags:CloudConnectors,ExternalSubscriptions,ExternalBillingAccount

* Put MG to ES - return 204

* Fix linter errors in examples

* Suppress OperationsAPIImplementation error for Microsoft.Billing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nschonni nschonni nschonni left review comments

@praries880 praries880 praries880 approved these changes

@KrisBash KrisBash KrisBash approved these changes

Assignees

@salameer salameer

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ariehf @AutorestCI @azuresdkci @mozehgir @praries880 @nschonni @KrisBash @salameer