Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generating latest spec #4976

Merged
merged 7 commits into from
Jan 17, 2019
Merged

Generating latest spec #4976

merged 7 commits into from
Jan 17, 2019

Conversation

mehm23
Copy link
Contributor

@mehm23 mehm23 commented Jan 3, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@msftclas
Copy link

msftclas commented Jan 3, 2019 •
edited
Loading

CLA assistant check
All CLA requirements met.

@azuresdkci azuresdkci requested a review from hovsepm January 3, 2019 09:11
@AutorestCI AutorestCI mentioned this pull request Jan 3, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jan 3, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2945

@AutorestCI AutorestCI mentioned this pull request Jan 3, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jan 3, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2161

@AutorestCI
Copy link

AutorestCI commented Jan 3, 2019 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI AutorestCI mentioned this pull request Jan 3, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Jan 3, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Encountered a Subprocess error: (azure-sdk-for-go)

Command: dep ensure
Finished with return code 1
and output:

grouped write of manifest, lock and vendor: error while writing out vendor tree: failed to write dep tree: failed to export google.golang.org/api:
	(1) failed to list versions for https://code.googlesource.com/google-api-go-client: fatal: unable to access 'https://code.googlesource.com/google-api-go-client/': The requested URL returned error: 502
: exit status 128

@AutorestCI AutorestCI mentioned this pull request Jan 3, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jan 3, 2019 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4313

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Jan 3, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jan 3, 2019 •
edited
Loading

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#700

@AutorestCI AutorestCI mentioned this pull request Jan 8, 2019
Closed
@AutorestCI AutorestCI mentioned this pull request Jan 9, 2019
Merged
@hovsepm
Copy link
Contributor

hovsepm commented Jan 9, 2019

@mehm23 please walk over Breaking Changes and Model Validator errors and fix them. Since you are making changes in the stable swagger there should be no breaking changes.

@hovsepm hovsepm removed their assignment Jan 10, 2019
@azuresdkci azuresdkci requested a review from praries880 January 10, 2019 02:04
@mehm23 mehm23 mentioned this pull request Jan 10, 2019
Merged
9 tasks
@praries880
Copy link

@mehm23 have these changes been trough an A/AzureAPI review?

@praries880 praries880 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 11, 2019
KrisBash
KrisBash reviewed Jan 14, 2019
View reviewed changes
...ecoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2016-12-01/bms.json Outdated
@@ -4061,7 +3991,7 @@
}
},
"BEKDetails": {
"description": "BEK is bitlocker encryption key.",
"description": "BEK is bitlocker encrpytion key.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling

KrisBash
KrisBash reviewed Jan 14, 2019
View reviewed changes
...ecoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2016-12-01/bms.json Outdated
@@ -3909,7 +3839,7 @@
"type": "object",
"properties": {
"objectType": {
"description": "This property will be used as the discriminator for deciding the specific types in the polymorphic chain of types.",
"description": "This property will be used as the discriminator for deciding the specific types in the polymorhpic chain of types.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling

...ecoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2016-12-01/bms.json Outdated
@@ -3677,7 +3611,7 @@
"x-ms-discriminator-value": "AzureWorkloadSQLPointInTimeRestoreRequest"
},
"AzureWorkloadSQLRecoveryPoint": {
"description": "SQL specific recovery point, specifically encapsulates full/diff recovery point along with extended info",
"description": "SQL specific recoverypoint, specifcally encaspulates full/diff recoverypoint alongwith extended info",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling and spacing errors

...ecoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2016-12-01/bms.json Outdated
"AzureWorkloadRecoveryPoint": {
"description": "Workload specific recovery point, specifically encapsulates full/diff recovery point",
"description": "Workload specific recoverypoint, specifcally encaspulates full/diff recoverypoint",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spelling "specifically"

...ecoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2016-12-01/bms.json Outdated
@@ -6090,7 +6025,7 @@
"type": "object",
"properties": {
"objectType": {
"description": "This property will be used as the discriminator for deciding the specific types in the polymorphic chain of types.",
"description": "This property will be used as the discriminator for deciding the specific types in the polymorhpic chain of types.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling - "polymorphic" for all cases

...servicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2016-08-10/operations.json Outdated
@@ -120,7 +119,7 @@
"type": "object",
"properties": {
"value": {
"description": "List of available operations.",
"description": "List of available operationss.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check spelling throughout. "operations"

KrisBash
KrisBash suggested changes Jan 14, 2019
View reviewed changes
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to add the "put" api and SAP definitions appear to be ok for ARM. Numerous spelling errors were introduced in these commits and should be corrected for the benefit of documentation quality.

@KrisBash KrisBash added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jan 14, 2019
@praries880
Copy link

@KrisBash Do the latest changes take care of your review comments?

KrisBash
KrisBash approved these changes Jan 17, 2019
View reviewed changes
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@praries880 praries880 added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 17, 2019
@praries880 praries880 merged commit b3b1752 into Azure:master Jan 17, 2019
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Feb 6, 2019
@mehm23 @AnuTalluri
Generating latest spec (Azure#4976)
fe341b8 
* Generating latest spec

* Changing the operationIdin 2016-12-01 bms.json

* Updating operationIdin 2016-12-01 bms.json

* Modifying Readme

* Correcting the spellings

* Spell Check

* Spell check
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
@divyansh3131
Adding enableLogAnalytics in VMResource (#4976)
7975014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrisBash KrisBash KrisBash approved these changes

@hovsepm hovsepm Awaiting requested review from hovsepm

@praries880 praries880 Awaiting requested review from praries880

Assignees

@praries880 praries880

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mehm23 @msftclas @AutorestCI @azuresdkci @hovsepm @praries880 @KrisBash