Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LabServices] Fix typo, remove required from optional param #4797

Merged
merged 1 commit into from
Dec 6, 2018
Merged

[LabServices] Fix typo, remove required from optional param #4797

merged 1 commit into from
Dec 6, 2018

Conversation

ianhays
Copy link

@ianhays ianhays commented Dec 5, 2018

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

This is a simple fix to two issues:

@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@AutorestCI
Copy link

AutorestCI commented Dec 5, 2018

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#710

@AutorestCI
Copy link

AutorestCI commented Dec 5, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3981

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Dec 5, 2018

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2031

@AutorestCI
Copy link

AutorestCI commented Dec 5, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4325

@AutorestCI
Copy link

AutorestCI commented Dec 5, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3643

@AutorestCI
Copy link

AutorestCI commented Dec 5, 2018

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2723

@sarangan12
Copy link
Member

@ianhays This is a potential SDK breaking change. Are you sure about this change? Are you ok with breaking changes in SDK?

@ianhays
Copy link
Author

ianhays commented Dec 6, 2018

@sarangan12 yes and yes to both.

@sarangan12 sarangan12 merged commit ddbabbf into Azure:master Dec 6, 2018
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo personalPerferencesOperationsPayload in labservices/resource-manager/Microsoft.LabServices
5 participants