Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typo: servicebus/resource-manager/Microsoft.ServiceBus #4765

Merged
merged 1 commit into from
Jan 22, 2019
Merged

typo: servicebus/resource-manager/Microsoft.ServiceBus #4765

merged 1 commit into from
Jan 22, 2019

Conversation

nschonni
Copy link
Contributor

@nschonni nschonni commented Dec 4, 2018

  • Porperties -> Properties
  • SKU capitalization
  • reponse -> response
  • authorizatio -> authorization
  • Tpoic -> Topic
  • namespce -> namespace
  • authorizationrule -> authorization rule
  • Autorization -> Authorization
  • Regenrate -> Regenerate
  • Namepsace -> Namespace
  • envokes -> Invokes
  • enties -> entities
  • SqlFilter capitalization
  • Corelation -> Correlation
  • neeeds -> needs
  • deatils -> details
  • acrchive -> archive
  • pairning -> pairing

@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@AutorestCI
Copy link

AutorestCI commented Dec 4, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2175

@AutorestCI
Copy link

AutorestCI commented Dec 4, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3928

@AutorestCI
Copy link

AutorestCI commented Dec 4, 2018 •
edited
Loading

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#765

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Dec 4, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3633

@AutorestCI
Copy link

AutorestCI commented Dec 4, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4530

@azuresdkci azuresdkci requested a review from hovsepm December 4, 2018 08:37
@AutorestCI
Copy link

AutorestCI commented Dec 4, 2018 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2752

This was referenced Dec 4, 2018
Closed
Merged
Closed
Closed
Merged
@hovsepm hovsepm requested review from veronicagg and removed request for hovsepm December 4, 2018 19:35
@hovsepm hovsepm assigned veronicagg and unassigned hovsepm Dec 4, 2018
@hovsepm
Copy link
Contributor

hovsepm commented Dec 4, 2018

reassigning to @veronicagg since I do not have permission to merge "failing" PR. However this PR does not change anything real in the swaggers.

@veronicagg
Copy link
Contributor

@anuchandy any thoughts on why Java SDK generation is failing?

@salameer
Copy link
Member

salameer commented Dec 5, 2018

Hi @nschonni again thank you for all of you contributions !!!

I have a question, Are you running some sort of tool to format and edit Vocab?

@nschonni
Copy link
Contributor Author

nschonni commented Dec 5, 2018

I'm using cSpelling through VSCode. I'll submit a PR to add a CI step after I've gone over the last few APIs since I'm building a dictionary of ignores as I'm going through each API.

@nschonni nschonni force-pushed the typo-servicebus/resource-manager/Microsoft.ServiceBus branch from a191937 to 92aebb8 Compare December 14, 2018 03:42
@nschonni
Copy link
Contributor Author

I rebased since the java issue was fixed in #4626

@AutorestCI AutorestCI mentioned this pull request Dec 14, 2018
Merged
@nschonni
Copy link
Contributor Author

nschonni commented Jan 8, 2019

@hovsepm @veronicagg this isn't failing since the java generation was fixed. Any thing else to change?

@nschonni
typo: servicebus/resource-manager/Microsoft.ServiceBus
3648a17 
- Porperties -> Properties
- SKU capitalization
- reponse -> response
- authorizatio -> authorization
- Tpoic -> Topic
- namespce -> namespace
- authorizationrule -> authorization rule
- Autorization -> Authorization
- Regenrate -> Regenerate
- Namepsace -> Namespace
- envokes -> Invokes
- enties -> entities
- SqlFilter capitalization
- Corelation -> Correlation
- neeeds -> needs
- deatils -> details
- acrchive -> archive
- pairning -> pairing
@nschonni nschonni force-pushed the typo-servicebus/resource-manager/Microsoft.ServiceBus branch from 92aebb8 to 3648a17 Compare January 16, 2019 22:55
@AutorestCI AutorestCI mentioned this pull request Jan 16, 2019
Merged
@AutorestCI AutorestCI mentioned this pull request Jan 16, 2019
Merged
veronicagg
veronicagg approved these changes Jan 22, 2019
View reviewed changes
Copy link
Contributor

@veronicagg veronicagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to merge

@veronicagg veronicagg merged commit 33c4748 into Azure:master Jan 22, 2019
@nschonni nschonni deleted the typo-servicebus/resource-manager/Microsoft.ServiceBus branch January 22, 2019 21:09
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Feb 6, 2019
@nschonni @AnuTalluri
typo: servicebus/resource-manager/Microsoft.ServiceBus (Azure#4765)
419587b 
- Porperties -> Properties
- SKU capitalization
- reponse -> response
- authorizatio -> authorization
- Tpoic -> Topic
- namespce -> namespace
- authorizationrule -> authorization rule
- Autorization -> Authorization
- Regenrate -> Regenerate
- Namepsace -> Namespace
- envokes -> Invokes
- enties -> entities
- SqlFilter capitalization
- Corelation -> Correlation
- neeeds -> needs
- deatils -> details
- acrchive -> archive
- pairning -> pairing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veronicagg veronicagg veronicagg approved these changes

Assignees

@veronicagg veronicagg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nschonni @AutorestCI @azuresdkci @hovsepm @veronicagg @salameer