Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding provisionAfterExtensions property for extension sequencing #4300

Merged
merged 1 commit into from
Oct 22, 2018

Conversation

sirajudeens
Copy link
Contributor

@sirajudeens sirajudeens commented Oct 20, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Oct 20, 2018

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#269

@AutorestCI
Copy link

AutorestCI commented Oct 20, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3668

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Oct 20, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3925

@AutorestCI
Copy link

AutorestCI commented Oct 20, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3099

@lmazuel
Copy link
Member

lmazuel commented Oct 22, 2018

Hi @sirajudeens
Looks good to me, but could you give me more context about this change? Was it forgotten and always here from the beginning? Is this something you added recently to the two latest API version? etc. Because I'm not able to find it in real payload.

Thanks!

FYI @hyonholee

@lmazuel
Copy link
Member

lmazuel commented Oct 22, 2018

Discussed by Skype with @sirajudeens and in my understanding the node was already there, but not declared in both 2018-06-01 and 2018-10-01

@lmazuel lmazuel merged commit 2eb14e6 into Azure:master Oct 22, 2018
lmazuel added a commit that referenced this pull request Oct 22, 2018
lmazuel added a commit that referenced this pull request Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants