-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding version 2018-07-01 for Microsoft.Media #3980
Conversation
Automation for azure-sdk-for-jsNothing to generate for azure-sdk-for-js |
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-rubyThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-nodeThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-javaThe initial PR has been merged into your service PR: |
Can one of the admins verify this patch? |
Both SDK and ARM approval is already received for same changes in the PR |
Please also specify the `--go-sdk-folder=<path to the root directory of your azure-sdk-for-go clone>`. | ||
|
||
``` yaml $(tag) == 'package-2018-07' && $(go) | ||
output-folder: $(go-sdk-folder)/services/preview/mediaservices/mgmt/2018-07-01/media |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you intend to release this as a preview package? All of the swaggers are in the stable directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this should be a stable package. If there is anything I need to do in the md files please let me know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For Go simply remove the preview/
part from the output-folder
. Not sure about the other languages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
@AutorestCI regenerate azure-sdk-for-go |
I had a merge issue with the branch for my previous pull request (#3831). Thus, I am copying my changes from that branch into this fork and submitting a new pull request to just pick up my changes and not the result of the bad merge. My previous pull request was already reviewed before the bad merge and is ready to be merged into master.
Please let me know if you have any questions or concerns.