Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use only PublicIpAddress in Azure Firewall, not both Public and InternalPublic #3743

Merged
merged 4 commits into from
Aug 30, 2018
Merged

Use only PublicIpAddress in Azure Firewall, not both Public and InternalPublic #3743

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3dffb51
Do not confuse users with both InternalPublicIp and PublicIp for the …
Aug 27, 2018
905e723
Update AzureFirewall PUT example
Aug 27, 2018
a877799
This closes #3474
Aug 28, 2018
990371c
Use the correct name for publicIPAddress in AzureFirewall PUT example
Aug 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 8 additions & 12 deletions ...ification/network/resource-manager/Microsoft.Network/stable/2018-08-01/azureFirewall.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,22 +259,18 @@
"definitions":{
"AzureFirewallIPConfigurationPropertiesFormat":{
"properties":{
"privateIPAddress": {
"type": "string",
"description": "The Firewall Internal Load Balancer IP to be used as the next hop in User Defined Routes."
},
"subnet":{
"privateIPAddress": {
"type": "string",
"description": "The Firewall Internal Load Balancer IP to be used as the next hop in User Defined Routes."
},
"subnet":{
"$ref":"./network.json#/definitions/SubResource",
"description":"Reference of the subnet resource. This resource must be named 'AzureFirewallSubnet'."
},
"internalPublicIpAddress":{
"$ref":"./network.json#/definitions/SubResource",
"description":"Reference of the PublicIP resource. This field is a mandatory input."
"publicIPAddress": {
Copy link
Member

@lmazuel lmazuel Aug 28, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You wrote here publicIPAddress, but publicIpAddress in the example. JSON is case-sensitive, please be sure to put EXACTLY what the endpoint is returning.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! I double checked now and it is publicIPAddress.

"$ref": "./network.json#/definitions/SubResource",
"description": "Reference of the PublicIP resource. This field is a mandatory input if subnet is not null."
},
"publicIPAddress": {
"$ref": "./network.json#/definitions/SubResource",
"description": "Reference of the PublicIP resource. This field is populated in the output."
},
"provisioningState":{
"description":"The provisioning state of the resource.",
"$ref":"#/definitions/ProvisioningState"
Expand Down
2 changes: 1 addition & 1 deletion ...twork/resource-manager/Microsoft.Network/stable/2018-08-01/examples/AzureFirewallPut.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"subnet":{
"id":"/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/virtualNetworks/vnet2/subnets/AzureFirewallSubnet"
},
"internalPublicIpAddress":{
"publicIPAddress":{
"id":"/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/publicIPAddresses/pipName"
}
}
Expand Down