Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Twin property to IoTHub's RP TestRouteAPI and TestAllRoutes API. This is an optional parameter to these APIs. #3710

Merged
merged 1 commit into from
Aug 27, 2018

Conversation

ankurkul
Copy link
Contributor

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Aug 23, 2018

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#3206

@AutorestCI
Copy link

AutorestCI commented Aug 23, 2018

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#3408

@ankurkul
Copy link
Contributor Author

Moderators, this is a PR for an upcoming change in IoT Hub's RP's API. The changes are not deployed yet so we would want to hold of completing the PR until the deployment is complete.

Is there a way to do that?

@AutorestCI
Copy link

AutorestCI commented Aug 23, 2018

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1599

@ankurkul ankurkul changed the title Add Twin property to TestRouteAPI and TestAllRoutes API. This is an optional parameter to these APIs. Add Twin property to IoTHub's RP TestRouteAPI and TestAllRoutes API. This is an optional parameter to these APIs. Aug 23, 2018
@AutorestCI
Copy link

AutorestCI commented Aug 23, 2018

Automation for azure-sdk-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-java#2347

@ankurkul
Copy link
Contributor Author

@akumardu Can you review the changes as well?

@AutorestCI
Copy link

AutorestCI commented Aug 23, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2552

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

"properties": {
"tags": {
"description": "Twin Tags",
"type": "object"
Copy link
Contributor

@hovsepm hovsepm Aug 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"type": "object" [](start = 10, length = 16)

why is everything of type object? #Closed

Copy link
Contributor Author

@ankurkul ankurkul Aug 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Twin is a IoTHub primitive that takes form of three properties which can be any valid JSON object. Thats why we have defined in swagger as objects. #Closed

@lmazuel
Copy link
Member

lmazuel commented Aug 27, 2018

@AutorestCI regenerate azure-sdk-for-python

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants