[AKS] regex bug fix for LinuxProfile.AdminUser

[zqingqing1]

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

• The title of the PR is clear and informative.
• There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
• Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
• If applicable, the PR references the bug/issue that it fixes.
• Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

• I have read the contribution guidelines.
• My spec meets the review criteria:
  • The spec conforms to the Swagger 2.0 specification.
  • The spec follows the guidelines described in the Swagger checklist document.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.

[azuresdkci]

Can one of the admins verify this patch?

[AutorestCI]

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3097

[AutorestCI]

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

[AutorestCI]

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

[AutorestCI]

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3304

[AutorestCI]

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

[lmazuel]

Your current input files are:

input-file:
- Microsoft.ContainerService/stable/2017-07-01/containerService.json
- Microsoft.ContainerService/stable/2018-03-31/managedClusters.json
- Microsoft.ContainerService/stable/2017-09-30/location.json

and this PR creates this error:

INFO:swaggertosdk.autorest_tools:Process() cancelled due to exception : '$.definitions.ContainerServiceLinuxProfile.properties.adminUsername.pattern' has incompatible values (---
INFO:swaggertosdk.autorest_tools:'^[a-z][a-z0-9_-]*$'
INFO:swaggertosdk.autorest_tools:, ---
INFO:swaggertosdk.autorest_tools:'^[A-Za-z][-A-Za-z0-9_]*$'
INFO:swaggertosdk.autorest_tools:).

which means to me that containerService or location files defines this same object, and needs to be updated as well, or the model renamed to avoid conflicts.

[lmazuel]

@weinong The Go build is failing because you need to fix Microsoft.ContainerService/stable/2017-08-31/managedClusters.json as well.
SDK now supports multi-api versionning, this means the tag package-2017-09 is still part of the Go release, even if latest is package-2018-03. If think we agree anyway that the fix is relevant in 2017-08-31, and I'm not asking anything wrong.

@marstr This is the limit of shipping composite "package-2018-03" and "package-2017-09" in Go with mixed-up api-version. If tag one contains A and B, and tag two contains B and C, a simple fix in A spread to B and then C if you ship composite tags (FYI @johanste )

[lmazuel]

LGTM

[lmazuel]

@hovsepm I have no concerns anymore with the PR, up to you now. Thanks for tagging me initially :).

[hovsepm]

Thanks for helping @lmazuel .