Expose DMS online migration scenarios for public preview #3567

huang91shu · 2018-08-02T00:56:55Z

This PR contains changes for our public contract to enable the new online migration scenarios as well as updates to our existing scenarios.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

… service

azuresdkci · 2018-08-02T00:56:56Z

Can one of the admins verify this patch?

AutorestCI · 2018-08-02T00:57:50Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3213

AutorestCI · 2018-08-02T00:58:16Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

hitenjava · 2018-08-02T01:02:16Z

...ation/resource-manager/Microsoft.DataMigration/preview/2018-07-15-preview/datamigration.json

@@ -2,7 +2,7 @@
  "swagger": "2.0",
  "info": {
    "title": "Azure Data Migration Service Resource Provider",


Can you update the terminology to 'Database Migration Service' instead of 'Data Migration Service'. The GA swagger already has this.

hitenjava · 2018-08-02T01:03:30Z

...ation/resource-manager/Microsoft.DataMigration/preview/2018-07-15-preview/datamigration.json

@@ -994,6 +1046,52 @@
        }
      }
    },
+    "/subscriptions/{subscriptionId}/resourceGroups/{groupName}/providers/Microsoft.DataMigration/services/{serviceName}/projects/{projectName}/accessArtifacts": {
+      "post": {


Not required for public preview.

hitenjava · 2018-08-02T01:03:51Z

...er/Microsoft.DataMigration/preview/2018-07-15-preview/examples/Projects_AccessArtifacts.json

@@ -0,0 +1,16 @@
+{
+  "parameters": {


This file not required for public preview.

AutorestCI · 2018-08-02T01:15:55Z

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

AutorestCI · 2018-08-02T01:23:54Z

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

AutorestCI · 2018-08-02T01:24:43Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

lmazuel · 2018-08-02T16:09:04Z

specification/datamigration/resource-manager/readme.md

@@ -50,6 +50,39 @@ input-file:
 - Microsoft.DataMigration/stable/2018-04-19/definitions/MigrationValidation.json
 ```

+### Tag: package-2018-07-15-preview


You probably want to change line 31 as well, to put package-2018-07-15-preview as the default tag to generate

… generated

swjain23 · 2018-08-02T22:00:55Z

.../resource-manager/Microsoft.DataMigration/preview/2018-07-15-preview/definitions/Common.json

+    "MySqlConnectionInfo": {
+      "x-ms-discriminator-value": "MySqlConnectionInfo",
+      "type": "object",
+      "description": "Information for connecting to MySQL source",


Should this be MySQL server? As it is used for both source and target

swjain23 · 2018-08-02T22:02:41Z

.../resource-manager/Microsoft.DataMigration/preview/2018-07-15-preview/definitions/Common.json

+        "MigrationFromSqlServerToAzureDB",
+        "MigrationFromSqlServerToAzureMI",
+        "MigrationFromMySQLToSQL",
+        "MigrationFromMySQLToAzureDB",


Is "MigrationFromMySQLToAzureDB" supported? As in MySqlTargetPlatform we only have SqlServer and AzureDbForMySQL

swjain23 · 2018-08-02T22:05:28Z

...ft.DataMigration/preview/2018-07-15-preview/definitions/ConnectToTargetSqlSqlDbSyncTask.json

+      "description": "Input for the task that validates connection to SQL DB and target server requirements",
+      "properties": {
+        "sourceConnectionInfo": {
+          "description": "Connection information for Source SQL Server",


nit: source instead of Source, as below we say target. Both should be consistent

swjain23 · 2018-08-02T22:08:23Z

...Microsoft.DataMigration/preview/2018-07-15-preview/definitions/GetUserTablesSqlSyncTask.json

+          "$ref": "./Common.json#/definitions/SqlConnectionInfo"
+        },
+        "targetConnectionInfo": {
+          "description": "Connection information for SQL Server",


SQL DB instead of SQL Server?

swjain23 · 2018-08-02T22:10:46Z

...ataMigration/preview/2018-07-15-preview/definitions/MigrateMySqlAzureDbForMySqlSyncTask.json

+          "description": "Connection information for source MySQL",
+          "$ref": "./Common.json#/definitions/MySqlConnectionInfo"
+        }
+      },


nit: Should the order be sourceConnectionInfo, targetConnectionInfo and then selectedDatabases?

swjain23 · 2018-08-02T22:12:08Z

...ataMigration/preview/2018-07-15-preview/definitions/MigrateMySqlAzureDbForMySqlSyncTask.json

+        "fullLoadEstFinishTime": {
+          "type": "string",
+          "format": "date-time",
+          "description": "Estimate to finish FullLoad",


full load*

that is what we are using everywhere.

swjain23 · 2018-08-02T23:08:19Z

...anager/Microsoft.DataMigration/preview/2018-07-15-preview/examples/Services_CheckStatus.json

          "ConnectToTarget.AzureSqlDbMI",
          "ConnectToTarget.SqlDb",
-          "Migrate.SqlServer.SqlDb",
+          "ConnectToTarget.SqlServer",
+          "DataMigration.RunAssessment",


Isnt DataMigration.RunAssessment a private scenario? I don't think it is exposed.

Also I dont see DataMigration.RunSqlManagedInstanceMigration, DataMigration.SelectTargetServerForSqlManagedInstanceScenario, DataMigration.SelectSourceForSqlManagedInstanceScenario, DataMigration.PrepareSqlManagedInstanceRestore in our AdvisorScenarioConstants.cs

swjain23 · 2018-08-02T23:08:45Z

...anager/Microsoft.DataMigration/preview/2018-07-15-preview/examples/Services_CheckStatus.json

-          "ValidateMigrationInput.SqlServer.AzureSqlDbMI"
+          "Migrate.SqlServer.SqlDb",
+          "DataMigration.PrepareSqlManagedInstanceRestore",
+          "Migrate.SqlServer.SqlServer",


I am not sure if Migrate.SqlServer.SqlServer is public yet. It is still in preview

swjain23

I think it looks good now 👍

hitenjava · 2018-08-03T00:51:44Z

.../resource-manager/Microsoft.DataMigration/preview/2018-07-15-preview/definitions/Common.json

+      "type": "string",
+      "description": "An enumeration of possible target types when migrating from MySQL",
+      "enum": [
+        "SqlServer",


hitenjava · 2018-08-03T00:52:12Z

.../resource-manager/Microsoft.DataMigration/preview/2018-07-15-preview/definitions/Common.json

+        "Default",
+        "MigrationFromSqlServerToAzureDB",
+        "MigrationFromSqlServerToAzureMI",
+        "MigrationFromMySQLToSQL",


Should these be removed? I think the list should be
"Default",
"MigrationFromSqlServerToAzureDB",
"MigrationFromSqlServerToAzureMI",
"MigrationFromMySQLToAzureDBForMySQL"
These are the scenarios we support though I'm not sure what "ServerLevelPermissionsGroup" represents.

hitenjava · 2018-08-03T00:55:06Z

...esource-manager/Microsoft.DataMigration/preview/2018-07-15-preview/definitions/Projects.json

+        }
+      ]
+    },
+    "ProjectArtifactsResponse": {


Remove ProjectArtifactsResponse

hitenjava · 2018-08-03T00:56:13Z

...esource-manager/Microsoft.DataMigration/preview/2018-07-15-preview/definitions/Projects.json

+            "$ref": "#/definitions/DatabaseInfo"
+          }
+        },
+        "provisioningState": {


Shouldn't there be something about online/offline migration in project properties?

Not anymore. Online/Offline is not associated with project but rather activity.

hitenjava · 2018-08-03T00:58:22Z

...ager/Microsoft.DataMigration/preview/2018-07-15-preview/definitions/MigrationValidation.json

+{
+  "swagger": "2.0",
+  "info": {
+    "title": "Azure Data Migration Service Resource Provider",


Search for 'Azure Data Migration Service' and replace with 'Azure Database Migration Service

hitenjava · 2018-08-03T00:59:29Z

...soft.DataMigration/preview/2018-07-15-preview/definitions/GetProjectDetailsMySqlSqlTask.json

@@ -0,0 +1,46 @@
+{


I don't think this file is required. It is used for the private preview MySQL scenario only.

Yeah, the objects here don't look like they are referenced anywhere.

My latest commit should have removed this file from the PR.

hitenjava · 2018-08-03T01:00:55Z

...osoft.DataMigration/preview/2018-07-15-preview/definitions/ConnectToSourceSqlServerTask.json

+          "type": "string",
+          "format": "date-time",
+          "readOnly": true,
+          "description": "UTC Date and time when the AgentJob was last executed."


Minor - Can you replace 'AgentJob' in descriptions with 'Agent Job'. Thanks!

binuj · 2018-08-03T05:19:06Z

...ation/resource-manager/Microsoft.DataMigration/preview/2018-07-15-preview/datamigration.json

+  "info": {
+    "title": "Azure Database Migration Service Resource Provider",
+    "version": "2018-07-15-preview",
+    "description": "The Data Migration Service helps people migrate their data from on-premise database servers to Azure, or from older database software to newer software. The service manages one or more workers that are joined to a customer's virtual network, which is assumed to provide connectivity to their databases. To avoid frequent updates to the resource provider, data migration tasks are implemented by the resource provider in a generic way as task resources, each of which has a task type (which identifies the type of work to run), input, and output. The client is responsible for providing appropriate task type and inputs, which will be passed through unexamined to the machines that implement the functionality, and for understanding the output, which is passed back unexamined to the client.",


Search for 'Data Migration Service' and replace with 'Database Migration Service'. You can do this in VS using replace all and limiting search to folder '...\preview\2018-07-15-preview' and replace all files in this version.

ravbhatnagar · 2018-08-15T07:19:02Z

Has this gone through Azure API review board and ARM API review board? If not, please set something up with armapireview and azureapirbcore

Adding PostgreSql models to swagger

Fix errors for PostgreSql Task file

Update readme.md to fix path for PostgreSql task json

ravbhatnagar · 2018-08-21T22:28:58Z

ping, please set up a meeting as noted in the email.

…re-rest-api-specs into syncpublicpreview

ravbhatnagar · 2018-08-27T23:59:01Z

reviewed in person. Signing off from ARM side.

huang91shu added 2 commits July 31, 2018 18:22

copy 2018-03-31-preview over to new api version; base commit

cad504a

Changes for new API version 2018-07-15-preview for database migration…

df63583

… service

huang91shu requested review from navinnarra, neetusingh-ms, hitenjava, jasmineflorencio, binuj and swjain23 August 2, 2018 00:56

azuresdkci assigned lmazuel Aug 2, 2018

azuresdkci requested a review from lmazuel August 2, 2018 00:57

AutorestCI mentioned this pull request Aug 2, 2018

[AutoPR datamigration/resource-manager] Syncpublicpreview Azure/azure-sdk-for-python#3066

Merged

hitenjava reviewed Aug 2, 2018

View reviewed changes

lmazuel added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 2, 2018

lmazuel requested a review from ravbhatnagar August 2, 2018 16:07

lmazuel reviewed Aug 2, 2018

View reviewed changes

additional removal of non-publicpreview items; update default package…

89c9f8c

… generated

swjain23 reviewed Aug 2, 2018

View reviewed changes

address multiple comments about phrasing and terminology

85b7553

huang91shu changed the title ~~Syncpublicpreview~~ Expose DMS online migration scenarios for public preview Aug 3, 2018

swjain23 approved these changes Aug 3, 2018

View reviewed changes

hitenjava reviewed Aug 3, 2018

View reviewed changes

remove extra unexposed scenario mysql to sql

b671aca

hitenjava reviewed Aug 3, 2018

View reviewed changes

binuj reviewed Aug 3, 2018

View reviewed changes

huang91shu added 2 commits August 3, 2018 16:20

rename data migration to database migration; remove more unused objects

a1391ee

missed a few Data Migration to Database Migration locations

79e04cb

swjain23 added 3 commits August 16, 2018 15:43

Add PostgreSql changes to public preview swagger

5d6c289

Adding PostgreSql models to swagger

Fix errors for PostgreSql Task file

91a7d0c

Fix errors for PostgreSql Task file

Update readme.md to fix path for PostgreSql task json

e09f717

Update readme.md to fix path for PostgreSql task json

huang91shu added 3 commits August 24, 2018 15:58

add migrate schema sqlserver sqldb scenario

15e0f55

Merge branch 'syncpublicpreview' of https://github.com/huang91shu/azu…

17cbeff

…re-rest-api-specs into syncpublicpreview

fix travis CI failures due to style

6f4da7e

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 27, 2018

lmazuel approved these changes Aug 28, 2018

View reviewed changes

lmazuel merged commit ca3a879 into Azure:master Aug 28, 2018

huang91shu mentioned this pull request Aug 30, 2018

Update DataMigration SDK to use newest swagger api version Azure/azure-sdk-for-net#4719

Merged

9 tasks

Expose DMS online migration scenarios for public preview #3567

Expose DMS online migration scenarios for public preview #3567

Conversation

huang91shu commented Aug 2, 2018 • edited Loading

PR information

Quality of Swagger

azuresdkci commented Aug 2, 2018

AutorestCI commented Aug 2, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Aug 2, 2018 • edited Loading

Automation for azure-sdk-for-ruby

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AutorestCI commented Aug 2, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Aug 2, 2018 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Aug 2, 2018 • edited Loading

Automation for azure-sdk-for-java

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

swjain23 Aug 2, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

swjain23 Aug 2, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

swjain23 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ravbhatnagar commented Aug 15, 2018

ravbhatnagar commented Aug 21, 2018

ravbhatnagar commented Aug 27, 2018

huang91shu commented Aug 2, 2018 •

edited

Loading

AutorestCI commented Aug 2, 2018 •

edited

Loading

AutorestCI commented Aug 2, 2018 •

edited

Loading

AutorestCI commented Aug 2, 2018 •

edited

Loading

AutorestCI commented Aug 2, 2018 •

edited

Loading

AutorestCI commented Aug 2, 2018 •

edited

Loading

swjain23 Aug 2, 2018 •

edited

Loading

swjain23 Aug 2, 2018 •

edited

Loading