Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python][recoveryservicesbackup] fix enum name breaking in python SDK with directive #31959

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

msyyc
Copy link
Member

@msyyc msyyc commented Dec 26, 2024

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Click here to open a PR for only SDK configuration.

Copy link

openapi-pipeline-app bot commented Dec 26, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented Dec 26, 2024

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/recoveryservices/armrecoveryservicesbackup There is no API change compared with the previous version
JavaScript @azure/arm-recoveryservicesbackup https://apiview.dev/Assemblies/Review/859c2af295154fe6816f57a966fd8dee?revisionId=86ef282be17b41189321ae86704f63ef
Java azure-resourcemanager-recoveryservicesbackup https://apiview.dev/Assemblies/Review/a4a183e5963645238761f94a38ed47e9?revisionId=de46b63e73bf442ab89c4f3d954e31d4
.Net Azure.ResourceManager.RecoveryServicesBackup https://apiview.dev/Assemblies/Review/2e670a3b8b294fadbf4a793f6c6aaa28?revisionId=4b103f70644e4fcfb21dac23142d0eb7
Python azure-mgmt-recoveryservicesbackup https://apiview.dev/Assemblies/Review/0a14b8362f694541b56cb19ab03710bd?revisionId=7c654187cce340668667cbea3482a638

"modelAsString": false,
"values": [
{
'name': 'CONTINUE_ENUM',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix Azure/azure-sdk-tools#9542 (comment).
After codegen upgrade, there is no additional suffix ENUM added for CONTINUE. However, to keep backward compatibility, we have to add directives to make the enum key name same as before.

@msyyc msyyc added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review PublishToCustomers Acknowledgement the changes will be published to Azure customers. labels Dec 26, 2024
@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test labels Dec 26, 2024
@msyyc msyyc merged commit b4144ee into main Jan 2, 2025
29 checks passed
@msyyc msyyc deleted the python-config-fix branch January 2, 2025 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review PublishToCustomers Acknowledgement the changes will be published to Azure customers. ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test Recovery Services Backup resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants