Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Synapse]Sync IR Features From DataFactory #31774

Merged
merged 5 commits into from
Jan 8, 2025
Merged

[Synapse]Sync IR Features From DataFactory #31774

merged 5 commits into from
Jan 8, 2025

Conversation

Jingshu918
Copy link
Contributor

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

@Jingshu918 Jingshu918 requested a review from wanyang7 as a code owner December 5, 2024 02:53
@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Dec 5, 2024 •
edited
Loading

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Dec 5, 2024 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/synapse/armsynapse https://apiview.dev/Assemblies/Review/4d2f9d0b810141aea0fe7162de842db4?revisionId=da394874677442738cd3624c86ff7168
Java azure-resourcemanager-synapse https://apiview.dev/Assemblies/Review/8493c66ea9d24ed1ba2b539ccfd873c6?revisionId=0b33c14e178743f19913b98994c804d4
JavaScript @azure/arm-synapse https://apiview.dev/Assemblies/Review/522dd0af52c54404a44b82d865de7666?revisionId=b1733c34cbef4fa19858bf01cd95ed30
.Net Azure.ResourceManager.Synapse https://apiview.dev/Assemblies/Review/cab406f69aab4fd78784f5a175047184?revisionId=d69d6f5a4e784b9db07dd3c056f241bf

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.Synapse

@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview NotReadyForARMReview resource-manager VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required labels Dec 5, 2024
This was referenced Dec 5, 2024
Draft
Draft
Draft
Draft
Draft
Draft
@Jingshu918 Jingshu918 added PublishToCustomers Acknowledgement the changes will be published to Azure customers. and removed NotReadyForARMReview labels Dec 5, 2024
@JeffreyRichter JeffreyRichter added the Versioning-Approved-Benign https://github.com/Azure/azure-sdk-tools/issues/6374 label Dec 5, 2024
@Jingshu918
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@AzureRestAPISpecReview AzureRestAPISpecReview added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 15, 2024
ramoka178
ramoka178 reviewed Dec 16, 2024
View reviewed changes
...ynapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/integrationRuntime.json
"format": "int32",
"minimum": 4
},
"timeToLive": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

timeToLive

Does it make sense to have the property as 'timeToLiveInMinutes'?

@ramoka178
Copy link
Contributor

Please do the due diligence of filling in the form at #31774 (comment)

@ramoka178
Copy link
Contributor

Please fix the Required check of LintDiff errors too.

@ramoka178 ramoka178 added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Dec 16, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 16, 2024
@AzureRestAPISpecReview AzureRestAPISpecReview added the ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test label Dec 17, 2024
@Jingshu918 Jingshu918 requested a review from ramoka178 December 17, 2024 01:55
@Jingshu918 Jingshu918 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 17, 2024
rkmanda
rkmanda approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@rkmanda rkmanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rkmanda rkmanda added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Dec 17, 2024
@openapi-pipeline-app openapi-pipeline-app bot added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Dec 17, 2024
@rkmanda rkmanda removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 17, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the no-recent-activity There has been no recent activity on this issue. label Jan 6, 2025
@Jingshu918 Jingshu918 removed the no-recent-activity There has been no recent activity on this issue. label Jan 6, 2025
@tadelesh tadelesh mentioned this pull request Jan 7, 2025
Merged
@tadelesh
Copy link
Member

tadelesh commented Jan 7, 2025

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@tadelesh
Copy link
Member

tadelesh commented Jan 7, 2025

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@tadelesh
Copy link
Member

tadelesh commented Jan 7, 2025

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@Jingshu918
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@Frey-Wang Frey-Wang merged commit 04b59b5 into Azure:main Jan 8, 2025
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkmanda rkmanda rkmanda approved these changes

@wanyang7 wanyang7 Awaiting requested review from wanyang7 wanyang7 is a code owner

@ramoka178 ramoka178 Awaiting requested review from ramoka178

Assignees
No one assigned
Labels
ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review PublishToCustomers Acknowledgement the changes will be published to Azure customers. ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager Synapses Versioning-Approved-Benign https://github.com/Azure/azure-sdk-tools/issues/6374 VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Jingshu918 @azure-sdk @ramoka178 @tadelesh @rkmanda @JeffreyRichter @Frey-Wang @AzureRestAPISpecReview