Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compute] Fix List VM Extension API name, description updates and other fixes. #3152

Merged
merged 2 commits into from
Jun 2, 2018

Conversation

hyonholee
Copy link
Contributor

@hyonholee hyonholee commented May 30, 2018

  • Fix the name of List VM Extension API name, which was set wrong.
  • 2018-06-01 version was missing the previous fixes for the response of POST APIs.
  • Minor description updates.
  • Add VMSS Ip Tag

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@hyonholee hyonholee changed the title Fix List VM Extension API name, description updates and fix for 2018-… [Compute] Fix List VM Extension API name, description updates and other fixes. May 30, 2018
@AutorestCI
Copy link

AutorestCI commented May 30, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2710

@AutorestCI
Copy link

AutorestCI commented May 30, 2018

Automation for azure-libraries-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
AutorestCI/azure-libraries-for-java#2

@AutorestCI
Copy link

AutorestCI commented May 30, 2018

Automation for azure-sdk-for-ruby

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-ruby#1338

@AutorestCI
Copy link

AutorestCI commented May 30, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2487

@AutorestCI
Copy link

AutorestCI commented May 30, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#1951

"description": "OK",
"schema": {
"$ref": "#/definitions/OperationStatusResponse"
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we removing the schema? If this is removed, what will be schema of the response?

Copy link
Contributor Author

@hyonholee hyonholee Jun 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Delete operation, the body of response is empty. So the Swagger spec is wrong, and we get nothing for OperationStatusResponse anyway. So I removed it.

https://github.com/Azure/azure-sdk-for-net/blob/6a493f405a59f7ea4f984143d5afe39ddeb8a8dd/src/SDKs/Compute/Compute.Tests/SessionRecords/Compute.Tests.AvailabilitySetTests/TestOperations.json#L747

@lmazuel
Copy link
Member

lmazuel commented Jun 1, 2018

@AutorestCI regenerate azure-sdk-for-python

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants