Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft.RecoveryServices adding version 2024-09-30-preview (#30405) #31267

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ankur741999
Copy link
Contributor

  • Copy files from stable/2024-04-01

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

  • Update version to preview/2024-09-30-preview

Updated the API version from stable/2024-04-01 to preview/2024-09-30-preview.

  • Added tag for 2024-09-30-preview in readme file

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

* Copy files from stable/2024-04-01

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-09-30-preview

Updated the API version from stable/2024-04-01 to preview/2024-09-30-preview.

* Added tag for 2024-09-30-preview in readme file
Copy link

openapi-pipeline-app bot commented Oct 28, 2024

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ The required check named Swagger PrettierCheck has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

Copy link

openapi-pipeline-app bot commented Oct 28, 2024

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/recoveryservices/armrecoveryservices There is no API change compared with the previous version
JavaScript @azure/arm-recoveryservices https://apiview.dev/Assemblies/Review/3e738940c1d74615b2651ff7b41932b2?revisionId=a0fdc86f3dac46749dfc0809320f7ef5
.Net Azure.ResourceManager.RecoveryServices https://apiview.dev/Assemblies/Review/f173f6364fc040c69cc0fc9dc95599fd?revisionId=9e005a42aa454e93968a4692e9c193a7
Python azure-mgmt-recoveryservices https://apiview.dev/Assemblies/Review/3b90dde0094d442da969d2a4ddbc32c7?revisionId=24ecd8dc4e57429ca6957daa3798c580
Java azure-resourcemanager-recoveryservices https://apiview.dev/Assemblies/Review/a1abc0f600d74935b7603cd6bc16db28?revisionId=9be7868786f94864b88096ffc52c668e

@ankur741999
Copy link
Contributor Author

@@ -28,7 +28,7 @@ These are the global settings for the RecoveryServices API.
title: RecoveryServicesClient
description: Recovery Services Client
openapi-type: arm
tag: package-2024-04
tag: package-preview-2024-09
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not update the default tag to preview

@pcsin
Copy link

pcsin commented Nov 19, 2024

There is no base commit I see to derive reference from. Please consider adding a base commit to ease PR reviews.

@pcsin pcsin added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Nov 19, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 19, 2024
@ankur741999
Copy link
Contributor Author

@pcsin : We already had one PR #30405 which got approved. We want to merge the same to the main branch. Hence we dont have those base commit, please refer to the mentioned PR.

@microsoft-github-policy-service microsoft-github-policy-service bot added the no-recent-activity There has been no recent activity on this issue. label Dec 23, 2024
@hiaga hiaga removed the no-recent-activity There has been no recent activity on this issue. label Dec 27, 2024
Copy link

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

@hiaga hiaga removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jan 3, 2025
@openapi-pipeline-app openapi-pipeline-app bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 3, 2025
added latest stable folder

Co-authored-by: Himanshu Agarwal <[email protected]>
@github-actions github-actions bot added the brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. label Jan 3, 2025
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.RecoveryServices

@dhruvesh dhruvesh added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jan 6, 2025
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 6, 2025
@hiaga hiaga added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Jan 6, 2025
@ankur741999 ankur741999 requested a review from hiaga January 7, 2025 18:32
@viveksheelsingh viveksheelsingh enabled auto-merge (squash) January 8, 2025 05:25
@viveksheelsingh
Copy link

/azp run

Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@viveksheelsingh viveksheelsingh requested a review from hiaga January 8, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review AzCoreIDC brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. new-api-version PublishToCustomers Acknowledgement the changes will be published to Azure customers. ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test RecoveryServices resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants