Updating namespace names as per the review #31206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsomeshekar
requested review from
msyyc,
tadelesh,
jsntcy and
qiaozha
as code owners
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
AzureRestAPISpecReview
added
ARMReview
ReadyForApiTest
This was referenced Oct 24, 2024
bsomeshekar
added
the
PublishToCustomers
This was referenced Oct 24, 2024
bsomeshekar
removed
the
WaitForARMFeedback
AzureRestAPISpecReview
added
TypeSpec
…eshekar/azure-rest-api-specs into basavaraj-edgesites-updatingsdkname
ramoka178
added
the
ARMSignedOff
openapi-pipeline-app
bot
removed
the
WaitForARMFeedback
msyyc
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
Approve for Python and @bsomeshekar you also need approval from other language owners.
…eshekar/azure-rest-api-specs into basavaraj-edgesites-updatingsdkname
tadelesh
approved these changes
Oct 29, 2024
|
Approved for Go. |
qiaozha
approved these changes
Oct 29, 2024
live1206
reviewed
Oct 30, 2024
specification/edge/Microsoft.Edge.Sites.Management/tspconfig.yaml
Outdated
Show resolved
Hide resolved
live1206
approved these changes
Oct 30, 2024
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
haagha
pushed a commit
that referenced
this pull request
Nov 19, 2024
* Updating namespace names as per the review Azure/azure-sdk-pr#1889 * Setting namespace for java sdk * Fixing pipeline errors * Adding emitter for python * Fixing pipeline errors * Adding service-dir to fix pipeline error * Fixing pipeline errors * Revert "Fixing pipeline errors" This reverts commit f638130. * Adding configs in typescript file * update * disable sample generation for csharp * disable sample generation of csharp for sitemanager * Removing emitter-output-dir based on review comments --------- Co-authored-by: Yuchao Yan <[email protected]> Co-authored-by: kazrael2119 <[email protected]> Co-authored-by: Wei Hu <[email protected]> Co-authored-by: Wei Hu <[email protected]>
digvijaymali94
pushed a commit
to digvijaymali94/azure-rest-api-specs
that referenced
this pull request
Dec 17, 2024
* Updating namespace names as per the review https://github.com/Azure/azure-sdk-pr/issues/1889 * Setting namespace for java sdk * Fixing pipeline errors * Adding emitter for python * Fixing pipeline errors * Adding service-dir to fix pipeline error * Fixing pipeline errors * Revert "Fixing pipeline errors" This reverts commit f638130. * Adding configs in typescript file * update * disable sample generation for csharp * disable sample generation of csharp for sitemanager * Removing emitter-output-dir based on review comments --------- Co-authored-by: Yuchao Yan <[email protected]> Co-authored-by: kazrael2119 <[email protected]> Co-authored-by: Wei Hu <[email protected]> Co-authored-by: Wei Hu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating namespace names as per the review
https://github.com/Azure/azure-sdk-pr/issues/1889
Choose a PR Template
Switch to "Preview" on this description then select one of the choices below.
Click here to open a PR for a Data Plane API.
Click here to open a PR for a Control Plane (ARM) API.