Release azure managed grafana microsoft.dashboard preview/2023 10 01 preview #31155

yjsong11 · 2024-10-22T17:16:40Z

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

New resource provider.
New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix OpenAPI spec quality issues in S360.
Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec.

Updated the API version from stable/2023-09-01 to preview/2023-10-01-preview.

openapi-pipeline-app · 2024-10-22T17:16:45Z

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

openapi-pipeline-app · 2024-10-22T17:16:45Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/dashboard/armdashboard	https://apiview.dev/Assemblies/Review/a87e05688c634378b5f07adc0d3a74bc?revisionId=776ef920d5b94024bcc4b0fe0b108013
JavaScript	@azure/arm-dashboard	https://apiview.dev/Assemblies/Review/2389a37d321949598282731380a56d66?revisionId=eaca0414dd2f4280a43dfcf3557efbf0
Java	azure-resourcemanager-dashboard	https://apiview.dev/Assemblies/Review/2d0c44fb169c4e63a83d26324161a7f6?revisionId=5240aa2272544e45a95c22933f3f0f7d
.Net	Azure.ResourceManager.Grafana	https://apiview.dev/Assemblies/Review/f65db80b30a841818e8daea21e47b523?revisionId=3b272c289b244d6badbcd7bb3594233f
Swagger	Microsoft.Dashboard	https://apiview.dev/Assemblies/Review/ebe16f612f774d38a44209d5a6093cf6?revisionId=bca9eff62d79489d8230b5931887b75c

mikekistler · 2024-10-23T14:51:13Z

Breaking changes previously reviewed and approved in Azure/azure-rest-api-specs-pr#19253

yjsong11 · 2024-10-23T15:39:44Z

/azp run

azure-pipelines · 2024-10-23T15:40:02Z

Azure Pipelines successfully started running 3 pipeline(s).

…ard-preview/2023-10-01-preview

...ation/dashboard/resource-manager/Microsoft.Dashboard/preview/2023-10-01-preview/grafana.json

ramoka178 · 2024-10-24T22:06:09Z

Please fix the Swagger ModelValidation required check failure too

…ard-preview/2023-10-01-preview

…preview (Azure#31155) * Copy files from stable/2023-09-01 Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to preview/2023-10-01-preview Updated the API version from stable/2023-09-01 to preview/2023-10-01-preview. * Added tag for 2023-10-01-preview in readme file * changes for 2023-10-01-preview * fix prettier * Descriptions * change description * fix rid * fix id * prettier * fix readme * fix readme * fix readme --------- Co-authored-by: Younjin Song <[email protected]> Co-authored-by: kevin-tong-msft <[email protected]>

…preview (#31155) * Copy files from stable/2023-09-01 Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to preview/2023-10-01-preview Updated the API version from stable/2023-09-01 to preview/2023-10-01-preview. * Added tag for 2023-10-01-preview in readme file * changes for 2023-10-01-preview * fix prettier * Descriptions * change description * fix rid * fix id * prettier * fix readme * fix readme * fix readme --------- Co-authored-by: Younjin Song <[email protected]> Co-authored-by: kevin-tong-msft <[email protected]>

…preview (Azure#31155) * Copy files from stable/2023-09-01 Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to preview/2023-10-01-preview Updated the API version from stable/2023-09-01 to preview/2023-10-01-preview. * Added tag for 2023-10-01-preview in readme file * changes for 2023-10-01-preview * fix prettier * Descriptions * change description * fix rid * fix id * prettier * fix readme * fix readme * fix readme --------- Co-authored-by: Younjin Song <[email protected]> Co-authored-by: kevin-tong-msft <[email protected]>

Younjin Song added 4 commits October 22, 2024 11:50

Copy files from stable/2023-09-01

dcd2ef1

Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec.

Update version to preview/2023-10-01-preview

b002bd0

Updated the API version from stable/2023-09-01 to preview/2023-10-01-preview.

Added tag for 2023-10-01-preview in readme file

19b2152

changes for 2023-10-01-preview

c1e1159

fix prettier

8cb060d

yjsong11 added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Oct 22, 2024

mikekistler added the BreakingChange-Approved-Previously Changes were reviewed and approved in a previous PR label Oct 23, 2024

AzureRestAPISpecReview added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed NotReadyForARMReview labels Oct 23, 2024

yjsong11 added PublishToCustomers Acknowledgement the changes will be published to Azure customers. and removed PublishToCustomers Acknowledgement the changes will be published to Azure customers. labels Oct 23, 2024

Merge branch 'main' into release-AzureManagedGrafana-Microsoft.Dashbo…

bc90b8f

…ard-preview/2023-10-01-preview

ramoka178 reviewed Oct 23, 2024

View reviewed changes

...ation/dashboard/resource-manager/Microsoft.Dashboard/preview/2023-10-01-preview/grafana.json Show resolved Hide resolved

ramoka178 reviewed Oct 23, 2024

View reviewed changes

...ation/dashboard/resource-manager/Microsoft.Dashboard/preview/2023-10-01-preview/grafana.json Show resolved Hide resolved

ramoka178 reviewed Oct 23, 2024

View reviewed changes

...ation/dashboard/resource-manager/Microsoft.Dashboard/preview/2023-10-01-preview/grafana.json Outdated Show resolved Hide resolved

yjsong11 added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Oct 24, 2024

ramoka178 added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Oct 24, 2024

openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 24, 2024

yjsong11 added 3 commits October 24, 2024 18:31

fix rid

257583b

fix id

93ce23e

prettier

a177f52

AzureRestAPISpecReview added the ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test label Oct 24, 2024

yjsong11 added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Oct 24, 2024

ramoka178 added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Oct 24, 2024

openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 24, 2024

yjsong11 added 3 commits October 25, 2024 12:08

fix readme

fee960f

fix readme

6d60ff5

fix readme

d0170c9

qingquanzhao approved these changes Oct 25, 2024

View reviewed changes

yjsong11 and others added 3 commits October 25, 2024 14:38

Merge branch 'main' into release-AzureManagedGrafana-Microsoft.Dashbo…

4e23155

…ard-preview/2023-10-01-preview

Merge branch 'main' into release-AzureManagedGrafana-Microsoft.Dashbo…

c8c5b02

…ard-preview/2023-10-01-preview

Merge branch 'main' into release-AzureManagedGrafana-Microsoft.Dashbo…

98cae29

…ard-preview/2023-10-01-preview

kevin-tong-msft self-requested a review October 28, 2024 17:59

kevin-tong-msft approved these changes Oct 28, 2024

View reviewed changes

yjsong11 merged commit ecf1283 into Azure:main Oct 28, 2024
28 of 30 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release azure managed grafana microsoft.dashboard preview/2023 10 01 preview #31155

Release azure managed grafana microsoft.dashboard preview/2023 10 01 preview #31155

yjsong11 commented Oct 22, 2024

openapi-pipeline-app bot commented Oct 22, 2024 •

edited

Loading

openapi-pipeline-app bot commented Oct 22, 2024 •

edited

Loading

mikekistler commented Oct 23, 2024

yjsong11 commented Oct 23, 2024

azure-pipelines bot commented Oct 23, 2024

ramoka178 commented Oct 24, 2024

Release azure managed grafana microsoft.dashboard preview/2023 10 01 preview #31155

Release azure managed grafana microsoft.dashboard preview/2023 10 01 preview #31155

Conversation

yjsong11 commented Oct 22, 2024

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Additional information

Getting help

openapi-pipeline-app bot commented Oct 22, 2024 • edited Loading

Next Steps to Merge

openapi-pipeline-app bot commented Oct 22, 2024 • edited Loading

Generated ApiView

mikekistler commented Oct 23, 2024

yjsong11 commented Oct 23, 2024

azure-pipelines bot commented Oct 23, 2024

ramoka178 commented Oct 24, 2024

openapi-pipeline-app bot commented Oct 22, 2024 •

edited

Loading

openapi-pipeline-app bot commented Oct 22, 2024 •

edited

Loading