Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client setting for ContainerOrchestratorRuntime #30789

Merged
merged 5 commits into from
Oct 14, 2024

Conversation

ArthurMa1978
Copy link
Member

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • Add client.tsp for generating .Net SDK.

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Copy link

openapi-pipeline-app bot commented Sep 30, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented Sep 30, 2024

@ddadaal ddadaal added PublishToCustomers Acknowledgement the changes will be published to Azure customers. BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior labels Oct 8, 2024
@ddadaal
Copy link
Member

ddadaal commented Oct 8, 2024

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@AzureRestAPISpecReview AzureRestAPISpecReview added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed NotReadyForARMReview labels Oct 8, 2024
@ddadaal
Copy link
Member

ddadaal commented Oct 8, 2024

Swagger LintDiff failed with error [Guid Usage])(https://github.com/Azure/azure-openapi-validator/blob/main/docs/guid-usage.md). The relevant property rpObjectId is a GUID, so a GUID format string would be a great fit for it. @ArthurMa1978 please help in the review process.

@raosuhas
Copy link

raosuhas commented Oct 9, 2024

can you please add the suppression for the guid usage. I see that the guid is an AD objectid , so you can just mention this in the suppression

@raosuhas raosuhas added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Oct 9, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 9, 2024
@AzureRestAPISpecReview AzureRestAPISpecReview added ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test SuppressionReviewRequired labels Oct 10, 2024
@ddadaal
Copy link
Member

ddadaal commented Oct 10, 2024

Suppression added

@ddadaal ddadaal added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Oct 10, 2024
@ddadaal
Copy link
Member

ddadaal commented Oct 10, 2024

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@raosuhas raosuhas added Approved-Suppression ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review labels Oct 11, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 11, 2024
@ddadaal ddadaal merged commit 02ff8f0 into Azure:main Oct 14, 2024
25 of 30 checks passed
@ArthurMa1978 ArthurMa1978 deleted the mgmt-k8s-runtime branch October 17, 2024 07:10
haagha pushed a commit that referenced this pull request Nov 19, 2024
* Add client setting for ContainerOrchestratorRuntime

* Update the client.tsp for releasing .Net SDK

* add suppression

---------

Co-authored-by: Junda Chen <[email protected]>
digvijaymali94 pushed a commit to digvijaymali94/azure-rest-api-specs that referenced this pull request Dec 17, 2024
* Add client setting for ContainerOrchestratorRuntime

* Update the client.tsp for releasing .Net SDK

* add suppression

---------

Co-authored-by: Junda Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved-Suppression ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required PublishToCustomers Acknowledgement the changes will be published to Azure customers. ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager RPaaS SuppressionReviewRequired TypeSpec Authored with TypeSpec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants